From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.65; helo=mga03.intel.com; envelope-from=jiewen.yao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B934422393628 for ; Thu, 1 Feb 2018 20:33:07 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Feb 2018 20:38:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,445,1511856000"; d="scan'208";a="24306954" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by FMSMGA003.fm.intel.com with ESMTP; 01 Feb 2018 20:38:45 -0800 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 1 Feb 2018 20:38:44 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 1 Feb 2018 20:38:44 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.124]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.127]) with mapi id 14.03.0319.002; Fri, 2 Feb 2018 12:38:42 +0800 From: "Yao, Jiewen" To: "Fu, Siyuan" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [Patch 0/2] NetworkPkg: Add warning message for PXE if failed to read system GUID from SMBIOS. Thread-Index: AQHTm9X+qTbzjuplWUGZemwmbb1mWaOQeMpw//97EwCAAJPQcA== Date: Fri, 2 Feb 2018 04:38:41 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503AAA3F21@shsmsx102.ccr.corp.intel.com> References: <20180202032858.12824-1-siyuan.fu@intel.com> <74D8A39837DF1E4DA445A8C0B3885C503AAA3E4D@shsmsx102.ccr.corp.intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTU3M2MyNmItYmM5YS00OWY5LWFhYzUtZTExMzExYTgyZDljIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJKSUFWR1wvdndDUThzU1JSV0NvU0lNaGpsNVdyWVVJakVFUjB3eE5UTU9DaUlNb3ZYWjF0REoycGNMeXh6ZkNYSCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch 0/2] NetworkPkg: Add warning message for PXE if failed to read system GUID from SMBIOS. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Feb 2018 04:33:08 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Got it. I agree. > -----Original Message----- > From: Fu, Siyuan > Sent: Friday, February 2, 2018 11:49 AM > To: Yao, Jiewen ; edk2-devel@lists.01.org > Subject: RE: [edk2] [Patch 0/2] NetworkPkg: Add warning message for PXE i= f > failed to read system GUID from SMBIOS. >=20 > Jiewen, >=20 > NetLibGetSystemGuid is also used by some other drivers like DHCP6, and it= 's > acceptable to not use system GUID as client identifier in DHCP protocol. = That's > why I only add the warning in PXE driver. >=20 > BestRegards > Fu Siyuan >=20 > > -----Original Message----- > > From: Yao, Jiewen > > Sent: Friday, February 2, 2018 11:47 AM > > To: Fu, Siyuan ; edk2-devel@lists.01.org > > Subject: RE: [edk2] [Patch 0/2] NetworkPkg: Add warning message for PXE= if > > failed to read system GUID from SMBIOS. > > > > Hi Siyuan > > It is great idea to add such warning message to help debug such PXE iss= ue. > > > > Do you think it will be better if we add such info in NetLib - > > NetLibGetSystemGuid(). > > > > As such, we don't need update all consumers. > > > > Thank you > > Yao Jiewen > > > > > -----Original Message----- > > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf O= f > > Fu > > > Siyuan > > > Sent: Friday, February 2, 2018 11:29 AM > > > To: edk2-devel@lists.01.org > > > Subject: [edk2] [Patch 0/2] NetworkPkg: Add warning message for PXE i= f > > failed > > > to read system GUID from SMBIOS. > > > > > > Current PXE driver uses zero GUID if failed to get the system GUID fr= om > > smbios > > > table, and some OS PXE boot may fail in such case. This patch is to a= dd > > a warning > > > message to inform user that smbios table is missed on the platform. > > > > > > Fu Siyuan (2): > > > NetworkPkg: Add warning message for PXE if failed to read system GU= ID > > > from SMBIOS. > > > MdeModulePkg/PXE: Add warning message for PXE if failed to read > system > > > GUID from SMBIOS. > > > > > > MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcDhcp.c | 5 ++++- > > > NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.c | 3 +++ > > > NetworkPkg/UefiPxeBcDxe/PxeBcImpl.c | 1 + > > > 3 files changed, 8 insertions(+), 1 deletion(-) > > > > > > -- > > > 2.13.0.windows.1 > > > > > > _______________________________________________ > > > edk2-devel mailing list > > > edk2-devel@lists.01.org > > > https://lists.01.org/mailman/listinfo/edk2-devel