From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.93; helo=mga11.intel.com; envelope-from=jiewen.yao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 31B5C223522AD for ; Tue, 13 Mar 2018 01:20:22 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Mar 2018 01:26:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,464,1515484800"; d="scan'208";a="36857859" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga004.fm.intel.com with ESMTP; 13 Mar 2018 01:26:43 -0700 Received: from fmsmsx126.amr.corp.intel.com (10.18.125.43) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 13 Mar 2018 01:26:42 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX126.amr.corp.intel.com (10.18.125.43) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 13 Mar 2018 01:26:42 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.80]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.129]) with mapi id 14.03.0319.002; Tue, 13 Mar 2018 16:26:41 +0800 From: "Yao, Jiewen" To: "Zeng, Star" , "edk2-devel@lists.01.org" CC: "Dong, Eric" , "Zhang, Chao B" Thread-Topic: [PATCH] SecurityPkg OpalPasswordPei: Continue when AhciModeInitialize is failed Thread-Index: AQHTuqN/AkdTNwrl6k2nwIkaSvUYZ6PN1LUg Date: Tue, 13 Mar 2018 08:26:40 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503AAFA9D6@shsmsx102.ccr.corp.intel.com> References: <1520928931-97288-1-git-send-email-star.zeng@intel.com> In-Reply-To: <1520928931-97288-1-git-send-email-star.zeng@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZGU3MTllZTUtMzIwNi00NGFlLWJiOGYtMzA1YzFjNmZmM2QzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJQZVNyVlFudkJqeDlXM3hreU9UTDBtXC94UEhzQW5KbjJCWWNlTElvVHBmekpuMUR2bVdvUVh6SGFwTGVkeW5nciJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] SecurityPkg OpalPasswordPei: Continue when AhciModeInitialize is failed X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Mar 2018 08:20:22 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jiewen.yao@intel.com > -----Original Message----- > From: Zeng, Star > Sent: Tuesday, March 13, 2018 4:16 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Yao, Jiewen ; > Dong, Eric ; Zhang, Chao B > Subject: [PATCH] SecurityPkg OpalPasswordPei: Continue when > AhciModeInitialize is failed >=20 > Continue to next loop instead of going to unlock OPAL password when > AhciModeInitialize is failed. >=20 > It is just error handling. >=20 > Cc: Jiewen Yao > Cc: Eric Dong > Cc: Chao Zhang > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Star Zeng > --- > SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordPei.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordPei.c > b/SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordPei.c > index 7f9e14fa81a7..0aad6591aaaa 100644 > --- a/SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordPei.c > +++ b/SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordPei.c > @@ -717,6 +717,7 @@ UnlockOpalPasswordAta ( > ASSERT_EFI_ERROR (Status); > if (EFI_ERROR (Status)) { > DEBUG ((DEBUG_ERROR, "%a() AhciModeInitialize() error, > Status: %r\n", __FUNCTION__, Status)); > + continue; > } >=20 > OpalDev.Signature =3D OPAL_PEI_DEVICE_SIGNATURE; > -- > 2.7.0.windows.1