* [PATCH] SecurityPkg OpalPasswordPei: Continue when AhciModeInitialize is failed
@ 2018-03-13 8:15 Star Zeng
2018-03-13 8:26 ` Yao, Jiewen
0 siblings, 1 reply; 2+ messages in thread
From: Star Zeng @ 2018-03-13 8:15 UTC (permalink / raw)
To: edk2-devel; +Cc: Star Zeng, Jiewen Yao, Eric Dong, Chao Zhang
Continue to next loop instead of going to unlock OPAL password when
AhciModeInitialize is failed.
It is just error handling.
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Chao Zhang <chao.b.zhang@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng <star.zeng@intel.com>
---
SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordPei.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordPei.c b/SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordPei.c
index 7f9e14fa81a7..0aad6591aaaa 100644
--- a/SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordPei.c
+++ b/SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordPei.c
@@ -717,6 +717,7 @@ UnlockOpalPasswordAta (
ASSERT_EFI_ERROR (Status);
if (EFI_ERROR (Status)) {
DEBUG ((DEBUG_ERROR, "%a() AhciModeInitialize() error, Status: %r\n", __FUNCTION__, Status));
+ continue;
}
OpalDev.Signature = OPAL_PEI_DEVICE_SIGNATURE;
--
2.7.0.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] SecurityPkg OpalPasswordPei: Continue when AhciModeInitialize is failed
2018-03-13 8:15 [PATCH] SecurityPkg OpalPasswordPei: Continue when AhciModeInitialize is failed Star Zeng
@ 2018-03-13 8:26 ` Yao, Jiewen
0 siblings, 0 replies; 2+ messages in thread
From: Yao, Jiewen @ 2018-03-13 8:26 UTC (permalink / raw)
To: Zeng, Star, edk2-devel@lists.01.org; +Cc: Dong, Eric, Zhang, Chao B
Reviewed-by: Jiewen.yao@intel.com
> -----Original Message-----
> From: Zeng, Star
> Sent: Tuesday, March 13, 2018 4:16 PM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star <star.zeng@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>;
> Dong, Eric <eric.dong@intel.com>; Zhang, Chao B <chao.b.zhang@intel.com>
> Subject: [PATCH] SecurityPkg OpalPasswordPei: Continue when
> AhciModeInitialize is failed
>
> Continue to next loop instead of going to unlock OPAL password when
> AhciModeInitialize is failed.
>
> It is just error handling.
>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Chao Zhang <chao.b.zhang@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Star Zeng <star.zeng@intel.com>
> ---
> SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordPei.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordPei.c
> b/SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordPei.c
> index 7f9e14fa81a7..0aad6591aaaa 100644
> --- a/SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordPei.c
> +++ b/SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordPei.c
> @@ -717,6 +717,7 @@ UnlockOpalPasswordAta (
> ASSERT_EFI_ERROR (Status);
> if (EFI_ERROR (Status)) {
> DEBUG ((DEBUG_ERROR, "%a() AhciModeInitialize() error,
> Status: %r\n", __FUNCTION__, Status));
> + continue;
> }
>
> OpalDev.Signature = OPAL_PEI_DEVICE_SIGNATURE;
> --
> 2.7.0.windows.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-13 8:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-13 8:15 [PATCH] SecurityPkg OpalPasswordPei: Continue when AhciModeInitialize is failed Star Zeng
2018-03-13 8:26 ` Yao, Jiewen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox