From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.136; helo=mga12.intel.com; envelope-from=jiewen.yao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D09D8223522AD for ; Tue, 13 Mar 2018 01:21:29 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Mar 2018 01:27:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,464,1515484800"; d="scan'208";a="24049106" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga008.fm.intel.com with ESMTP; 13 Mar 2018 01:27:51 -0700 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 13 Mar 2018 01:27:48 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 13 Mar 2018 01:27:47 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.80]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.226]) with mapi id 14.03.0319.002; Tue, 13 Mar 2018 16:27:46 +0800 From: "Yao, Jiewen" To: "Zeng, Star" , "edk2-devel@lists.01.org" CC: "Zhang, Chao B" , "Dong, Eric" , "Zeng, Star" Thread-Topic: [edk2] [PATCH] SecurityPkg OpalPasswordDxe: Move OPAL request variable definition Thread-Index: AQHTumq0U8hnXckPQEGtynQD8HBzqqPN1XGg Date: Tue, 13 Mar 2018 08:27:45 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503AAFA9E8@shsmsx102.ccr.corp.intel.com> References: <1520904542-98184-1-git-send-email-star.zeng@intel.com> In-Reply-To: <1520904542-98184-1-git-send-email-star.zeng@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjUxOTQ1NGUtZTQyNC00NzYyLWJlODEtYTUzZjc0ZTY3M2E2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiI2VGREbmFPVHVtVTY2bDdqdzFcL1E2U1wvemlOR3JpTlB3MFhocWdhXC9YU1Uwdm1Id1MxcjN0NHIxWVBCWUl0SER5In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] SecurityPkg OpalPasswordDxe: Move OPAL request variable definition X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Mar 2018 08:21:30 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jiewen.yao@intel.com > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of St= ar > Zeng > Sent: Tuesday, March 13, 2018 9:29 AM > To: edk2-devel@lists.01.org > Cc: Zhang, Chao B ; Yao, Jiewen > ; Dong, Eric ; Zeng, Star > > Subject: [edk2] [PATCH] SecurityPkg OpalPasswordDxe: Move OPAL request > variable definition >=20 > Move OPAL request variable definition from OpalHiiFormValues.h to > OpalHii.h. >=20 > Cc: Jiewen Yao > Cc: Eric Dong > Cc: Chao Zhang > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Star Zeng > --- > SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.h | 11 +++++++++++ > SecurityPkg/Tcg/Opal/OpalPassword/OpalHiiFormValues.h | 8 -------- > 2 files changed, 11 insertions(+), 8 deletions(-) >=20 > diff --git a/SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.h > b/SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.h > index a1b1131c1380..906106b3f5e8 100644 > --- a/SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.h > +++ b/SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.h > @@ -26,8 +26,19 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY > KIND, EITHER EXPRESS OR IMPLIED. > 0x0d510a4f, 0xa81b, 0x473f, { 0x87, 0x07, 0xb7, 0xfd, 0xfb, 0xc0, 0x= 45, > 0xba } \ > } >=20 > +#define OPAL_REQUEST_VARIABLE_NAME L"OpalRequest" > + > #pragma pack(1) >=20 > +// > +// Request for one device. > +// > +typedef struct { > + UINT32 Length; > + OPAL_REQUEST OpalRequest; > + //EFI_DEVICE_PATH_PROTOCOL OpalDevicePath; > +} OPAL_REQUEST_VARIABLE; > + > typedef struct { > UINT16 Id: HII_KEY_ID_BITS; > UINT16 Index: HII_KEY_INDEX_BITS; > diff --git a/SecurityPkg/Tcg/Opal/OpalPassword/OpalHiiFormValues.h > b/SecurityPkg/Tcg/Opal/OpalPassword/OpalHiiFormValues.h > index 3ff7d4726d5e..a2313fed290b 100644 > --- a/SecurityPkg/Tcg/Opal/OpalPassword/OpalHiiFormValues.h > +++ b/SecurityPkg/Tcg/Opal/OpalPassword/OpalHiiFormValues.h > @@ -20,8 +20,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY > KIND, EITHER EXPRESS OR IMPLIED. > #define FORMID_VALUE_MAIN_MENU 0x01 > #define FORMID_VALUE_DISK_INFO_FORM_MAIN 0x02 >=20 > -#define OPAL_REQUEST_VARIABLE_NAME > L"OpalRequest" > - > #pragma pack(1) > typedef struct { > UINT16 Lock:1; > @@ -48,12 +46,6 @@ typedef struct { > UINT8 EnableBlockSid; > } OPAL_HII_CONFIGURATION; >=20 > -typedef struct { > - UINT32 Length; > - OPAL_REQUEST OpalRequest; > - //EFI_DEVICE_PATH_PROTOCOL OpalDevicePath; > -} OPAL_REQUEST_VARIABLE; > - > #pragma pack() >=20 > /* Action Flags */ > -- > 2.7.0.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel