From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.126; helo=mga18.intel.com; envelope-from=jiewen.yao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C550421FB7D32 for ; Mon, 2 Apr 2018 19:34:25 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Apr 2018 19:34:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,398,1517904000"; d="scan'208";a="217122993" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga005.fm.intel.com with ESMTP; 02 Apr 2018 19:34:24 -0700 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 2 Apr 2018 19:34:24 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 2 Apr 2018 19:34:24 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.80]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.108]) with mapi id 14.03.0319.002; Tue, 3 Apr 2018 10:34:21 +0800 From: "Yao, Jiewen" To: "Zeng, Star" , "Wang, Jian J" , "Kinney, Michael D" , Heyi Guo , "edk2-devel@lists.01.org" CC: "Ni, Ruiyu" , Yi Li , "Gao, Liming" , "Dong, Eric" , "Renhao Liang" Thread-Topic: [PATCH 1/1] MdeModulePkg/Gcd: Fix bug of attribute conversion Thread-Index: AQHTysuul9m0MeErLECBOjC94C7CoaPtsjmAgAAEo4CAAAJTAIAAjDwA//+HH4CAAIY50A== Date: Tue, 3 Apr 2018 02:34:21 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503AB1F71F@shsmsx102.ccr.corp.intel.com> References: <1522311590-104218-1-git-send-email-heyi.guo@linaro.org> <0C09AFA07DD0434D9E2A0C6AEB0483103BA75236@shsmsx102.ccr.corp.intel.com> <0C09AFA07DD0434D9E2A0C6AEB0483103BA7547F@shsmsx102.ccr.corp.intel.com> <0C09AFA07DD0434D9E2A0C6AEB0483103BA7549E@shsmsx102.ccr.corp.intel.com> <74D8A39837DF1E4DA445A8C0B3885C503AB1F68A@shsmsx102.ccr.corp.intel.com> <0C09AFA07DD0434D9E2A0C6AEB0483103BA7652B@shsmsx102.ccr.corp.intel.com> In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB0483103BA7652B@shsmsx102.ccr.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYmY4YjI4ZDItNWJiYi00ZDNiLTllNTMtYzRiNzIyODRlYTc3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJGVnlUOHJpcnpYZFhYY2RiUFRPR2U1Z0RveXhodERDNU9oOXI3Mzl0d1pYVnFrSnF1TmpnZkV5Ym42akVUamQxIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 1/1] MdeModulePkg/Gcd: Fix bug of attribute conversion X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Apr 2018 02:34:26 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable That is good idea. Just add more description as the code comment, please. It is easy for code review later. Thank you Yao Jiewen > -----Original Message----- > From: Zeng, Star > Sent: Tuesday, April 3, 2018 10:33 AM > To: Yao, Jiewen ; Wang, Jian J ; > Kinney, Michael D ; Heyi Guo > ; edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Yi Li ; Gao, > Liming ; Dong, Eric ; Renhao > Liang ; Zeng, Star > Subject: RE: [PATCH 1/1] MdeModulePkg/Gcd: Fix bug of attribute conversio= n >=20 > Agree. >=20 > And I agree we need the fix at > https://lists.01.org/pipermail/edk2-devel/2018-April/023364.html from Mik= e > for compatibility. > And I think more precious and precise information need to be added into t= he > commit log or code comments since we have been crazy about handling > attributes in the GCD service. :) >=20 >=20 > Thanks, > Star > -----Original Message----- > From: Yao, Jiewen > Sent: Tuesday, April 3, 2018 10:26 AM > To: Wang, Jian J ; Zeng, Star ; > Kinney, Michael D ; Heyi Guo > ; edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Yi Li ; Gao, > Liming ; Dong, Eric ; Renhao > Liang > Subject: RE: [PATCH 1/1] MdeModulePkg/Gcd: Fix bug of attribute conversio= n >=20 > I have a discussion with Star/Jian. >=20 > The expectation for the CPU driver is to handle PageAttribute. > The expectation for the platform driver is to use GetAttribute(), AND/OR > attribute, then call SetAttribute(). > Because the DRAM always has a cache attribute (no matter UC or WB), 0 sho= uld > not happen. (0 might happen for a GCD reserved memory, but there is no ne= ed > to set page attribute) >=20 > If all drivers use above way, there won't be any issue. There is no need = to > introduce a new protocol so far. >=20 > We did encounter some error, because the platform/silicon/CPU code is not > updated yet. (For example, the MinnowMax which is using binary) The fix t= o > filter 0 seems a workable way to resolve the compatibility issue. >=20 > Later, I suggest we update MinnowMax binary - Add paging handling for CPU > driver, and use GetAttribute()/SetAttribute() for platform/silicon code. >=20 >=20 > Thank you > Yao Jiewen >=20 > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > > Wang, Jian J > > Sent: Tuesday, April 3, 2018 9:24 AM > > To: Zeng, Star ; Kinney, Michael D > > ; Heyi Guo ; > > edk2-devel@lists.01.org > > Cc: Ni, Ruiyu ; Yi Li ; > > Gao, Liming ; Dong, Eric ; > > Renhao Liang > > Subject: Re: [edk2] [PATCH 1/1] MdeModulePkg/Gcd: Fix bug of attribute > > conversion > > > > The NX Memory Protection and Heap Guard features need to clear paging > > attributes. > > Allowing 0 attribute is the current only choice without changing arch p= rotocol. > > Maybe > > It's time to introduce a new protocol. > > > > Regards, > > Jian > > > > > > > -----Original Message----- > > > From: Zeng, Star > > > Sent: Tuesday, April 03, 2018 9:16 AM > > > To: Kinney, Michael D ; Heyi Guo > > > ; edk2-devel@lists.01.org > > > Cc: Yi Li ; Renhao Liang > > > ; Dong, Eric ; Gao, > > > Liming ; Wang, Jian J ; > > > Ni, Ruiyu ; Zeng, Star > > > Subject: RE: [PATCH 1/1] MdeModulePkg/Gcd: Fix bug of attribute > > > conversion > > > > > > Current gCpu->SetMemoryAttributes does not support getting memory > > > attributes, and has no clear description about clearing memory attrib= utes. > > > > > > I noticed we introduced > > > > > > SmmMemoryAttribute(MdeModulePkg\Include\Protocol\SmmMemoryAttribut > > e. > > > h) protocol for heap guard feature in SMM environment. > > > Seemingly, we also need introduce MemoryAttribute protocol for DXE? > > > > > > > > > Thanks, > > > Star > > > -----Original Message----- > > > From: Zeng, Star > > > Sent: Tuesday, April 3, 2018 8:59 AM > > > To: Kinney, Michael D ; Heyi Guo > > > ; edk2-devel@lists.01.org > > > Cc: Yi Li ; Renhao Liang > > > ; Dong, Eric ; Gao, > > > Liming ; Wang, Jian J ; > > > Ni, Ruiyu ; Zeng, Star > > > Subject: RE: [PATCH 1/1] MdeModulePkg/Gcd: Fix bug of attribute > > > conversion > > > > > > Mike, > > > > > > Agree the problem. > > > We need support only RUNTIME attribute. > > > We need support only cache attributes. > > > We need support only page attributes. > > > We need support RUNTIME + cache + page attributes. > > > Do we need support the 0 Attributes case to clear page attributes? > > > There was discussion about the 0 Attributes case at > > > https://lists.01.org/pipermail/edk2-devel/2018-March/023315.html. > > > It came to the question that should the 0 Attributes case be handled > > > by > > > SetMemoryAttributes() to clear the page attributes? > > > > > > > > > Thanks, > > > Star > > > -----Original Message----- > > > From: Kinney, Michael D > > > Sent: Tuesday, April 3, 2018 5:43 AM > > > To: Zeng, Star ; Heyi Guo > > > ; edk2- devel@lists.01.org; Kinney, Michael D > > > > > > Cc: Yi Li ; Renhao Liang > > > ; Dong, Eric ; Gao, > > > Liming ; Wang, Jian J ; > > > Ni, Ruiyu > > > Subject: RE: [PATCH 1/1] MdeModulePkg/Gcd: Fix bug of attribute > > > conversion > > > > > > Star, > > > > > > This commit breaks Vlv2TbltDevicePkg. > > > > > > On this platform, there are 2 calls to > > > gDS->SetMemorySpaceAttributes() for an MMIO > > > range to set only the EFI_MEMORY_RUNTIME bit. > > > > > > With this commit, ConverToCpuArchAttributes()returns 0, and 0 is > > > passed to > > > gCpu->SetMemoryAttributes()that returns EFI_INVALID_PARAMETER on > > > Vlv2TbltDevicePkg. > > > > > > Before this commit, ConverToCpuArchAttributes() returns > > > INVALID_CPU_ARCH_ATTRIBUTES which causes the call to gCpu- > > > >SetMemoryAttributes()to be skipped so no error is generated. > > > > > > I think the right fix is to skip the call to > > > gCpu->SetMemoryAttributes() if CpuArchAttributes > > > is 0 so a call that only sets the RUNTIME attribute can be supported > > > along with call the set both the RUNTIME bit and other cache related = bits. > > > > > > I will send a patch soon with the proposed fix. > > > > > > Mike > > > > > > > -----Original Message----- > > > > From: Zeng, Star > > > > Sent: Sunday, April 1, 2018 10:59 PM > > > > To: Heyi Guo ; edk2- devel@lists.01.org > > > > Cc: Yi Li ; Renhao Liang > > > > ; Dong, Eric ; > > > > Kinney, Michael D ; Gao, Liming > > > > ; Wang, Jian J ; Ni, > > > > Ruiyu ; Zeng, Star > > > > Subject: RE: [PATCH 1/1] MdeModulePkg/Gcd: Fix bug of attribute > > > > conversion > > > > > > > > Pushed at 5b91bf82c67b586b9588cbe4bbffa1588f6b5926. > > > > > > > > Thanks, > > > > Star > > > > -----Original Message----- > > > > From: Heyi Guo [mailto:heyi.guo@linaro.org] > > > > Sent: Thursday, March 29, 2018 4:20 PM > > > > To: edk2-devel@lists.01.org > > > > Cc: Heyi Guo ; Yi Li > > > > ; Renhao Liang ; > > > > Zeng, Star ; Dong, Eric > > > > ; Kinney, Michael D > > > > ; Gao, Liming ; > > > > Wang, Jian J ; Ni, Ruiyu > > > > > > > > Subject: [PATCH 1/1] MdeModulePkg/Gcd: Fix bug of attribute > > > > conversion > > > > > > > > For gDS->SetMemorySpaceAttributes(), when user passes a combined > > > > memory attribute including CPU arch attribute and other > > > > attributes, like EFI_MEMORY_RUNTIME, > > > > ConverToCpuArchAttributes() will return > > > > INVALID_CPU_ARCH_ATTRIBUTES and skip setting page/cache attribute f= or > the specified memory space. > > > > > > > > We don't see any reason to forbid combining CPU arch attributes > > > > and non-CPU-arch attributes when calling gDS- > > > > >SetMemorySpaceAttributes(), so we remove the check code > > > > in ConverToCpuArchAttributes(); the remaining code is enough to > > > > grab the interested bits for > > > > Cpu->SetMemoryAttributes(). > > > > > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > > Signed-off-by: Heyi Guo > > > > Signed-off-by: Yi Li > > > > Signed-off-by: Renhao Liang > > > > Cc: Star Zeng > > > > Cc: Eric Dong > > > > Cc: Michael D Kinney > > > > Cc: Liming Gao > > > > Cc: Jian J Wang > > > > Cc: Ruiyu Ni > > > > --- > > > > MdeModulePkg/Core/Dxe/Gcd/Gcd.c | 5 ----- > > > > 1 file changed, 5 deletions(-) > > > > > > > > diff --git a/MdeModulePkg/Core/Dxe/Gcd/Gcd.c > > > > b/MdeModulePkg/Core/Dxe/Gcd/Gcd.c index > > > > 77f4adb4bc01..907245a3f512 100644 > > > > --- a/MdeModulePkg/Core/Dxe/Gcd/Gcd.c > > > > +++ b/MdeModulePkg/Core/Dxe/Gcd/Gcd.c > > > > @@ -673,11 +673,6 @@ ConverToCpuArchAttributes ( { > > > > UINT64 CpuArchAttributes; > > > > > > > > - if ((Attributes & ~(EXCLUSIVE_MEMORY_ATTRIBUTES | > > > > - NONEXCLUSIVE_MEMORY_ATTRIBUTES)) > > > > !=3D 0) { > > > > - return INVALID_CPU_ARCH_ATTRIBUTES; > > > > - } > > > > - > > > > CpuArchAttributes =3D Attributes & > > > > NONEXCLUSIVE_MEMORY_ATTRIBUTES; > > > > > > > > if ( (Attributes & EFI_MEMORY_UC) =3D=3D EFI_MEMORY_UC) { > > > > -- > > > > 2.7.4 > > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel