From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.43; helo=mga05.intel.com; envelope-from=jiewen.yao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0231B225264AA for ; Wed, 4 Apr 2018 17:02:44 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Apr 2018 17:02:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,409,1517904000"; d="scan'208";a="30821115" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga007.jf.intel.com with ESMTP; 04 Apr 2018 17:02:44 -0700 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 4 Apr 2018 17:02:43 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 4 Apr 2018 17:02:43 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.61]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.92]) with mapi id 14.03.0319.002; Thu, 5 Apr 2018 08:02:41 +0800 From: "Yao, Jiewen" To: "Kinney, Michael D" , "edk2-devel@lists.01.org" CC: Sean Brogan , "Zeng, Star" , "Dong, Eric" , "Wei, David" , "Guo, Mang" , "Steele, Kelly" Thread-Topic: [Patch 0/9] Add DisplayUpdateProgressLib for capsules Thread-Index: AQHTzFMoDt3RywPCNUyhj3dZcScwI6PxQ/Lw Date: Thu, 5 Apr 2018 00:02:41 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503AB376CC@shsmsx102.ccr.corp.intel.com> References: <20180404202554.9568-1-michael.d.kinney@intel.com> In-Reply-To: <20180404202554.9568-1-michael.d.kinney@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZGI0OTczYzMtYmRlNS00Yjg0LWEyNmUtZGEwZTU1MTA3MzQwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJOZGhxSWV5VDBWd0NZcUVVVWs1NTJEZk1VNisxQzBCZktpdjhpR0Q3Nno4OG1za21mbVBoeFNXM2VMb0VjN0luIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch 0/9] Add DisplayUpdateProgressLib for capsules X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Apr 2018 00:02:45 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks Mike. It is a good feature to add progress support. Some thought below: 1) for EDKII_FIRMWARE_MANAGEMENT_PROGRESS_PROTOCOL Do you think if we need add full support for WatchdogTimer services? Such as WatchdogCode, WatchdogData? Or should we add a version field for the protocol for future extension? 2) For EDKII_FIRMWARE_MANAGEMENT_PROGRESS_PROTOCOL and DisplayUpdateProgres= s(), we only add EFI_GRAPHICS_OUTPUT_BLT_PIXEL_UNION *Color. Do the color means the foreground color or background color? I found you treat as background in TextLib. But it seems complicated. Can we add both to avoid calculation? That might be another reason to add version field for EDKII_FIRMWARE_MANAGE= MENT_PROGRESS_PROTOCOL. 3) According to lib naming conversion, we should use DisplayUpdateProgressL= ibGraphic, and DisplayUpdateProgressLibText. :-) 4) For PerformFlashWriteWithProgress(), I found the caller (system firmware= update) handles Progress (StartPercentage) and Progress (EndPercentage). And the callee (Quark flash access lib) handles Progress (StartPercentage) = but not Progress (EndPercentage). That is a little weird to me. Can we add more detail description in the Per= formFlashWriteWithProgress() function header to clarify who should handle S= tartPercentage and EndPercentage ? Thank you Yao Jiewen > -----Original Message----- > From: Kinney, Michael D > Sent: Thursday, April 5, 2018 4:26 AM > To: edk2-devel@lists.01.org > Cc: Sean Brogan ; Zeng, Star > ; Dong, Eric ; Yao, Jiewen > ; Wei, David ; Guo, Mang > ; Steele, Kelly > Subject: [Patch 0/9] Add DisplayUpdateProgressLib for capsules >=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D801 >=20 > Based on content from: >=20 > https://github.com/Microsoft/MS_UEFI/blob/share/MsCapsuleSupport/MsCaps > uleUpdatePkg/Include/Library/DisplayUpdateProgressLib.h > https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport/MsCapsu > leUpdatePkg/Library/DisplayUpdateProgressGraphicsLib > https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport/MsCapsu > leUpdatePkg/Library/DisplayUpdateProgressTextLib >=20 > Add DisplayUpdateProgressLib class along implementations for both graphic= al > (Graphics Output Protocol based) and text (Simple Text Output Protocol ba= sed) > consoles. Also add the EDK II Firmware Management Progress Protocol that= is > an > optional protocol that provides the progress bar color and a watchdog tim= eout > value thaty can be used when a firmware image is updated in a firmware de= vice. >=20 > * Add progress support to DxeCapsuleLibFmp > * Add progress support to SystemFirmwareUpdateDxe > * Add progress support to PlatformFlashAccessLib class and instances. > * Reduce Print() calls during a firmware update. >=20 > Cc: Sean Brogan > Cc: Star Zeng > Cc: Eric Dong > Cc: Jiewen Yao > Cc: David Wei > Cc: Mang Guo > Cc: Kelly Steele >=20 > Signed-off-by: Michael D Kinney > Contributed-under: TianoCore Contribution Agreement 1.1 >=20 > Kinney, Michael D (3): > QuarkPlatformPkg: Add DisplayUpdateProgressLib mapping > MdeModulePkg/DxeCapsuleLibFmp: Add progress bar support > SignedCapsulePkg/SystemFirmwareUpdateDxe: Use progress API >=20 > Michael D Kinney (6): > MdeModulePkg: Add DisplayUpdateProgressLib class > MdeModulePkg: Add DisplayUpdateProgressLib instances > Vlv2Tbl2DevicePkg: Add DisplayUpdateProgressLib mapping > SignedCapsulePkg/PlatformFlashAccessLib: Add progress API > Vlv2TbltDevicePkg/PlatformFlashAccessLib: Add progress API > QuarkPlatformPkg/PlatformFlashAccessLib: Add progress API >=20 > .../Include/Library/DisplayUpdateProgressLib.h | 65 +++ > .../Include/Protocol/FirmwareManagementProgress.h | 50 +++ > .../DisplayUpdateProgressGraphicsLib.c | 475 > +++++++++++++++++++++ > .../DisplayUpdateProgressGraphicsLib.inf | 60 +++ > .../DisplayUpdateProgressGraphicsLib.uni | 18 + > .../DisplayUpdateProgressTextLib.c | 142 ++++++ > .../DisplayUpdateProgressTextLib.inf | 53 +++ > .../DisplayUpdateProgressTextLib.uni | 18 + > .../Library/DxeCapsuleLibFmp/DxeCapsuleLib.c | 47 +- > .../Library/DxeCapsuleLibFmp/DxeCapsuleLib.inf | 8 +- > .../DxeCapsuleLibFmp/DxeCapsuleProcessLib.c | 84 +++- > .../DxeCapsuleLibFmp/DxeCapsuleProcessLibNull.c | 21 +- > .../DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf | 7 +- > MdeModulePkg/MdeModulePkg.dec | 11 + > MdeModulePkg/MdeModulePkg.dsc | 3 + > .../PlatformFlashAccessLibDxe.c | 59 ++- > QuarkPlatformPkg/Quark.dsc | 1 + > .../Include/Library/PlatformFlashAccessLib.h | 33 +- > .../PlatformFlashAccessLibNull.c | 54 ++- > .../SystemFirmwareUpdate/SystemFirmwareUpdateDxe.c | 92 ++-- > .../PlatformFlashAccessLib.c | 84 ++-- > .../PlatformFlashAccessLib.inf | 3 +- > Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 1 + > Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 1 + > Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 1 + > 25 files changed, 1285 insertions(+), 106 deletions(-) > create mode 100644 > MdeModulePkg/Include/Library/DisplayUpdateProgressLib.h > create mode 100644 > MdeModulePkg/Include/Protocol/FirmwareManagementProgress.h > create mode 100644 > MdeModulePkg/Library/DisplayUpdateProgressGraphicsLib/DisplayUpdateProg > ressGraphicsLib.c > create mode 100644 > MdeModulePkg/Library/DisplayUpdateProgressGraphicsLib/DisplayUpdateProg > ressGraphicsLib.inf > create mode 100644 > MdeModulePkg/Library/DisplayUpdateProgressGraphicsLib/DisplayUpdateProg > ressGraphicsLib.uni > create mode 100644 > MdeModulePkg/Library/DisplayUpdateProgressTextLib/DisplayUpdateProgressT > extLib.c > create mode 100644 > MdeModulePkg/Library/DisplayUpdateProgressTextLib/DisplayUpdateProgressT > extLib.inf > create mode 100644 > MdeModulePkg/Library/DisplayUpdateProgressTextLib/DisplayUpdateProgressT > extLib.uni >=20 > -- > 2.14.2.windows.3