From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.43; helo=mga05.intel.com; envelope-from=jiewen.yao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1F75D2274F3D2 for ; Thu, 12 Apr 2018 20:34:30 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Apr 2018 20:34:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,444,1517904000"; d="scan'208";a="216247594" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga005.jf.intel.com with ESMTP; 12 Apr 2018 20:34:29 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 12 Apr 2018 20:34:29 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 12 Apr 2018 20:34:28 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.184]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.149]) with mapi id 14.03.0319.002; Fri, 13 Apr 2018 11:34:25 +0800 From: "Yao, Jiewen" To: "Zeng, Star" , "edk2-devel@lists.01.org" CC: "Chiu, Chasel" , "Chan, Amy" , "Chaganty, Rangasai V" Thread-Topic: [PATCH] SignedCapsulePkg SystemCapsuleLib: Change some dbg level to DEBUG_INFO Thread-Index: AQHTy/Bn45c2P3qyVEyxtnJ6+GF6O6P+GLew Date: Fri, 13 Apr 2018 03:34:24 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503AB574DD@shsmsx102.ccr.corp.intel.com> References: <1522831140-77944-1-git-send-email-star.zeng@intel.com> In-Reply-To: <1522831140-77944-1-git-send-email-star.zeng@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTIxMjkwNGItMjdiYi00ODg3LWFhNmQtMmMyYTIyM2YyZWNjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJJcnJicHNYenhOWnNwVmZ6SEw4ekVJQ1pac3hxVmFYdEpPcDlOaFd5U015YmRpWDdjWHMyUm4zdnY0dW9sdUJQIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] SignedCapsulePkg SystemCapsuleLib: Change some dbg level to DEBUG_INFO X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Apr 2018 03:34:31 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: jiewen.yao@intel.com > -----Original Message----- > From: Zeng, Star > Sent: Wednesday, April 4, 2018 4:39 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Yao, Jiewen ; > Chiu, Chasel ; Chan, Amy ; > Chaganty, Rangasai V > Subject: [PATCH] SignedCapsulePkg SystemCapsuleLib: Change some dbg level= to > DEBUG_INFO >=20 > This debug message should be info instead of error. This patch is to > change the debug level to DEBUG_INFO. > DEBUG((DEBUG_ERROR, "checking FV....0x%08x - 0x%x\n", > FvHeader, FvHeader->FvLength)); // "Mark" >=20 > This comment is inaccurate. This patch is to remove it. > // > // Check section > // >=20 > This debug message should be removed as FvHeader may have been out of > range FdStart and FdSize, and the loop will go to "Mark" above again if > FvHeader is not out of range FdStart and FdSize, and then that debug > message will be shown. This patch is to remove this debug message. > DEBUG((DEBUG_ERROR, "Next FV....0x%08x - 0x%x\n", > FvHeader, FvHeader->FvLength)); >=20 > Cc: Jiewen Yao > Cc: Chasel Chiu > Cc: Amy Chan > Cc: Rangasai V Chaganty > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Star Zeng > --- > .../Library/EdkiiSystemCapsuleLib/EdkiiSystemCapsuleLib.c | 8 > ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) >=20 > diff --git > a/SignedCapsulePkg/Library/EdkiiSystemCapsuleLib/EdkiiSystemCapsuleLib.c > b/SignedCapsulePkg/Library/EdkiiSystemCapsuleLib/EdkiiSystemCapsuleLib.c > index 876d2257b365..5cb97bf93118 100644 > --- a/SignedCapsulePkg/Library/EdkiiSystemCapsuleLib/EdkiiSystemCapsuleLi= b.c > +++ > b/SignedCapsulePkg/Library/EdkiiSystemCapsuleLib/EdkiiSystemCapsuleLib.c > @@ -6,7 +6,7 @@ > CapsuleAuthenticateSystemFirmware(), ExtractAuthenticatedImage() will > receive > untrusted input and do basic validation. >=20 > - Copyright (c) 2016 - 2017, Intel Corporation. All rights reserved.
> + Copyright (c) 2016 - 2018, Intel Corporation. All rights reserved.
> This program and the accompanying materials > are licensed and made available under the terms and conditions of the = BSD > License > which accompanies this distribution. The full text of the license may= be > found at > @@ -188,7 +188,7 @@ GetFfsByName ( > FvHeader =3D (EFI_FIRMWARE_VOLUME_HEADER *)((UINTN)FvHeader + > SIZE_4KB); > continue; > } > - DEBUG((DEBUG_ERROR, "checking FV....0x%08x - 0x%x\n", FvHeader, > FvHeader->FvLength)); > + DEBUG((DEBUG_INFO, "checking FV....0x%08x - 0x%x\n", FvHeader, > FvHeader->FvLength)); > FvFound =3D TRUE; > if (FvHeader->FvLength > FvSize) { > DEBUG((DEBUG_ERROR, "GetFfsByName - FvSize: 0x%08x, MaxSize - > 0x%08x\n", (UINTN)FvHeader->FvLength, (UINTN)FvSize)); > @@ -225,9 +225,6 @@ GetFfsByName ( >=20 > if (CompareGuid(FileName, &FfsHeader->Name) && > ((Type =3D=3D EFI_FV_FILETYPE_ALL) || (FfsHeader->Type =3D=3D = Type))) { > - // > - // Check section > - // > *OutFfsBuffer =3D FfsHeader; > *OutFfsBufferSize =3D FfsSize; > return TRUE; > @@ -248,7 +245,6 @@ GetFfsByName ( > // Next FV > // > FvHeader =3D (VOID *)(UINTN)((UINTN)FvHeader + FvHeader->FvLength); > - DEBUG((DEBUG_ERROR, "Next FV....0x%08x - 0x%x\n", FvHeader, > FvHeader->FvLength)); > } >=20 > if (!FvFound) { > -- > 2.7.0.windows.1