public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "Zeng, Star" <star.zeng@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Zhang, Chao B" <chao.b.zhang@intel.com>,
	"Zeng, Star" <star.zeng@intel.com>
Subject: Re: [PATCH] SecurityPkg FmpAuthenticationLibRsa2048Sha256: Remove PCD reference
Date: Mon, 16 Apr 2018 08:42:38 +0000	[thread overview]
Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503AB64BB0@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1523868068-143104-1-git-send-email-star.zeng@intel.com>

Good clean up.

Reviewed-by: Jiewen.yao@intel.com


> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Star
> Zeng
> Sent: Monday, April 16, 2018 4:41 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Zhang, Chao B
> <chao.b.zhang@intel.com>; Zeng, Star <star.zeng@intel.com>
> Subject: [edk2] [PATCH] SecurityPkg FmpAuthenticationLibRsa2048Sha256:
> Remove PCD reference
> 
> PcdRsa2048Sha256PublicKeyBuffer is referenced but not used in the
> library, that makes me a little confusing.
> Actually, the PublicKeyData should be from the caller of
> AuthenticateFmpImage() as input parameter, for example
> EdkiiSystemCapsuleLib.
> 
> This patch is to remove the PCD reference in this library instance
> to be aligned with FmpAuthenticationLibPkcs7 that does not reference
> PcdPkcs7CertBuffer.
> 
> Cc: Chao Zhang <chao.b.zhang@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Star Zeng <star.zeng@intel.com>
> ---
>  .../FmpAuthenticationLibRsa2048Sha256.c                              |
> 4 ++--
>  .../FmpAuthenticationLibRsa2048Sha256.inf                            |
> 5 +----
>  2 files changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git
> a/SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthenticatio
> nLibRsa2048Sha256.c
> b/SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthenticatio
> nLibRsa2048Sha256.c
> index b40993fd1b00..038e12447782 100644
> ---
> a/SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthenticatio
> nLibRsa2048Sha256.c
> +++
> b/SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthenticatio
> nLibRsa2048Sha256.c
> @@ -10,7 +10,7 @@
>    FmpAuthenticatedHandlerRsa2048Sha256(), AuthenticateFmpImage() will
> receive
>    untrusted input and do basic validation.
> 
> -  Copyright (c) 2016 - 2017, Intel Corporation. All rights reserved.<BR>
> +  Copyright (c) 2016 - 2018, Intel Corporation. All rights reserved.<BR>
>    This program and the accompanying materials
>    are licensed and made available under the terms and conditions of the BSD
> License
>    which accompanies this distribution.  The full text of the license may be
> found at
> @@ -133,7 +133,7 @@ FmpAuthenticatedHandlerRsa2048Sha256 (
>    }
> 
>    //
> -  // Fail if the PublicKey is not one of the public keys in
> PcdRsa2048Sha256PublicKeyBuffer
> +  // Fail if the PublicKey is not one of the public keys in the input PublicKeyData.
>    //
>    PublicKey = (VOID *)PublicKeyData;
>    PublicKeyBufferSize = PublicKeyDataLength;
> diff --git
> a/SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthenticatio
> nLibRsa2048Sha256.inf
> b/SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthenticatio
> nLibRsa2048Sha256.inf
> index b190eca8805c..cdd22429c274 100644
> ---
> a/SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthenticatio
> nLibRsa2048Sha256.inf
> +++
> b/SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthenticatio
> nLibRsa2048Sha256.inf
> @@ -3,7 +3,7 @@
>  #
>  # Instance of FmpAuthentication Library for DXE/PEI post memory phase.
>  #
> -#  Copyright (c) 2016 - 2017, Intel Corporation. All rights reserved.<BR>
> +#  Copyright (c) 2016 - 2018, Intel Corporation. All rights reserved.<BR>
>  #  This program and the accompanying materials
>  #  are licensed and made available under the terms and conditions of the BSD
> License
>  #  which accompanies this distribution.  The full text of the license may be
> found at
> @@ -45,9 +45,6 @@ [LibraryClasses]
>    MemoryAllocationLib
>    BaseCryptLib
> 
> -[Pcd]
> -  gEfiSecurityPkgTokenSpaceGuid.PcdRsa2048Sha256PublicKeyBuffer     ##
> CONSUMES
> -
>  [Guids]
>    gEfiCertTypeRsa2048Sha256Guid         ## SOMETIMES_CONSUMES
> ## GUID # Unique ID for the type of the certificate.
>    gEfiHashAlgorithmSha256Guid           ## SOMETIMES_CONSUMES
> ## GUID
> --
> 2.7.0.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


      reply	other threads:[~2018-04-16  8:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-16  8:41 [PATCH] SecurityPkg FmpAuthenticationLibRsa2048Sha256: Remove PCD reference Star Zeng
2018-04-16  8:42 ` Yao, Jiewen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=74D8A39837DF1E4DA445A8C0B3885C503AB64BB0@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox