From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: Sean Brogan <sean.brogan@microsoft.com>,
"Zeng, Star" <star.zeng@intel.com>,
"Dong, Eric" <eric.dong@intel.com>,
"Wei, David" <david.wei@intel.com>,
"Guo, Mang" <mang.guo@intel.com>,
"Steele, Kelly" <kelly.steele@intel.com>
Subject: Re: [Patch V2 0/9] Add DisplayUpdateProgressLib for capsules
Date: Fri, 20 Apr 2018 04:23:20 +0000 [thread overview]
Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503AB75A6A@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20180412004830.9904-1-michael.d.kinney@intel.com>
Thanks Mike.
I still think we should add a Version flag for EDKII_FIRMWARE_MANAGEMENT_PROGRESS_PROTOCOL for future extension, as we discussed in V1.
Other update seems good to me. Reviewed-by: Jiewen.yao@Intel.com
Thank you
Yao Jiewen
> -----Original Message-----
> From: Kinney, Michael D
> Sent: Thursday, April 12, 2018 8:48 AM
> To: edk2-devel@lists.01.org
> Cc: Sean Brogan <sean.brogan@microsoft.com>; Zeng, Star
> <star.zeng@intel.com>; Dong, Eric <eric.dong@intel.com>; Yao, Jiewen
> <jiewen.yao@intel.com>; Wei, David <david.wei@intel.com>; Guo, Mang
> <mang.guo@intel.com>; Steele, Kelly <kelly.steele@intel.com>; Kinney, Michael
> D <michael.d.kinney@intel.com>
> Subject: [Patch V2 0/9] Add DisplayUpdateProgressLib for capsules
>
> https://bugzilla.tianocore.org/show_bug.cgi?id=801
>
> Based on content from:
>
> https://github.com/Microsoft/MS_UEFI/blob/share/MsCapsuleSupport/MsCaps
> uleUpdatePkg/Include/Library/DisplayUpdateProgressLib.h
> https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport/MsCapsu
> leUpdatePkg/Library/DisplayUpdateProgressGraphicsLib
> https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport/MsCapsu
> leUpdatePkg/Library/DisplayUpdateProgressTextLib
>
> Updates for V2
> ==============
> * Change DisplayUpdateProgressGraphicsLib to
> DisplayUpdateProgressLibGraphics
> * Change DisplayUpdateProgressTextLib to DisplayUpdateProgressLibText
> * Clarify that color in Firmware Management Progress Protocol is the
> foreground color
> * Add missing parameters to PerformFlashWriteWithProgress() function header.
> * Update PerformFlashWriteWithProgress() function header describing the use
> of
> the start and end percentage values.
> * Update QuarkPlatformPkg PerformFlashWriteWithProgress() to call Progress()
> for
> the end precentage.
> * Update Vlv2Tbl2DevicePkg PerformFlashWriteWithProgress() to call Progress()
> for the end precentage.
>
> Add DisplayUpdateProgressLib class along implementations for both graphical
> (Graphics Output Protocol based) and text (Simple Text Output Protocol based)
> consoles. Also add the EDK II Firmware Management Progress Protocol that is
> an
> optional protocol that provides the progress bar color and a watchdog timeout
> value thaty can be used when a firmware image is updated in a firmware device.
>
> * Add progress support to DxeCapsuleLibFmp
> * Add progress support to SystemFirmwareUpdateDxe
> * Add progress support to PlatformFlashAccessLib class and instances.
> * Reduce Print() calls during a firmware update.
>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: David Wei <david.wei@intel.com>
> Cc: Mang Guo <mang.guo@intel.com>
> Cc: Kelly Steele <kelly.steele@intel.com>
>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
>
> Kinney, Michael D (3):
> QuarkPlatformPkg: Add DisplayUpdateProgressLib mapping
> MdeModulePkg/DxeCapsuleLibFmp: Add progress bar support
> SignedCapsulePkg/SystemFirmwareUpdateDxe: Use progress API
>
> Michael D Kinney (6):
> MdeModulePkg: Add DisplayUpdateProgressLib class
> MdeModulePkg: Add DisplayUpdateProgressLib instances
> Vlv2Tbl2DevicePkg: Add DisplayUpdateProgressLib mapping
> SignedCapsulePkg/PlatformFlashAccessLib: Add progress API
> Vlv2TbltDevicePkg/PlatformFlashAccessLib: Add progress API
> QuarkPlatformPkg/PlatformFlashAccessLib: Add progress API
>
> .../Include/Library/DisplayUpdateProgressLib.h | 65 +++
> .../Include/Protocol/FirmwareManagementProgress.h | 51 +++
> .../DisplayUpdateProgressLibGraphics.c | 475
> +++++++++++++++++++++
> .../DisplayUpdateProgressLibGraphics.inf | 60 +++
> .../DisplayUpdateProgressLibGraphics.uni | 18 +
> .../DisplayUpdateProgressLibText.c | 174 ++++++++
> .../DisplayUpdateProgressLibText.inf | 53 +++
> .../DisplayUpdateProgressLibText.uni | 18 +
> .../Library/DxeCapsuleLibFmp/DxeCapsuleLib.c | 47 +-
> .../Library/DxeCapsuleLibFmp/DxeCapsuleLib.inf | 8 +-
> .../DxeCapsuleLibFmp/DxeCapsuleProcessLib.c | 84 +++-
> .../DxeCapsuleLibFmp/DxeCapsuleProcessLibNull.c | 21 +-
> .../DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf | 7 +-
> MdeModulePkg/MdeModulePkg.dec | 11 +
> MdeModulePkg/MdeModulePkg.dsc | 3 +
> .../PlatformFlashAccessLibDxe.c | 78 +++-
> QuarkPlatformPkg/Quark.dsc | 1 +
> .../Include/Library/PlatformFlashAccessLib.h | 49 ++-
> .../PlatformFlashAccessLibNull.c | 70 ++-
> .../SystemFirmwareUpdate/SystemFirmwareUpdateDxe.c | 90 +++-
> .../PlatformFlashAccessLib.c | 102 +++--
> .../PlatformFlashAccessLib.inf | 3 +-
> Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 1 +
> Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 1 +
> Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 1 +
> 25 files changed, 1387 insertions(+), 104 deletions(-)
> create mode 100644
> MdeModulePkg/Include/Library/DisplayUpdateProgressLib.h
> create mode 100644
> MdeModulePkg/Include/Protocol/FirmwareManagementProgress.h
> create mode 100644
> MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/DisplayUpdateProg
> ressLibGraphics.c
> create mode 100644
> MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/DisplayUpdateProg
> ressLibGraphics.inf
> create mode 100644
> MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/DisplayUpdateProg
> ressLibGraphics.uni
> create mode 100644
> MdeModulePkg/Library/DisplayUpdateProgressLibText/DisplayUpdateProgressLi
> bText.c
> create mode 100644
> MdeModulePkg/Library/DisplayUpdateProgressLibText/DisplayUpdateProgressLi
> bText.inf
> create mode 100644
> MdeModulePkg/Library/DisplayUpdateProgressLibText/DisplayUpdateProgressLi
> bText.uni
>
> --
> 2.14.2.windows.3
next prev parent reply other threads:[~2018-04-20 4:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-12 0:48 [Patch V2 0/9] Add DisplayUpdateProgressLib for capsules Kinney, Michael D
2018-04-12 0:48 ` [Patch V2 1/9] MdeModulePkg: Add DisplayUpdateProgressLib class Kinney, Michael D
2018-04-12 2:30 ` Zeng, Star
2018-04-12 0:48 ` [Patch V2 2/9] MdeModulePkg: Add DisplayUpdateProgressLib instances Kinney, Michael D
2018-04-12 0:48 ` [Patch V2 3/9] Vlv2Tbl2DevicePkg: Add DisplayUpdateProgressLib mapping Kinney, Michael D
2018-04-12 1:47 ` Wei, David
2018-04-12 0:48 ` [Patch V2 4/9] QuarkPlatformPkg: " Kinney, Michael D
2018-04-12 0:48 ` [Patch V2 5/9] MdeModulePkg/DxeCapsuleLibFmp: Add progress bar support Kinney, Michael D
2018-04-12 0:48 ` [Patch V2 6/9] SignedCapsulePkg/PlatformFlashAccessLib: Add progress API Kinney, Michael D
2018-04-12 0:48 ` [Patch V2 7/9] Vlv2TbltDevicePkg/PlatformFlashAccessLib: " Kinney, Michael D
2018-04-12 1:52 ` Wei, David
2018-04-12 0:48 ` [Patch V2 8/9] QuarkPlatformPkg/PlatformFlashAccessLib: " Kinney, Michael D
2018-04-12 0:48 ` [Patch V2 9/9] SignedCapsulePkg/SystemFirmwareUpdateDxe: Use " Kinney, Michael D
2018-04-12 1:06 ` [Patch V2 0/9] Add DisplayUpdateProgressLib for capsules Kinney, Michael D
2018-04-20 4:23 ` Yao, Jiewen [this message]
2018-04-20 4:50 ` Zeng, Star
2018-04-20 23:11 ` Kinney, Michael D
2018-04-23 2:09 ` Zeng, Star
2018-04-20 23:01 ` Kinney, Michael D
2018-04-20 5:07 ` Sean Brogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74D8A39837DF1E4DA445A8C0B3885C503AB75A6A@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox