From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.65; helo=mga03.intel.com; envelope-from=jiewen.yao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 37B1A21EBD1AD for ; Thu, 19 Apr 2018 21:23:24 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Apr 2018 21:23:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,299,1520924400"; d="scan'208";a="33956537" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga008.fm.intel.com with ESMTP; 19 Apr 2018 21:23:23 -0700 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 19 Apr 2018 21:23:23 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 19 Apr 2018 21:23:23 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.79]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.240]) with mapi id 14.03.0319.002; Fri, 20 Apr 2018 12:23:21 +0800 From: "Yao, Jiewen" To: "Kinney, Michael D" , "edk2-devel@lists.01.org" CC: Sean Brogan , "Zeng, Star" , "Dong, Eric" , "Wei, David" , "Guo, Mang" , "Steele, Kelly" Thread-Topic: [Patch V2 0/9] Add DisplayUpdateProgressLib for capsules Thread-Index: AQHT0fgAwTse8SIRtUm+UQX3GLjdkqQJGj+Q Date: Fri, 20 Apr 2018 04:23:20 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503AB75A6A@shsmsx102.ccr.corp.intel.com> References: <20180412004830.9904-1-michael.d.kinney@intel.com> In-Reply-To: <20180412004830.9904-1-michael.d.kinney@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDhlOWNmNTktZDc4Mi00N2U3LWJiM2UtZjEwMDBmOWFmNDcyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJ5N1wvVGEwUjhSM3g4WDBKc2Y0VldIT1czXC9LbjQ0QjZyeTF2SUtjZDVaenV4dWJCM2lMNEV6djBBVVRZVDZDc0wifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch V2 0/9] Add DisplayUpdateProgressLib for capsules X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Apr 2018 04:23:24 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks Mike. I still think we should add a Version flag for EDKII_FIRMWARE_MANAGEMENT_PR= OGRESS_PROTOCOL for future extension, as we discussed in V1. Other update seems good to me. Reviewed-by: Jiewen.yao@Intel.com Thank you Yao Jiewen > -----Original Message----- > From: Kinney, Michael D > Sent: Thursday, April 12, 2018 8:48 AM > To: edk2-devel@lists.01.org > Cc: Sean Brogan ; Zeng, Star > ; Dong, Eric ; Yao, Jiewen > ; Wei, David ; Guo, Mang > ; Steele, Kelly ; Kinney, Mic= hael > D > Subject: [Patch V2 0/9] Add DisplayUpdateProgressLib for capsules >=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D801 >=20 > Based on content from: >=20 > https://github.com/Microsoft/MS_UEFI/blob/share/MsCapsuleSupport/MsCaps > uleUpdatePkg/Include/Library/DisplayUpdateProgressLib.h > https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport/MsCapsu > leUpdatePkg/Library/DisplayUpdateProgressGraphicsLib > https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport/MsCapsu > leUpdatePkg/Library/DisplayUpdateProgressTextLib >=20 > Updates for V2 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > * Change DisplayUpdateProgressGraphicsLib to > DisplayUpdateProgressLibGraphics > * Change DisplayUpdateProgressTextLib to DisplayUpdateProgressLibText > * Clarify that color in Firmware Management Progress Protocol is the > foreground color > * Add missing parameters to PerformFlashWriteWithProgress() function head= er. > * Update PerformFlashWriteWithProgress() function header describing the u= se > of > the start and end percentage values. > * Update QuarkPlatformPkg PerformFlashWriteWithProgress() to call Progres= s() > for > the end precentage. > * Update Vlv2Tbl2DevicePkg PerformFlashWriteWithProgress() to call Progre= ss() > for the end precentage. >=20 > Add DisplayUpdateProgressLib class along implementations for both graphic= al > (Graphics Output Protocol based) and text (Simple Text Output Protocol ba= sed) > consoles. Also add the EDK II Firmware Management Progress Protocol that= is > an > optional protocol that provides the progress bar color and a watchdog tim= eout > value thaty can be used when a firmware image is updated in a firmware de= vice. >=20 > * Add progress support to DxeCapsuleLibFmp > * Add progress support to SystemFirmwareUpdateDxe > * Add progress support to PlatformFlashAccessLib class and instances. > * Reduce Print() calls during a firmware update. >=20 > Cc: Sean Brogan > Cc: Star Zeng > Cc: Eric Dong > Cc: Jiewen Yao > Cc: David Wei > Cc: Mang Guo > Cc: Kelly Steele >=20 > Signed-off-by: Michael D Kinney > Contributed-under: TianoCore Contribution Agreement 1.1 >=20 > Kinney, Michael D (3): > QuarkPlatformPkg: Add DisplayUpdateProgressLib mapping > MdeModulePkg/DxeCapsuleLibFmp: Add progress bar support > SignedCapsulePkg/SystemFirmwareUpdateDxe: Use progress API >=20 > Michael D Kinney (6): > MdeModulePkg: Add DisplayUpdateProgressLib class > MdeModulePkg: Add DisplayUpdateProgressLib instances > Vlv2Tbl2DevicePkg: Add DisplayUpdateProgressLib mapping > SignedCapsulePkg/PlatformFlashAccessLib: Add progress API > Vlv2TbltDevicePkg/PlatformFlashAccessLib: Add progress API > QuarkPlatformPkg/PlatformFlashAccessLib: Add progress API >=20 > .../Include/Library/DisplayUpdateProgressLib.h | 65 +++ > .../Include/Protocol/FirmwareManagementProgress.h | 51 +++ > .../DisplayUpdateProgressLibGraphics.c | 475 > +++++++++++++++++++++ > .../DisplayUpdateProgressLibGraphics.inf | 60 +++ > .../DisplayUpdateProgressLibGraphics.uni | 18 + > .../DisplayUpdateProgressLibText.c | 174 ++++++++ > .../DisplayUpdateProgressLibText.inf | 53 +++ > .../DisplayUpdateProgressLibText.uni | 18 + > .../Library/DxeCapsuleLibFmp/DxeCapsuleLib.c | 47 +- > .../Library/DxeCapsuleLibFmp/DxeCapsuleLib.inf | 8 +- > .../DxeCapsuleLibFmp/DxeCapsuleProcessLib.c | 84 +++- > .../DxeCapsuleLibFmp/DxeCapsuleProcessLibNull.c | 21 +- > .../DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf | 7 +- > MdeModulePkg/MdeModulePkg.dec | 11 + > MdeModulePkg/MdeModulePkg.dsc | 3 + > .../PlatformFlashAccessLibDxe.c | 78 +++- > QuarkPlatformPkg/Quark.dsc | 1 + > .../Include/Library/PlatformFlashAccessLib.h | 49 ++- > .../PlatformFlashAccessLibNull.c | 70 ++- > .../SystemFirmwareUpdate/SystemFirmwareUpdateDxe.c | 90 +++- > .../PlatformFlashAccessLib.c | 102 +++-- > .../PlatformFlashAccessLib.inf | 3 +- > Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 1 + > Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 1 + > Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 1 + > 25 files changed, 1387 insertions(+), 104 deletions(-) > create mode 100644 > MdeModulePkg/Include/Library/DisplayUpdateProgressLib.h > create mode 100644 > MdeModulePkg/Include/Protocol/FirmwareManagementProgress.h > create mode 100644 > MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/DisplayUpdateProg > ressLibGraphics.c > create mode 100644 > MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/DisplayUpdateProg > ressLibGraphics.inf > create mode 100644 > MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/DisplayUpdateProg > ressLibGraphics.uni > create mode 100644 > MdeModulePkg/Library/DisplayUpdateProgressLibText/DisplayUpdateProgressLi > bText.c > create mode 100644 > MdeModulePkg/Library/DisplayUpdateProgressLibText/DisplayUpdateProgressLi > bText.inf > create mode 100644 > MdeModulePkg/Library/DisplayUpdateProgressLibText/DisplayUpdateProgressLi > bText.uni >=20 > -- > 2.14.2.windows.3