From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.65; helo=mga03.intel.com; envelope-from=jiewen.yao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B6A2920971753 for ; Mon, 28 May 2018 12:07:48 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 May 2018 12:07:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,453,1520924400"; d="scan'208";a="54628347" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga003.jf.intel.com with ESMTP; 28 May 2018 12:07:48 -0700 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 28 May 2018 12:07:47 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 28 May 2018 12:07:31 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.223]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.116]) with mapi id 14.03.0319.002; Tue, 29 May 2018 03:07:25 +0800 From: "Yao, Jiewen" To: "Kinney, Michael D" , "edk2-devel@lists.01.org" CC: Sean Brogan , "Zeng, Star" , "Dong, Eric" , "Wei, David" , "Guo, Mang" , "Steele, Kelly" Thread-Topic: [Patch v3 0/3] Add DisplayUpdateProgressLib for capsules Thread-Index: AQHT8+/aTsLdsRSSU0SMTj6qLNuJwKRFhbAw Date: Mon, 28 May 2018 19:07:25 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503AC1174A@shsmsx102.ccr.corp.intel.com> References: <20180525061552.19840-1-michael.d.kinney@intel.com> In-Reply-To: <20180525061552.19840-1-michael.d.kinney@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMWZjYjM1MDYtZGQ4Yy00NTA4LWI2MjMtYjhmZDRhYTc3NzVhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYVg1UFZMaDNvSEpldzlVU0QweFZzWWhCanpZNmhleFwvMDc1S3kzcUJNdURHMUhieFB6RGlvbHoyQkh3M3ZFTzQifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch v3 0/3] Add DisplayUpdateProgressLib for capsules X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 May 2018 19:07:48 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thank you to add Version. Patch 1,2,3,4 reviewed-by: Jiewen.yao@intel.com Thank you Yao Jiewen > -----Original Message----- > From: Kinney, Michael D > Sent: Thursday, May 24, 2018 11:16 PM > To: edk2-devel@lists.01.org > Cc: Sean Brogan ; Zeng, Star > ; Dong, Eric ; Yao, Jiewen > ; Wei, David ; Guo, Mang > ; Steele, Kelly > Subject: [Patch v3 0/3] Add DisplayUpdateProgressLib for capsules >=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D801 >=20 > Based on content from: >=20 > https://github.com/Microsoft/MS_UEFI/blob/share/MsCapsuleSupport/MsCaps > uleUpdatePkg/Include/Library/DisplayUpdateProgressLib.h > https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport/MsCapsu > leUpdatePkg/Library/DisplayUpdateProgressGraphicsLib > https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport/MsCapsu > leUpdatePkg/Library/DisplayUpdateProgressTextLib >=20 > Updates for V3 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > * Add Version field to EDKII_FIRMWARE_MANAGEMENT_PROGRESS_PROTOCOL > * Break up patch series into 4 smaller patch series to handle dependencie= s > between the edk2 repository and the edk2-platforms repository. > + Patch series for edk2 repo that adds DisplayUpdateProgressLib class a= nd > instances. Defines the > EDKII_FIRMWARE_MANAGEMENT_PROGRESS_PROTOCOL. > Adds PerformFlashWriteWithProgress() API to the PlatformFlashAccessLi= b. > + Patch series for platforms in edk2-platforms that use capsules to add= the > DisplayUpdateProgressLib mapping to the DSC files and add the > PerformFlashWriteWithProgress() API implementation to the > PlatformFlashAccessLib implementations. > + Patch series for platforms in edk2 that use capsules to add the > DisplayUpdateProgressLib mapping to the DSC files and add the > PerformFlashWriteWithProgress() API implementation to the > PlatformFlashAccessLib implementations. > + Patch for edk2 that adds the use of the DisplayUpateProgressLib and t= he > PerformFlashWriteWithProgress() API . >=20 > Updates for V2 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > * Change DisplayUpdateProgressGraphicsLib to > DisplayUpdateProgressLibGraphics > * Change DisplayUpdateProgressTextLib to DisplayUpdateProgressLibText > * Clarify that color in Firmware Management Progress Protocol is the > foreground color > * Add missing parameters to PerformFlashWriteWithProgress() function head= er. > * Update PerformFlashWriteWithProgress() function header describing the u= se > of > the start and end percentage values. > * Update QuarkPlatformPkg PerformFlashWriteWithProgress() to call Progres= s() > for > the end precentage. > * Update Vlv2Tbl2DevicePkg PerformFlashWriteWithProgress() to call Progre= ss() > for the end precentage. >=20 > Add DisplayUpdateProgressLib class along implementations for both graphic= al > (Graphics Output Protocol based) and text (Simple Text Output Protocol ba= sed) > consoles. Also add the EDK II Firmware Management Progress Protocol that= is > an > optional protocol that provides the progress bar color and a watchdog tim= eout > value thaty can be used when a firmware image is updated in a firmware de= vice. >=20 > * Add progress support to DxeCapsuleLibFmp > * Add progress support to SystemFirmwareUpdateDxe > * Add progress support to PlatformFlashAccessLib class and instances. > * Reduce Print() calls during a firmware update. >=20 > Cc: Sean Brogan > Cc: Star Zeng > Cc: Eric Dong > Cc: Jiewen Yao > Cc: David Wei > Cc: Mang Guo > Cc: Kelly Steele >=20 > Signed-off-by: Michael D Kinney > Contributed-under: TianoCore Contribution Agreement 1.1 >=20 > Michael D Kinney (3): > MdeModulePkg: Add DisplayUpdateProgressLib class > MdeModulePkg: Add DisplayUpdateProgressLib instances > SignedCapsulePkg/PlatformFlashAccessLib: Add progress API >=20 > .../Include/Library/DisplayUpdateProgressLib.h | 65 +++ > .../Include/Protocol/FirmwareManagementProgress.h | 55 +++ > .../DisplayUpdateProgressLibGraphics.c | 475 > +++++++++++++++++++++ > .../DisplayUpdateProgressLibGraphics.inf | 60 +++ > .../DisplayUpdateProgressLibGraphics.uni | 18 + > .../DisplayUpdateProgressLibText.c | 174 ++++++++ > .../DisplayUpdateProgressLibText.inf | 53 +++ > .../DisplayUpdateProgressLibText.uni | 18 + > MdeModulePkg/MdeModulePkg.dec | 11 + > MdeModulePkg/MdeModulePkg.dsc | 3 + > .../Include/Library/PlatformFlashAccessLib.h | 49 ++- > .../PlatformFlashAccessLibNull.c | 70 ++- > 12 files changed, 1042 insertions(+), 9 deletions(-) > create mode 100644 > MdeModulePkg/Include/Library/DisplayUpdateProgressLib.h > create mode 100644 > MdeModulePkg/Include/Protocol/FirmwareManagementProgress.h > create mode 100644 > MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/DisplayUpdateProg > ressLibGraphics.c > create mode 100644 > MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/DisplayUpdateProg > ressLibGraphics.inf > create mode 100644 > MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/DisplayUpdateProg > ressLibGraphics.uni > create mode 100644 > MdeModulePkg/Library/DisplayUpdateProgressLibText/DisplayUpdateProgressLi > bText.c > create mode 100644 > MdeModulePkg/Library/DisplayUpdateProgressLibText/DisplayUpdateProgressLi > bText.inf > create mode 100644 > MdeModulePkg/Library/DisplayUpdateProgressLibText/DisplayUpdateProgressLi > bText.uni >=20 > -- > 2.14.2.windows.3