From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.31; helo=mga06.intel.com; envelope-from=jiewen.yao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5E361212E470C for ; Sat, 9 Jun 2018 22:38:06 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jun 2018 22:38:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,497,1520924400"; d="scan'208";a="235883512" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga005.fm.intel.com with ESMTP; 09 Jun 2018 22:38:05 -0700 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sat, 9 Jun 2018 22:38:05 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sat, 9 Jun 2018 22:38:04 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.223]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.116]) with mapi id 14.03.0319.002; Sun, 10 Jun 2018 13:38:02 +0800 From: "Yao, Jiewen" To: 'Ard Biesheuvel' CC: "edk2-devel@lists.01.org" , "Kinney, Michael D" , "Zeng, Star" , "leif.lindholm@linaro.org" Thread-Topic: [edk2] [PATCH v2 2/5] MdeModulePkg/DxeCapsuleLibFmp: permit ProcessCapsules () to be called once Thread-Index: AQHT/vYbbSADsfB+hEWX7Kwk2kNBmKRWSrdA//98PACAAIb9kA== Date: Sun, 10 Jun 2018 05:38:02 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503AC3A387@shsmsx102.ccr.corp.intel.com> References: <20180608065811.2065-1-ard.biesheuvel@linaro.org> <20180608065811.2065-3-ard.biesheuvel@linaro.org> <74D8A39837DF1E4DA445A8C0B3885C503AC3515B@shsmsx102.ccr.corp.intel.com> <6534F306-C3E7-40D2-84F4-D409BF1F7B68@linaro.org> In-Reply-To: <6534F306-C3E7-40D2-84F4-D409BF1F7B68@linaro.org> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTIwZmQyOWEtOTVkYi00ZjU0LWIzNDUtM2Q2NWQwYTJkMWIxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYVVieFZQY3hOd2NcL1VKbkV4ZHRjeTNBYUxEbktkcHA4clVUdk5FTHo3ZTM4Vm9xckxKc2NGMWk0NmVodTd5YjEifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v2 2/5] MdeModulePkg/DxeCapsuleLibFmp: permit ProcessCapsules () to be called once X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 Jun 2018 05:38:06 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Ard According to PI spec, "Prior to invoking any UEFI drivers, or applications = that are not from the platform manufacturer, or connecting consoles, the pl= atform should signals the event EFI_END_OF_DXE_EVENT_GUID" In brief, EndOfDxe is signaled before 3rd part code running. As such, it is legal that a trusted console is connected before EndOfDxe. You can report progress to user before EndOfDxe. Thank you Yao Jiewen > -----Original Message----- > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > Sent: Friday, June 8, 2018 8:38 AM > To: Yao, Jiewen > Cc: edk2-devel@lists.01.org; Kinney, Michael D ; > Zeng, Star ; leif.lindholm@linaro.org > Subject: Re: [edk2] [PATCH v2 2/5] MdeModulePkg/DxeCapsuleLibFmp: permit > ProcessCapsules () to be called once >=20 >=20 >=20 > > On 8 Jun 2018, at 14:34, Yao, Jiewen wrote: > > > > Hi Ard > > We don't allow platform to update system firmware *after* EndOfDxe. > > > > According to PI spec, after EndOfDxe, 3rd part code start running. It b= rings > security risk if we allow system firmware after EndOfDxe. > > > > In our X86 system design, we lock flash part *before* EndOfDxe in any b= oot > mode. > > Even in CapsuleUpdate boot mode, we also lock flash part at EndOfDxe, j= ust in > case the capsule update does not indicate a reset. > > > > Would you please share the info, why your platform need update system > firmware after EndOfDxe? > > Is that possible to make it earlier? > > > > >=20 > Because we need some kind of console to report progress to the user. >=20 > The secure platform execution context is completely separate from UEFI on= Arm, > so for us the distinction does not make sense. >=20 > > Thank you > > Yao Jiewen > > > >> -----Original Message----- > >> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Ard > >> Biesheuvel > >> Sent: Friday, June 8, 2018 2:58 AM > >> To: edk2-devel@lists.01.org > >> Cc: Kinney, Michael D ; Yao, Jiewen > >> ; Zeng, Star ; > >> leif.lindholm@linaro.org; Ard Biesheuvel > >> Subject: [edk2] [PATCH v2 2/5] MdeModulePkg/DxeCapsuleLibFmp: permit > >> ProcessCapsules () to be called once > >> > >> Permit ProcessCapsules () to be called only a single time, after > >> EndOfDxe. This allows platforms that are able to update system > >> firmware after EndOfDxe (e.g., because the flash ROM is not locked > >> down) to do so at a time when a non-trusted console is up and running, > >> and progress can be reported to the user. > >> > >> Contributed-under: TianoCore Contribution Agreement 1.1 > >> Signed-off-by: Ard Biesheuvel > >> --- > >> MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleProcessLib.c | 18 > >> ++++++++++++------ > >> 1 file changed, 12 insertions(+), 6 deletions(-) > >> > >> diff --git > a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleProcessLib.c > >> b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleProcessLib.c > >> index 26ca4e295f20..ad83660f1737 100644 > >> --- a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleProcessLib.c > >> +++ b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleProcessLib.c > >> @@ -100,6 +100,7 @@ IsValidCapsuleHeader ( > >> > >> extern BOOLEAN mDxeCapsuleLibEndOfDxe; > >> BOOLEAN mNeedReset; > >> +BOOLEAN mFirstRound =3D TRUE; > >> > >> VOID **mCapsulePtr; > >> EFI_STATUS *mCapsuleStatusArray; > >> @@ -364,8 +365,11 @@ PopulateCapsuleInConfigurationTable ( > >> > >> Each individual capsule result is recorded in capsule record variabl= e. > >> > >> - @param[in] FirstRound TRUE: First round. Need skip the > FMP > >> capsules with non zero EmbeddedDriverCount. > >> - FALSE: Process rest FMP capsules. > >> + @param[in] FirstRound Whether this is the first invocation > >> + @param[in] LastRound Whether this is the last invocation > >> + FALSE: First of 2 rounds. Need skip > the > >> FMP > >> + capsules with non zero > >> EmbeddedDriverCount. > >> + TRUE: Process rest FMP capsules. > >> > >> @retval EFI_SUCCESS There is no error when processing > >> capsules. > >> @retval EFI_OUT_OF_RESOURCES No enough resource to process > >> capsules. > >> @@ -373,7 +377,8 @@ PopulateCapsuleInConfigurationTable ( > >> **/ > >> EFI_STATUS > >> ProcessTheseCapsules ( > >> - IN BOOLEAN FirstRound > >> + IN BOOLEAN FirstRound, > >> + IN BOOLEAN LastRound > >> ) > >> { > >> EFI_STATUS Status; > >> @@ -453,7 +458,7 @@ ProcessTheseCapsules ( > >> continue; > >> } > >> > >> - if ((!FirstRound) || (EmbeddedDriverCount =3D=3D 0)) { > >> + if (LastRound || (EmbeddedDriverCount =3D=3D 0)) { > >> DEBUG((DEBUG_INFO, "ProcessCapsuleImage - 0x%x\n", > >> CapsuleHeader)); > >> Status =3D ProcessCapsuleImage (CapsuleHeader); > >> mCapsuleStatusArray [Index] =3D Status; > >> @@ -546,7 +551,7 @@ ProcessCapsules ( > >> EFI_STATUS Status; > >> > >> if (!mDxeCapsuleLibEndOfDxe) { > >> - Status =3D ProcessTheseCapsules(TRUE); > >> + Status =3D ProcessTheseCapsules(TRUE, FALSE); > >> > >> // > >> // Reboot System if and only if all capsule processed. > >> @@ -555,8 +560,9 @@ ProcessCapsules ( > >> if (mNeedReset && AreAllImagesProcessed()) { > >> DoResetSystem(); > >> } > >> + mFirstRound =3D FALSE; > >> } else { > >> - Status =3D ProcessTheseCapsules(FALSE); > >> + Status =3D ProcessTheseCapsules(mFirstRound, TRUE); > >> // > >> // Reboot System if required after all capsule processed > >> // > >> -- > >> 2.17.0 > >> > >> _______________________________________________ > >> edk2-devel mailing list > >> edk2-devel@lists.01.org > >> https://lists.01.org/mailman/listinfo/edk2-devel