From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.65; helo=mga03.intel.com; envelope-from=jiewen.yao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BA6CA20348600 for ; Fri, 6 Jul 2018 07:56:55 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Jul 2018 07:56:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,316,1526367600"; d="scan'208";a="70178040" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga001.fm.intel.com with ESMTP; 06 Jul 2018 07:56:49 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 6 Jul 2018 07:56:49 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.124]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.57]) with mapi id 14.03.0319.002; Fri, 6 Jul 2018 22:56:47 +0800 From: "Yao, Jiewen" To: "Gao, Liming" , "edk2-devel@lists.01.org" Thread-Topic: [PATCH edk2-platforms\devel-MinPlatform] PurleyOpenBoardPkg: Remove unnecessary Link16 and IASL override Thread-Index: AQHUFP2Bl6trxh+ZCESkmYYmhlyZPKSCSR9A Date: Fri, 6 Jul 2018 14:56:46 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503AC8E4BB@shsmsx102.ccr.corp.intel.com> References: <1530863149-9232-1-git-send-email-liming.gao@intel.com> <1530863149-9232-4-git-send-email-liming.gao@intel.com> In-Reply-To: <1530863149-9232-4-git-send-email-liming.gao@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMWYzNjFlZDEtY2E5MS00YjFhLWFmODUtNDIxOTRiMmU0ZGQwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiaFJlR1Rhdm1uSE1UcXVqQ3Q2a2gwbDByMjdIaVhoZlBTbm56aE9aSERLK2dQbzNUZWtPQWhJaHFrS09pXC81Wm4ifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH edk2-platforms\devel-MinPlatform] PurleyOpenBoardPkg: Remove unnecessary Link16 and IASL override X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Jul 2018 14:56:55 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jiewen.yao@intel.com > -----Original Message----- > From: Gao, Liming > Sent: Thursday, July 5, 2018 11:46 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen > Subject: [PATCH edk2-platforms\devel-MinPlatform] PurleyOpenBoardPkg: > Remove unnecessary Link16 and IASL override >=20 > Link16 is not used any longer. Remove the checker for it. > IASL path is not required to be override. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Liming Gao > Cc: Jiewen Yao > --- > .../BoardMtOlympus/PlatformPkgBuildOption.dsc | 2 +- > .../Intel/PurleyOpenBoardPkg/BoardMtOlympus/prebuild.bat | 12 > +----------- > 2 files changed, 2 insertions(+), 12 deletions(-) >=20 > diff --git > a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkgBuildOpti > on.dsc > b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkgBuildOpti > on.dsc > index 151cbdc..3b55e78 100644 > --- > a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkgBuildOpti > on.dsc > +++ > b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkgBuildOpti > on.dsc > @@ -76,7 +76,7 @@ > # > # Override the existing iasl path in tools_def.template > # > - MSFT:*_*_*_ASL_PATH =3D=3D c:/Iasl/iasl.exe > +# MSFT:*_*_*_ASL_PATH =3D=3D c:/Iasl/iasl.exe >=20 > # > # Override the VFR compile flags to speed the build time > diff --git a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/prebuild.ba= t > b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/prebuild.bat > index 7c444fb..ceb2bbb 100644 > --- a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/prebuild.bat > +++ b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/prebuild.bat > @@ -105,18 +105,8 @@ set TOOL_CHAIN_TAG=3D > ) > ) >=20 > -echo ..WinDDK > -set CHECK_PATH_WINDDK=3DC:\WINDDK\3790.1830 > -if not exist %CHECK_PATH_WINDDK%\bin\bin16\link16.exe ( > - echo. > - echo !!! ERROR !!! Could not find 16-bit linker > at %CHECK_PATH_WINDDK%\bin\bin16\link16.exe. !!! > - echo. > - set SCRIPT_ERROR=3D1 > -) > -set CHECK_PATH_WINDDK=3D > - > echo ..iASL > -set CHECK_PATH_IASL=3Dc:\Iasl > +set CHECK_PATH_IASL=3D%IASL_PREFIX% > if not exist %CHECK_PATH_IASL%\iasl.exe ( > echo. > echo !!! ERROR !!! Could not find iASL compiler > at %CHECK_PATH_IASL%\iasl.exe. !!! > -- > 2.10.0.windows.1