public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "Gao, Liming" <liming.gao@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH edk2-platforms\devel-MinPlatform] MinPlatformPkg: Enable PatchFv tool supports PCD value format in build report
Date: Fri, 6 Jul 2018 14:57:02 +0000	[thread overview]
Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503AC8E4CD@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1530863149-9232-1-git-send-email-liming.gao@intel.com>

Reviewed-by: Jiewen.yao@intel.com

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Liming
> Gao
> Sent: Thursday, July 5, 2018 11:46 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>
> Subject: [edk2] [PATCH edk2-platforms\devel-MinPlatform] MinPlatformPkg:
> Enable PatchFv tool supports PCD value format in build report
> 
> PCD value in build report shows HEX and DEC both. PatchFv tool only requires
> one value.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> ---
>  Platform/Intel/MinPlatformPkg/Tools/PatchFv/PatchBfv.py     | 2 +-
>  Platform/Intel/MinPlatformPkg/Tools/PatchFv/PatchBinFv.py   | 2 +-
>  Platform/Intel/MinPlatformPkg/Tools/PatchFv/RebaseBinFv.py  | 2 +-
>  Platform/Intel/MinPlatformPkg/Tools/PatchFv/SyncBinFvInf.py | 2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/Platform/Intel/MinPlatformPkg/Tools/PatchFv/PatchBfv.py
> b/Platform/Intel/MinPlatformPkg/Tools/PatchFv/PatchBfv.py
> index 73c18c5..bb9d280 100644
> --- a/Platform/Intel/MinPlatformPkg/Tools/PatchFv/PatchBfv.py
> +++ b/Platform/Intel/MinPlatformPkg/Tools/PatchFv/PatchBfv.py
> @@ -101,7 +101,7 @@ class FileChecker:
>                          if (cmp (splitLine[0], "FIXED") == 0) or (cmp
> (splitLine[0], "PATCH") == 0):
>                              SplitLine = splitLine[1].strip()[1:].split(")", 1)
>                              Type = SplitLine[0]
> -                            Value = SplitLine[1].strip()[1:].strip()
> +                            Value = SplitLine[1].strip()[1:].strip().split()[0]
>                              print "  Type - (" + Type + "), Value - (" + Value
> + ")"
>                              return [Value, Type]
>          return ["", ""]
> diff --git a/Platform/Intel/MinPlatformPkg/Tools/PatchFv/PatchBinFv.py
> b/Platform/Intel/MinPlatformPkg/Tools/PatchFv/PatchBinFv.py
> index f5cb427..e1facd1 100644
> --- a/Platform/Intel/MinPlatformPkg/Tools/PatchFv/PatchBinFv.py
> +++ b/Platform/Intel/MinPlatformPkg/Tools/PatchFv/PatchBinFv.py
> @@ -209,7 +209,7 @@ class FileChecker:
>                          if (cmp (splitLine[0], "FIXED") == 0) or (cmp
> (splitLine[0], "PATCH") == 0):
>                              SplitLine = splitLine[1].strip()[1:].split(")", 1)
>                              Type = SplitLine[0]
> -                            Value = SplitLine[1].strip()[1:].strip()
> +                            Value = SplitLine[1].strip()[1:].strip().split()[0]
>                              print "  Type - (" + Type + "), Value - (" + Value
> + ")"
>                              return [Value, Type]
>          return ["", ""]
> diff --git a/Platform/Intel/MinPlatformPkg/Tools/PatchFv/RebaseBinFv.py
> b/Platform/Intel/MinPlatformPkg/Tools/PatchFv/RebaseBinFv.py
> index 5463a93..4d194b3 100644
> --- a/Platform/Intel/MinPlatformPkg/Tools/PatchFv/RebaseBinFv.py
> +++ b/Platform/Intel/MinPlatformPkg/Tools/PatchFv/RebaseBinFv.py
> @@ -643,7 +643,7 @@ class FileChecker:
>                          if (cmp (splitLine[0], "FIXED") == 0) or (cmp
> (splitLine[0], "PATCH") == 0):
>                              SplitLine = splitLine[1].strip()[1:].split(")", 1)
>                              Type = SplitLine[0]
> -                            Value = SplitLine[1].strip()[1:].strip()
> +                            Value = SplitLine[1].strip()[1:].strip().split()[0]
>                              print "  Type - (" + Type + "), Value - (" + Value
> + ")"
>                              return [Value, Type]
>          return ["", ""]
> diff --git a/Platform/Intel/MinPlatformPkg/Tools/PatchFv/SyncBinFvInf.py
> b/Platform/Intel/MinPlatformPkg/Tools/PatchFv/SyncBinFvInf.py
> index 57b6724..19c6e04 100644
> --- a/Platform/Intel/MinPlatformPkg/Tools/PatchFv/SyncBinFvInf.py
> +++ b/Platform/Intel/MinPlatformPkg/Tools/PatchFv/SyncBinFvInf.py
> @@ -423,7 +423,7 @@ class FileChecker:
>                          if (cmp (splitLine[0], "FIXED") == 0) or (cmp
> (splitLine[0], "PATCH") == 0):
>                              SplitLine = splitLine[1].strip()[1:].split(")", 1)
>                              Type = SplitLine[0]
> -                            Value = SplitLine[1].strip()[1:].strip()
> +                            Value = SplitLine[1].strip()[1:].strip().split()[0]
>                              print "  Type - (" + Type + "), Value - (" + Value
> + ")"
>                              return [Value, Type]
>          return ["", ""]
> --
> 2.10.0.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


      parent reply	other threads:[~2018-07-06 14:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-06  7:45 [PATCH edk2-platforms\devel-MinPlatform] MinPlatformPkg: Enable PatchFv tool supports PCD value format in build report Liming Gao
2018-07-06  7:45 ` [PATCH edk2-platforms\devel-MinPlatform] MinPlatform: Update batch file to call python.exe Liming Gao
2018-07-06 14:57   ` Yao, Jiewen
2018-07-06  7:45 ` [PATCH edk2-platforms\devel-MinPlatform] MinPlatform: update ReadMe.md to correct branch name Liming Gao
2018-07-06 14:56   ` Yao, Jiewen
2018-07-06  7:45 ` [PATCH edk2-platforms\devel-MinPlatform] PurleyOpenBoardPkg: Remove unnecessary Link16 and IASL override Liming Gao
2018-07-06 14:56   ` Yao, Jiewen
2018-07-06 14:57 ` Yao, Jiewen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=74D8A39837DF1E4DA445A8C0B3885C503AC8E4CD@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox