From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.31; helo=mga06.intel.com; envelope-from=jiewen.yao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 95C76202E5441 for ; Wed, 11 Jul 2018 00:22:07 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jul 2018 00:22:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,337,1526367600"; d="scan'208";a="55998481" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga008.jf.intel.com with ESMTP; 11 Jul 2018 00:22:07 -0700 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 11 Jul 2018 00:22:07 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 11 Jul 2018 00:22:06 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.124]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.81]) with mapi id 14.03.0319.002; Wed, 11 Jul 2018 15:22:05 +0800 From: "Yao, Jiewen" To: "Zeng, Star" , "edk2-devel@lists.01.org" CC: "Kinney, Michael D" , "Shao, Ming" Thread-Topic: [PATCH] MdeModulePkg CapsuleApp: Fix NestedCapsuleHeader->Flags assigned wrong Thread-Index: AQHUGDgv/HFU7Z2AdUmHnY0ysKdGMKSJnzrw Date: Wed, 11 Jul 2018 07:22:03 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503AC9B7F3@shsmsx102.ccr.corp.intel.com> References: <1531218219-236320-1-git-send-email-star.zeng@intel.com> In-Reply-To: <1531218219-236320-1-git-send-email-star.zeng@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzhkYTYwNDgtN2RmMi00N2NlLTlhZGItYWI4NDE1MTVlN2ViIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiMEpMekJsZTZld0Z6RDU1c3hYMlRHVmtRdXFOWEVFdzJKZEVYcThhMUFsSDl1WEZZZmxUS3JcL2V0Q0VnTHVrSEMifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] MdeModulePkg CapsuleApp: Fix NestedCapsuleHeader->Flags assigned wrong X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jul 2018 07:22:07 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jiewen.yao@intel.com > -----Original Message----- > From: Zeng, Star > Sent: Tuesday, July 10, 2018 6:24 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Kinney, Michael D > ; Yao, Jiewen ; Shao, > Ming > Subject: [PATCH] MdeModulePkg CapsuleApp: Fix NestedCapsuleHeader->Flags > assigned wrong >=20 > (FwType =3D=3D ESRT_FW_TYPE_DEVICEFIRMWARE) ? system : device > should be > (FwType =3D=3D ESRT_FW_TYPE_SYSTEMFIRMWARE) ? system : device >=20 > Cc: Michael D Kinney > Cc: Jiewen Yao > Cc: Ming Shao > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Star Zeng > --- > MdeModulePkg/Application/CapsuleApp/CapsuleApp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/MdeModulePkg/Application/CapsuleApp/CapsuleApp.c > b/MdeModulePkg/Application/CapsuleApp/CapsuleApp.c > index e1e48befc2de..3a1a0a1cb2e6 100644 > --- a/MdeModulePkg/Application/CapsuleApp/CapsuleApp.c > +++ b/MdeModulePkg/Application/CapsuleApp/CapsuleApp.c > @@ -431,7 +431,7 @@ CreateNestedFmp ( > ZeroMem(NestedCapsuleHeader, NESTED_CAPSULE_HEADER_SIZE); > CopyGuid(&NestedCapsuleHeader->CapsuleGuid, ImageTypeId); > NestedCapsuleHeader->HeaderSize =3D NESTED_CAPSULE_HEADER_SIZE; > - NestedCapsuleHeader->Flags =3D (FwType =3D=3D > ESRT_FW_TYPE_DEVICEFIRMWARE) ? SYSTEM_FIRMWARE_FLAG : > DEVICE_FIRMWARE_FLAG; > + NestedCapsuleHeader->Flags =3D (FwType =3D=3D > ESRT_FW_TYPE_SYSTEMFIRMWARE) ? SYSTEM_FIRMWARE_FLAG : > DEVICE_FIRMWARE_FLAG; > NestedCapsuleHeader->CapsuleImageSize =3D (UINT32)FullCapsuleBufferSiz= e; >=20 > CopyMem((UINT8 *)NestedCapsuleHeader + > NestedCapsuleHeader->HeaderSize, CapsuleBuffer, FileSize); > -- > 2.7.0.windows.1