From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "Gao, Liming" <liming.gao@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [Patch edk2-platforms\devel-MinPlatform] PurleyOpenBoardPkg: Update batch file not to check the return value of timeout
Date: Thu, 12 Jul 2018 07:03:50 +0000 [thread overview]
Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503ACA0709@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20180710132848.9320-1-liming.gao@intel.com>
Reviewed-by: jiewen.yao@intel.com
> -----Original Message-----
> From: Gao, Liming
> Sent: Tuesday, July 10, 2018 9:29 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>
> Subject: [Patch edk2-platforms\devel-MinPlatform] PurleyOpenBoardPkg:
> Update batch file not to check the return value of timeout
>
> timeout command may not work well in some environment.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> ---
> Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/bld.bat | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/bld.bat
> b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/bld.bat
> index a6e0605..4c4aec3 100644
> --- a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/bld.bat
> +++ b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/bld.bat
> @@ -111,13 +111,13 @@ echo.
> echo --------------------------------------------------------------------
> echo.
> call postbuild.bat
> +if %ERRORLEVEL% NEQ 0 EXIT /b %ERRORLEVEL%
> timeout 1
> echo --------------------------------------------------------------------
> echo.
> echo PostBuild End
> echo.
> echo --------------------------------------------------------------------
> -if %ERRORLEVEL% NEQ 0 EXIT /b %ERRORLEVEL%
>
> echo %date% %time%
> echo.
> @@ -128,7 +128,6 @@ echo Purley Build
> End
> echo.
> echo --------------------------------------------------------------------------------------------
>
> -if %ERRORLEVEL% NEQ 0 EXIT /b %ERRORLEVEL%
> :done
> endlocal & EXIT /b %SCRIPT_ERROR%
>
> --
> 2.10.0.windows.1
prev parent reply other threads:[~2018-07-12 7:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-10 13:28 [Patch edk2-platforms\devel-MinPlatform] PurleyOpenBoardPkg: Update batch file not to check the return value of timeout Liming Gao
2018-07-12 7:03 ` Yao, Jiewen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74D8A39837DF1E4DA445A8C0B3885C503ACA0709@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox