From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "Wu, Hao A" <hao.a.wu@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Yao, Jiewen" <jiewen.yao@intel.com>
Subject: Re: [PATCH 0/2] Avoid possible NULL ptr dereference
Date: Mon, 30 Jul 2018 07:25:03 +0000 [thread overview]
Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503ACD55CD@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20180730053709.5128-1-hao.a.wu@intel.com>
Seems good.
It might be better to use "if (!EFI_ERROR (Status) && (MemoryAttributesTable != NULL)) {"
Reviewed-by: Jiewen.yao@intel.com
> -----Original Message-----
> From: Wu, Hao A
> Sent: Monday, July 30, 2018 1:37 PM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>
> Subject: [PATCH 0/2] Avoid possible NULL ptr dereference
>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
>
> Hao Wu (2):
> MdePkg/SmmMemLib: Avoid possible NULL ptr dereference
> UefiCpuPkg/PiSmmCpuDxeSmm: Avoid possible NULL ptr dereference
>
> MdePkg/Library/SmmMemLib/SmmMemLib.c | 2 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> --
> 2.12.0.windows.1
next prev parent reply other threads:[~2018-07-30 7:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-30 5:37 [PATCH 0/2] Avoid possible NULL ptr dereference Hao Wu
2018-07-30 5:37 ` [PATCH 1/2] MdePkg/SmmMemLib: " Hao Wu
2018-07-30 5:37 ` [PATCH 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: " Hao Wu
2018-07-30 7:25 ` Yao, Jiewen [this message]
2018-07-30 7:25 ` [PATCH 0/2] " Wu, Hao A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74D8A39837DF1E4DA445A8C0B3885C503ACD55CD@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox