public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "Zhang, Shenglei" <shenglei.zhang@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH] SignedCapsulePkg: Remove redundant things in inf, .h and .c files
Date: Fri, 10 Aug 2018 07:34:44 +0000	[thread overview]
Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503AD02399@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20180810061047.31768-1-shenglei.zhang@intel.com>

Reviewed-by: Jiewen.yao@intel.com

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> shenglei
> Sent: Friday, August 10, 2018 2:11 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>
> Subject: [edk2] [PATCH] SignedCapsulePkg: Remove redundant things in inf, .h
> and .c files
> 
> Two redundant library classes have been removed.
> The redundant function "IsSystemFmp" has been removed.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1067
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: shenglei <shenglei.zhang@intel.com>
> ---
>  .../SystemFirmwareCommonDxe.c                 | 27 -------------------
>  .../SystemFirmwareUpdate/SystemFirmwareDxe.h  |  1 -
>  .../SystemFirmwareReportDxe.inf               |  2 --
>  3 files changed, 30 deletions(-)
> 
> diff --git
> a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareCom
> monDxe.c
> b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareCom
> monDxe.c
> index 7f7a9a1982..8e16763597 100644
> ---
> a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareCom
> monDxe.c
> +++
> b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareCom
> monDxe.c
> @@ -343,31 +343,4 @@ InitializePrivateData (
>    return EFI_SUCCESS;
>  }
> 
> -/**
> -  Return if this FMP is a system FMP or a device FMP, based upon
> FmpImageInfo.
> -
> -  @param[in] FmpImageInfo A pointer to
> EFI_FIRMWARE_IMAGE_DESCRIPTOR
> -
> -  @retval TRUE  It is a system FMP.
> -  @retval FALSE It is a device FMP.
> -**/
> -BOOLEAN
> -IsSystemFmp (
> -  IN EFI_FIRMWARE_IMAGE_DESCRIPTOR   *FmpImageInfo
> -  )
> -{
> -  GUID      *Guid;
> -  UINTN     Count;
> -  UINTN     Index;
> -
> -  Guid = PcdGetPtr(PcdSystemFmpCapsuleImageTypeIdGuid);
> -  Count = PcdGetSize(PcdSystemFmpCapsuleImageTypeIdGuid) /
> sizeof(GUID);
> 
> -  for (Index = 0; Index < Count; Index++, Guid++) {
> -    if (CompareGuid(&FmpImageInfo->ImageTypeId, Guid)) {
> -      return TRUE;
> -    }
> -  }
> -
> -  return FALSE;
> -}
> diff --git
> a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareDxe.h
> b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareDxe.
> h
> index 999b2b2501..cd6601e815 100644
> ---
> a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareDxe.h
> +++
> b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareDxe.
> h
> @@ -36,7 +36,6 @@
>  #include <Library/UefiDriverEntryPoint.h>
>  #include <Library/DevicePathLib.h>
>  #include <Library/HobLib.h>
> -#include <Library/DxeServicesLib.h>
>  #include <Library/DxeServicesTableLib.h>
>  #include <Library/PlatformFlashAccessLib.h>
>  #include <Library/EdkiiSystemCapsuleLib.h>
> diff --git
> a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareRepo
> rtDxe.inf
> b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareRepo
> rtDxe.inf
> index cc9614ef14..b15736cf0d 100644
> ---
> a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareRepo
> rtDxe.inf
> +++
> b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareRepo
> rtDxe.inf
> @@ -50,9 +50,7 @@
>    HobLib
>    UefiRuntimeServicesTableLib
>    UefiDriverEntryPoint
> -  DxeServicesLib
>    DxeServicesTableLib
> -  PrintLib
>    EdkiiSystemCapsuleLib
> 
>  [Pcd]
> --
> 2.18.0.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


  reply	other threads:[~2018-08-10  7:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-10  6:10 [PATCH] SignedCapsulePkg: Remove redundant things in inf, .h and .c files shenglei
2018-08-10  7:34 ` Yao, Jiewen [this message]
2018-08-10  8:42   ` Zeng, Star

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=74D8A39837DF1E4DA445A8C0B3885C503AD02399@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox