From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.43; helo=mga05.intel.com; envelope-from=jiewen.yao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B7C3321123B83 for ; Tue, 11 Sep 2018 15:03:27 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Sep 2018 15:03:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,362,1531810800"; d="scan'208";a="232062833" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga004.jf.intel.com with ESMTP; 11 Sep 2018 15:02:44 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 11 Sep 2018 15:02:43 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 11 Sep 2018 15:02:42 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.226]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.240]) with mapi id 14.03.0319.002; Wed, 12 Sep 2018 06:02:40 +0800 From: "Yao, Jiewen" To: Laszlo Ersek , "Gao, Liming" , "edk2-devel@lists.01.org" CC: "Dong, Eric" Thread-Topic: [edk2] [Patch] UefiCpuPkg PiSmmCpuDxeSmm: Remove unnecessary jmp _SmiHandler Thread-Index: AQHUSN8xD8V1gRuKEEm+8A26kUclC6Tqqh2AgAD6PwA= Date: Tue, 11 Sep 2018 22:02:39 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503AD51D73@shsmsx102.ccr.corp.intel.com> References: <1536567625-9540-1-git-send-email-liming.gao@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzNjNzU4Y2UtOGQzNy00YTg4LWE5YWItNDFjYjg4OGU0MThiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoidThHNnk4SGNQQldCcks5WmdtemJkRHQ1WnpIVllvZzRNcEFiTXYzVFNacTZZeGRCOGNwdERWK2xnaGlPUllsNSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] UefiCpuPkg PiSmmCpuDxeSmm: Remove unnecessary jmp _SmiHandler X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Sep 2018 22:03:27 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable HI Would you please add info on what unit test has been done? Thank you Yao Jiewen > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Laszlo Ersek > Sent: Tuesday, September 11, 2018 11:06 PM > To: Gao, Liming ; edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Dong, Eric > Subject: Re: [edk2] [Patch] UefiCpuPkg PiSmmCpuDxeSmm: Remove > unnecessary jmp _SmiHandler >=20 > On 09/10/18 10:20, Liming Gao wrote: > > This change is wrong introduced by > e21e355e2ca7fefb15b4df7078f995d3fb9c2b89 > > It is not required. So, revert it. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Liming Gao > > Cc: Jiewen Yao > > --- > > UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm | 9 ++------- > > 1 file changed, 2 insertions(+), 7 deletions(-) > > > > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm > b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm > > index 315d0f8..7b1b3ca 100644 > > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm > > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm > > @@ -173,9 +173,8 @@ SmiHandlerIdtrAbsAddr: > > mov gs, eax > > mov ax, [rbx + DSC_SS] > > mov ss, eax > > - mov rax, strict qword 0 ; mov rax, > _SmiHandler > > -_SmiHandlerAbsAddr: > > - jmp rax > > + > > +; jmp _SmiHandler ; instruction is not needed > > > > _SmiHandler: > > mov rbx, [rsp + 0x8] ; rcx <- CpuIndex > > @@ -229,8 +228,4 @@ ASM_PFX(PiSmmCpuSmiEntryFixupAddress): > > lea rax, [ASM_PFX(gSmiHandlerIdtr)] > > lea rcx, [SmiHandlerIdtrAbsAddr] > > mov qword [rcx - 8], rax > > - > > - lea rax, [_SmiHandler] > > - lea rcx, [_SmiHandlerAbsAddr] > > - mov qword [rcx - 8], rax > > ret > > >=20 > Please remember to CC package maintainers / reviewers directly. >=20 > The patch makes sense to me, and indeed it restores the original code. >=20 > Reviewed-by: Laszlo Ersek >=20 > Can you perhaps add another sentence to the commit message, before you > push the patch, such as "the original code already uses RIP-relative > addressing"? >=20 > Thanks > Laszlo > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel