public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "Chiu, Chasel" <chasel.chiu@intel.com>,
	"Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
	Patrick Georgi <pgeorgi@google.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH 2/3] IntelFsp2Pkg: Fix typo in SplitFspBin
Date: Wed, 26 Sep 2018 03:11:26 +0000	[thread overview]
Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503AD9947C@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <3C3EFB470A303B4AB093197B6777CCEC501840E8@PGSMSX111.gar.corp.intel.com>

Reviewed-by: Jiewen.yao@intel.com

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Chiu, Chasel
> Sent: Friday, September 21, 2018 7:28 AM
> To: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Patrick
> Georgi <pgeorgi@google.com>; edk2-devel@lists.01.org
> Subject: Re: [edk2] [PATCH 2/3] IntelFsp2Pkg: Fix typo in SplitFspBin
> 
> 
> Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
> 
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Desimone, Nathaniel L
> Sent: Tuesday, September 18, 2018 11:04 PM
> To: Patrick Georgi <pgeorgi@google.com>; edk2-devel@lists.01.org
> Subject: Re: [edk2] [PATCH 2/3] IntelFsp2Pkg: Fix typo in SplitFspBin
> 
> Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> 
> On 9/18/18, 6:32 AM, "edk2-devel on behalf of Patrick Georgi"
> <edk2-devel-bounces@lists.01.org on behalf of pgeorgi@google.com>
> wrote:
> 
>     Signed-off-by: Patrick Georgi <pgeorgi@google.com>
>     Contributed-under: TianoCore Contribution Agreement 1.1
>     ---
>      IntelFsp2Pkg/Tools/SplitFspBin.py | 2 +-
>      1 file changed, 1 insertion(+), 1 deletion(-)
> 
>     diff --git a/IntelFsp2Pkg/Tools/SplitFspBin.py
> b/IntelFsp2Pkg/Tools/SplitFspBin.py
>     index bd5507c2fa..ac864492e8 100755
>     --- a/IntelFsp2Pkg/Tools/SplitFspBin.py
>     +++ b/IntelFsp2Pkg/Tools/SplitFspBin.py
>     @@ -726,7 +726,7 @@ def SplitFspBin (fspfile, outdir, nametemplate):
>              fspname, ext =
> os.path.splitext(os.path.basename(nametemplate))
>              filename = os.path.join(outdir, fspname + '_' + fsp.Type + ext)
>              hfsp = open(filename, 'wb')
>     -        print ("Ceate FSP component file '%s'" % filename)
>     +        print ("Create FSP component file '%s'" % filename)
>              for fvidx in fsp.FvIdxList:
>                  fv = fd.FvList[fvidx]
>                  hfsp.write(fv.FvData)
>     --
>     2.19.0.397.gdd90340f6a-goog
> 
>     _______________________________________________
>     edk2-devel mailing list
>     edk2-devel@lists.01.org
>     https://lists.01.org/mailman/listinfo/edk2-devel
> 
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel

  reply	other threads:[~2018-09-26  3:12 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-18 13:32 [PATCH 1/3] IntelFsp2Pkg: Allow calling SplitFspBin.py directly Patrick Georgi
2018-09-18 13:32 ` [PATCH 2/3] IntelFsp2Pkg: Fix typo in SplitFspBin Patrick Georgi
2018-09-18 15:04   ` Desimone, Nathaniel L
2018-09-20 23:28     ` Chiu, Chasel
2018-09-26  3:11       ` Yao, Jiewen [this message]
2018-09-18 13:32 ` [PATCH 3/3] IntelFsp2Pkg: Tell git to format SplitFspBin.py with native newlines Patrick Georgi
2018-09-18 15:10   ` Desimone, Nathaniel L
2018-09-18 15:53     ` Patrick Georgi
2018-09-20  4:37       ` Desimone, Nathaniel L
2018-09-26  3:12         ` Yao, Jiewen
2018-09-26 15:58           ` Patrick Georgi
2018-09-27  0:40             ` Yao, Jiewen
2018-09-18 15:03 ` [PATCH 1/3] IntelFsp2Pkg: Allow calling SplitFspBin.py directly Desimone, Nathaniel L

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=74D8A39837DF1E4DA445A8C0B3885C503AD9947C@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox