From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "Chiu, Chasel" <chasel.chiu@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Gao, Liming" <liming.gao@intel.com>
Subject: Re: [PATCH] IntelFsp2Pkg/GenCfgOpt.py: support FixedAtBuild PCD
Date: Wed, 26 Sep 2018 07:23:58 +0000 [thread overview]
Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503AD9C525@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20180926052449.12076-1-chasel.chiu@intel.com>
Reviewed-by: Jiewen.yao@intel.com
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Chasel, Chiu
> Sent: Wednesday, September 26, 2018 1:25 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Gao, Liming
> <liming.gao@intel.com>
> Subject: [edk2] [PATCH] IntelFsp2Pkg/GenCfgOpt.py: support FixedAtBuild
> PCD
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1210
>
> FixedAtBuild PCD is suggested to be used instead
> of FeatureFlag PCD so extend this tool to support.
> Also skipped PCDs which commented out by '#'.
>
> Test: Verified with FixedAtBuild PCD for including or
> excluding lines in generated UPD header files successfully.
>
> Cc: Jiewen Yao <Jiewen.yao@intel.com>
> Cc: Gao Liming <liming.gao@intel.com>
> Cc: Zhu Yonghong <yonghong.zhu@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Chasel Chiu <chasel.chiu@intel.com>
> ---
> IntelFsp2Pkg/Tools/GenCfgOpt.py | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/IntelFsp2Pkg/Tools/GenCfgOpt.py
> b/IntelFsp2Pkg/Tools/GenCfgOpt.py
> index c9b7bc5373..32cf63ff03 100644
> --- a/IntelFsp2Pkg/Tools/GenCfgOpt.py
> +++ b/IntelFsp2Pkg/Tools/GenCfgOpt.py
> @@ -1,6 +1,6 @@
> ## @ GenCfgOpt.py
> #
> -# Copyright (c) 2014 - 2017, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2014 - 2018, Intel Corporation. All rights reserved.<BR>
> # This program and the accompanying materials are licensed and made
> available under
> # the terms and conditions of the BSD License that accompanies this
> distribution.
> # The full text of the license may be found at
> @@ -449,7 +449,7 @@ EndList
> IsUpdSect = False
> if Match.group(1).lower() == "Defines".lower():
> IsDefSect = True
> - if Match.group(1).lower() ==
> "PcdsFeatureFlag".lower():
> + if (Match.group(1).lower() ==
> "PcdsFeatureFlag".lower() or Match.group(1).lower() ==
> "PcdsFixedAtBuild".lower()):
> IsPcdSect = True
> elif Match.group(1).lower() ==
> "PcdsDynamicVpd.Upd".lower():
> ConfigDict = {}
> @@ -491,7 +491,7 @@ EndList
> IfStack.append(Result)
> ElifStack.append(0)
> else:
> - Match = re.match("!(if|elseif)\s+(.+)",
> DscLine)
> + Match = re.match("!(if|elseif)\s+(.+)",
> DscLine.split("#")[0])
> if Match:
> Result =
> self.EvaluateExpress(Match.group(2))
> if Match.group(1) == "if":
> --
> 2.13.3.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2018-09-26 7:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 5:24 [PATCH] IntelFsp2Pkg/GenCfgOpt.py: support FixedAtBuild PCD Chasel, Chiu
2018-09-26 7:23 ` Yao, Jiewen [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-09-26 3:05 Chasel, Chiu
2018-09-26 3:13 ` Yao, Jiewen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74D8A39837DF1E4DA445A8C0B3885C503AD9C525@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox