public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "Zhang, Shenglei" <shenglei.zhang@intel.com>,
	"'edk2-devel@lists.01.org'" <edk2-devel@lists.01.org>
Subject: Re: [PATCH v2] Edk2Platforms: Replace FatBinPkg with FatPkg
Date: Mon, 22 Oct 2018 03:05:13 +0000	[thread overview]
Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503AE113E1@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <C0706E73DB8C124D9B9C38AA364E5D5E61F543@shsmsx102.ccr.corp.intel.com>

Reviewed-by: Jiewen.yao@intel.com


> -----Original Message-----
> From: Zhang, Shenglei
> Sent: Monday, October 22, 2018 11:03 AM
> To: Yao, Jiewen <jiewen.yao@intel.com>; 'edk2-devel@lists.01.org'
> <edk2-devel@lists.01.org>
> Cc: Zhang, Shenglei <shenglei.zhang@intel.com>
> Subject: RE: [edk2] [PATCH v2] Edk2Platforms: Replace FatBinPkg with
> FatPkg
> 
> Hi Jiewen,
> 
> After my test, the KabyLake Platform based on my changes can be booted to
> Shell successfully. And a disk can be recognized correctly.
> 
> Thanks,
> Shenglei
> 
> > -----Original Message-----
> > From: Zhang, Shenglei
> > Sent: Thursday, October 18, 2018 4:38 PM
> > To: Yao, Jiewen <jiewen.yao@intel.com>; edk2-devel@lists.01.org
> > Subject: RE: [edk2] [PATCH v2] Edk2Platforms: Replace FatBinPkg with
> FatPkg
> >
> >
> >
> > > -----Original Message-----
> > > From: Yao, Jiewen
> > > Sent: Thursday, October 18, 2018 11:00 AM
> > > To: Zhang, Shenglei <shenglei.zhang@intel.com>;
> edk2-devel@lists.01.org
> > > Cc: Yao, Jiewen <jiewen.yao@intel.com>
> > > Subject: RE: [edk2] [PATCH v2] Edk2Platforms: Replace FatBinPkg with
> > FatPkg
> > >
> > > Hi
> > > Would you please share what test has been done?
> >
> > I build edk2-platfroms for MinKabylake according to "readme" in edk2-
> > platforms.
> > And the EDKII BIOS build has successfully completed.
> >
> > Thanks,
> > Shenglei
> >
> > >
> > > Thank you
> > > Yao Jiewen
> > >
> > >
> > > > -----Original Message-----
> > > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf
> Of
> > > > shenglei
> > > > Sent: Thursday, October 18, 2018 10:35 AM
> > > > To: edk2-devel@lists.01.org
> > > > Subject: [edk2] [PATCH v2] Edk2Platforms: Replace FatBinPkg with
> FatPkg
> > > >
> > > > In order to remove FatBinPkg, relationships depend on
> > > > FatBinPkg need to be replaced by FatPkg.
> > > >
> > > > v2:
> > > > 1.Replace FatBinPkg with FatPkg in CoreUefiBootInclude.fdf.
> > > > 2.Update the subject.
> > > >
> > > > Change-Id: I8949ad1c7d18abc56deac2d4b4381e00f030dcb2
> > > > Contributed-under: TianoCore Contribution Agreement 1.1
> > > > Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> > > > ---
> > > >  Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeInclude.dsc
> | 2 +-
> > > >  .../Intel/MinPlatformPkg/Include/Fdf/CoreUefiBootInclude.fdf    |
> 2 +-
> > > >  2 files changed, 2 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git
> > > a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeInclude.dsc
> > > > b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeInclude.dsc
> > > > index 73aafce141..9b033f43a6 100644
> > > > --- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeInclude.dsc
> > > > +++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeInclude.dsc
> > > > @@ -84,7 +84,7 @@
> > > >    MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
> > > >    MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
> > > >
> > > >
> > >
> >
> MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf
> > > > -  FatBinPkg/EnhancedFatDxe/Fat.inf
> > > > +  FatPkg/EnhancedFatDxe/Fat.inf
> > > >
> > > >
> > > >
> > >
> > #MdeModulePkg/Universal/Console/GraphicsOutputDxe/GraphicsOutputD
> > > x
> > > > e.inf
> > > >
> > > >
> > >
> >
> MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleD
> > > > xe.inf
> > > > diff --git
> > > >
> a/Platform/Intel/MinPlatformPkg/Include/Fdf/CoreUefiBootInclude.fdf
> > > >
> b/Platform/Intel/MinPlatformPkg/Include/Fdf/CoreUefiBootInclude.fdf
> > > > index 6406192443..da5ca76197 100644
> > > > ---
> > a/Platform/Intel/MinPlatformPkg/Include/Fdf/CoreUefiBootInclude.fdf
> > > > +++
> > > b/Platform/Intel/MinPlatformPkg/Include/Fdf/CoreUefiBootInclude.fdf
> > > > @@ -58,7 +58,7 @@ INF
> > > > MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf
> > > >  INF  MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
> > > >  INF  MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
> > > >  INF
> > > >
> > >
> >
> MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf
> > > > -INF  FatBinPkg/EnhancedFatDxe/Fat.inf
> > > > +INF  FatPkg/EnhancedFatDxe/Fat.inf
> > > >
> > > >  #INF
> > > >
> > >
> > MdeModulePkg/Universal/Console/GraphicsOutputDxe/GraphicsOutputDx
> > > e.
> > > > inf
> > > >  INF
> > > >
> > >
> >
> MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleD
> > > > xe.inf
> > > > --
> > > > 2.18.0.windows.1
> > > >
> > > > _______________________________________________
> > > > edk2-devel mailing list
> > > > edk2-devel@lists.01.org
> > > > https://lists.01.org/mailman/listinfo/edk2-devel


      reply	other threads:[~2018-10-22  3:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-18  2:35 [PATCH v2] Edk2Platforms: Replace FatBinPkg with FatPkg shenglei
2018-10-18  2:59 ` Yao, Jiewen
2018-10-18  8:38   ` Zhang, Shenglei
2018-10-22  3:02     ` Zhang, Shenglei
2018-10-22  3:05       ` Yao, Jiewen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=74D8A39837DF1E4DA445A8C0B3885C503AE113E1@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox