public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "Chiu, Chasel" <chasel.chiu@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH] IntelFsp2Pkg: Fix GCC49/XCODE build failure
Date: Fri, 26 Oct 2018 03:21:49 +0000	[thread overview]
Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503AE2EDC6@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20181026031834.2736-1-chasel.chiu@intel.com>

Reviewed-by: Jiewen.yao@intel.com

> -----Original Message-----
> From: Chiu, Chasel
> Sent: Friday, October 26, 2018 11:19 AM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>
> Subject: [PATCH] IntelFsp2Pkg: Fix GCC49/XCODE build failure
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1276
> 
> Fixed potentially uninitialized variable build failure
> caused by commit: b1cc6f672f3b924cdb190e5b92db3b47f46a8911
> 
> Test: Verified on internal platform and boots successfully.
> 
> Cc: Jiewen Yao <Jiewen.yao@intel.com>
> Cc: Desimone Nathaniel L <nathaniel.l.desimone@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Chasel Chiu <chasel.chiu@intel.com>
> ---
>  IntelFsp2Pkg/FspSecCore/SecMain.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/IntelFsp2Pkg/FspSecCore/SecMain.c
> b/IntelFsp2Pkg/FspSecCore/SecMain.c
> index ddbfc4fcdf..f319c68cc5 100644
> --- a/IntelFsp2Pkg/FspSecCore/SecMain.c
> +++ b/IntelFsp2Pkg/FspSecCore/SecMain.c
> @@ -107,13 +107,12 @@ SecStartup (
>      }
>      IdtSize = sizeof (IdtTableInStack.IdtTable);
>    } else {
> -    if (IdtDescriptor.Limit + 1 > sizeof (IdtTableInStack.IdtTable)) {
> +    IdtSize = IdtDescriptor.Limit + 1;
> +    if (IdtSize > sizeof (IdtTableInStack.IdtTable)) {
>        //
>        // ERROR: IDT table size from boot loader is larger than FSP can
> support, DeadLoop here!
>        //
>        CpuDeadLoop();
> -    } else {
> -      IdtSize = IdtDescriptor.Limit + 1;
>      }
>      CopyMem ((VOID *) (UINTN) &IdtTableInStack.IdtTable, (VOID *)
> IdtDescriptor.Base, IdtSize);
>    }
> --
> 2.13.3.windows.1



      reply	other threads:[~2018-10-26  3:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-26  3:18 [PATCH] IntelFsp2Pkg: Fix GCC49/XCODE build failure Chasel, Chiu
2018-10-26  3:21 ` Yao, Jiewen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=74D8A39837DF1E4DA445A8C0B3885C503AE2EDC6@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox