Re: [PATCH 1/4] SecurityPkg: enable TPM components to build for ARM and AARCH64

["Yao, Jiewen" <jiewen.yao@intel.com>]

Thanks Eugene

For 3, I do not think you need expose your IP.

There are 2 purposes I propose.
1) To prove this patch works for SPI.
We need a real example to use this TpmIoLib.
It is OK to keep it close source if it is IP.
I just want to make sure this approach is feasible.

2) To demonstrate how to do that.
If you can use EFI_SPI_PROTOCOL, that would be perfect.

Thank you
Yao Jiewen

> -----Original Message-----
> From: Cohen, Eugene [mailto:eugene@hp.com]
> Sent: Wednesday, November 14, 2018 6:49 AM
> To: Yao, Jiewen <jiewen.yao@intel.com>; edk2-devel@lists.01.org; Zhang,
> Chao B <chao.b.zhang@intel.com>
> Cc: Bin, Sung-Uk (빈성욱) <sunguk-bin@hp.com>
> Subject: RE: [PATCH 1/4] SecurityPkg: enable TPM components to build for
> ARM and AARCH64
> 
> Jiewen,
> 
> 1 and 2 - okay, no problem, working on it.
> 
> 3 - we are developing the SPI TPM support as we speak.  Our SPI controller
> is proprietary so there's no value in trying to share that driver.  Our internal
> SPI driver currently does not support the PI spec SPI_IO_PROTOCOL but are
> looking at adopting it - if so then we could contribute the TpmIoLibSpi
> instance which would connect the TPM stack to the SPI_IO_PROTOCOL.  Is
> this what you wanted or is there something more specific you were looking
> for?
> 
> Thanks,
> 
> Eugene
> 
> > -----Original Message-----
> > From: Yao, Jiewen <jiewen.yao@intel.com>
> > Sent: Tuesday, November 13, 2018 3:22 PM
> > To: Cohen, Eugene <eugene@hp.com>; edk2-devel@lists.01.org; Zhang,
> > Chao B <chao.b.zhang@intel.com>
> > Cc: Bin, Sung-Uk (빈성욱) <sunguk-bin@hp.com>
> > Subject: RE: [PATCH 1/4] SecurityPkg: enable TPM components to build for
> > ARM and AARCH64
> >
> > HI Eugene
> > Thanks to enable SPI TPM chip.
> > In general, I am OK on this patch series.
> >
> > There are some additional work here.
> > 1) Please split this patch to 2. The TpmIoLib is not present in at this point of
> > time. We should add it after TpmIoLib instance is added.
> >
> > 2) Since this patch series adds the dependency of TpmIoLib, please update
> > *all* impacted platform in EDKII repo and EDKII platform repo.
> > We need make sure this patch series does not break any existing platform
> > build.
> >
> > 3) I hope, (if possible) you can provide one *real example* on how to add
> > SPI instance, to demonstrate the usage and value of this one more layer
> > abstraction.
> >
> > Thank you
> > Yao Jiewen
> >
> >
> > > -----Original Message-----
> > > From: Cohen, Eugene [mailto:eugene@hp.com]
> > > Sent: Wednesday, November 14, 2018 6:13 AM
> > > To: edk2-devel@lists.01.org; Yao, Jiewen <jiewen.yao@intel.com>;
> > > Zhang, Chao B <chao.b.zhang@intel.com>
> > > Cc: Bin, Sung-Uk (빈성욱) <sunguk-bin@hp.com>
> > > Subject: [PATCH 1/4] SecurityPkg: enable TPM components to build for
> > > ARM and AARCH64
> > >
> > >  SecurityPkg: enable TPM components to build for ARM and AARCH64
> > >
> > > Contributed-under: TianoCore Contribution Agreement 1.1
> > > Cc: Chao Zhang <chao.b.zhang@intel.com>
> > > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > > Signed-off-by: Eugene Cohen <eugene@hp.com>
> > > ---
> > >  SecurityPkg/SecurityPkg.dsc | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/SecurityPkg/SecurityPkg.dsc b/SecurityPkg/SecurityPkg.dsc
> > > index 68a2953..6fb9ad2 100644
> > > --- a/SecurityPkg/SecurityPkg.dsc
> > > +++ b/SecurityPkg/SecurityPkg.dsc
> > > @@ -53,6 +53,7 @@
> > >    IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf
> > >    OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf
> > >    IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf
> > > +  TpmIoLib|SecurityPkg/Library/TpmIoLibMmio/TpmIoLibMmio.inf
> > >    TpmCommLib|SecurityPkg/Library/TpmCommLib/TpmCommLib.inf
> > >
> > >
> > PlatformSecureLib|SecurityPkg/Library/PlatformSecureLibNull/PlatformSe
> > > PlatformSecureLib|cu
> > > reLibNull.inf
> > >
> > >
> > TcgPhysicalPresenceLib|SecurityPkg/Library/DxeTcgPhysicalPresenceLib/D
> > > TcgPhysicalPresenceLib|xe
> > > TcgPhysicalPresenceLib.inf
> > > @@ -199,7 +200,7 @@
> > >  [Components.IA32, Components.X64, Components.ARM,
> > Components.AARCH64]
> > >    SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
> > >
> > > -[Components.IA32, Components.X64]
> > > +[Components.IA32, Components.X64 Components.ARM,
> > > Components.AARCH64]
> > >  #
> > >
> > SecurityPkg/UserIdentification/PwdCredentialProviderDxe/PwdCredential
> > P
> > > r
> > > oviderDxe.inf
> > >  #
> > >
> > SecurityPkg/UserIdentification/UsbCredentialProviderDxe/UsbCredentialP
> > > ro
> > > viderDxe.inf
> > >
> > >
> > SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootCon
> > fi
> > > gDxe.inf
> > > --
> > > 2.7.4