From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "Solanki, Digant H" <digant.h.solanki@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Gao, Liming" <liming.gao@intel.com>
Subject: Re: [PATCH] IntelSiliconPkg\Include\IndustryStandard: Update IGD_OPREGION_MBOX3 Structure
Date: Mon, 14 Jan 2019 14:33:33 +0000 [thread overview]
Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503F4A6417@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20190114095925.10244-1-digant.h.solanki@intel.com>
Hi
According to https://01.org/sites/default/files/documentation/skl_opregion_rev0p5.pdf, there is no the new field.
Would you please give a new link for the latest spec to make sure code/doc match ?
Thank you
Yao Jiewen
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Digant H Solanki
> Sent: Monday, January 14, 2019 1:59 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: [edk2] [PATCH] IntelSiliconPkg\Include\IndustryStandard: Update
> IGD_OPREGION_MBOX3 Structure
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1454
> Based on latest IGD OpRegion Spec, IGD_OPREGION_MBOX3 needs to be
> updated with two new members : Physical Address of Raw VBT Data (RVDA)
> and Size of Raw VBT Data (RVDS)
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Digant H Solanki <digant.h.solanki@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> ---
> IntelSiliconPkg/Include/IndustryStandard/IgdOpRegion.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/IntelSiliconPkg/Include/IndustryStandard/IgdOpRegion.h
> b/IntelSiliconPkg/Include/IndustryStandard/IgdOpRegion.h
> index 5ce80a5be8..e1d92717a4 100644
> --- a/IntelSiliconPkg/Include/IndustryStandard/IgdOpRegion.h
> +++ b/IntelSiliconPkg/Include/IndustryStandard/IgdOpRegion.h
> @@ -4,9 +4,7 @@
>
>
> https://01.org/sites/default/files/documentation/skl_opregion_rev0p5.pdf
>
> - @note Fixed bug in the spec Mailbox3 - RM31 size from 0x45(69) to
> 0x46(70)
> -
> - Copyright (c) 2016, Intel Corporation. All rights reserved.<BR>
> + Copyright (c) 2016 - 2019, Intel Corporation. All rights reserved.<BR>
> This program and the accompanying materials
> are licensed and made available under the terms and conditions of the
> BSD License
> which accompanies this distribution. The full text of the license may be
> found at
> @@ -118,7 +116,9 @@ typedef struct {
> UINT64 FDSS; ///< Offset 0x3AA DSS Buffer address allocated
> for IFFS feature
> UINT32 FDSP; ///< Offset 0x3B2 Size of DSS buffer
> UINT32 STAT; ///< Offset 0x3B6 State Indicator
> - UINT8 RM31[0x46]; ///< Offset 0x3BA - 0x3FF Reserved Must be
> zero. Bug in spec 0x45(69)
> + UINT64 RVDA; ///< Offset 0x3BA Physical address of Raw
> VBT data
> + UINT32 RVDS; ///< Offset 0x3C2 Size of Raw VBT data
> + UINT8 RM31[0x3A]; ///< Offset 0x3C6 - 0x3FF Reserved Must be
> zero.
> } IGD_OPREGION_MBOX3;
>
> ///
> --
> 2.18.0.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2019-01-14 14:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 9:59 [PATCH] IntelSiliconPkg\Include\IndustryStandard: Update IGD_OPREGION_MBOX3 Structure Digant H Solanki
2019-01-14 14:33 ` Yao, Jiewen [this message]
2019-01-14 16:06 ` Chaganty, Rangasai V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74D8A39837DF1E4DA445A8C0B3885C503F4A6417@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox