* [PATCH] IntelSiliconPkg\Include\IndustryStandard: Update IGD_OPREGION_MBOX3 Structure
@ 2019-01-14 9:59 Digant H Solanki
2019-01-14 14:33 ` Yao, Jiewen
2019-01-14 16:06 ` Chaganty, Rangasai V
0 siblings, 2 replies; 3+ messages in thread
From: Digant H Solanki @ 2019-01-14 9:59 UTC (permalink / raw)
To: edk2-devel; +Cc: Liming Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1454
Based on latest IGD OpRegion Spec, IGD_OPREGION_MBOX3 needs to be updated with two new members : Physical Address of Raw VBT Data (RVDA) and Size of Raw VBT Data (RVDS)
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Digant H Solanki <digant.h.solanki@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
---
IntelSiliconPkg/Include/IndustryStandard/IgdOpRegion.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/IntelSiliconPkg/Include/IndustryStandard/IgdOpRegion.h b/IntelSiliconPkg/Include/IndustryStandard/IgdOpRegion.h
index 5ce80a5be8..e1d92717a4 100644
--- a/IntelSiliconPkg/Include/IndustryStandard/IgdOpRegion.h
+++ b/IntelSiliconPkg/Include/IndustryStandard/IgdOpRegion.h
@@ -4,9 +4,7 @@
https://01.org/sites/default/files/documentation/skl_opregion_rev0p5.pdf
- @note Fixed bug in the spec Mailbox3 - RM31 size from 0x45(69) to 0x46(70)
-
- Copyright (c) 2016, Intel Corporation. All rights reserved.<BR>
+ Copyright (c) 2016 - 2019, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at
@@ -118,7 +116,9 @@ typedef struct {
UINT64 FDSS; ///< Offset 0x3AA DSS Buffer address allocated for IFFS feature
UINT32 FDSP; ///< Offset 0x3B2 Size of DSS buffer
UINT32 STAT; ///< Offset 0x3B6 State Indicator
- UINT8 RM31[0x46]; ///< Offset 0x3BA - 0x3FF Reserved Must be zero. Bug in spec 0x45(69)
+ UINT64 RVDA; ///< Offset 0x3BA Physical address of Raw VBT data
+ UINT32 RVDS; ///< Offset 0x3C2 Size of Raw VBT data
+ UINT8 RM31[0x3A]; ///< Offset 0x3C6 - 0x3FF Reserved Must be zero.
} IGD_OPREGION_MBOX3;
///
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] IntelSiliconPkg\Include\IndustryStandard: Update IGD_OPREGION_MBOX3 Structure
2019-01-14 9:59 [PATCH] IntelSiliconPkg\Include\IndustryStandard: Update IGD_OPREGION_MBOX3 Structure Digant H Solanki
@ 2019-01-14 14:33 ` Yao, Jiewen
2019-01-14 16:06 ` Chaganty, Rangasai V
1 sibling, 0 replies; 3+ messages in thread
From: Yao, Jiewen @ 2019-01-14 14:33 UTC (permalink / raw)
To: Solanki, Digant H, edk2-devel@lists.01.org; +Cc: Gao, Liming
Hi
According to https://01.org/sites/default/files/documentation/skl_opregion_rev0p5.pdf, there is no the new field.
Would you please give a new link for the latest spec to make sure code/doc match ?
Thank you
Yao Jiewen
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Digant H Solanki
> Sent: Monday, January 14, 2019 1:59 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: [edk2] [PATCH] IntelSiliconPkg\Include\IndustryStandard: Update
> IGD_OPREGION_MBOX3 Structure
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1454
> Based on latest IGD OpRegion Spec, IGD_OPREGION_MBOX3 needs to be
> updated with two new members : Physical Address of Raw VBT Data (RVDA)
> and Size of Raw VBT Data (RVDS)
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Digant H Solanki <digant.h.solanki@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> ---
> IntelSiliconPkg/Include/IndustryStandard/IgdOpRegion.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/IntelSiliconPkg/Include/IndustryStandard/IgdOpRegion.h
> b/IntelSiliconPkg/Include/IndustryStandard/IgdOpRegion.h
> index 5ce80a5be8..e1d92717a4 100644
> --- a/IntelSiliconPkg/Include/IndustryStandard/IgdOpRegion.h
> +++ b/IntelSiliconPkg/Include/IndustryStandard/IgdOpRegion.h
> @@ -4,9 +4,7 @@
>
>
> https://01.org/sites/default/files/documentation/skl_opregion_rev0p5.pdf
>
> - @note Fixed bug in the spec Mailbox3 - RM31 size from 0x45(69) to
> 0x46(70)
> -
> - Copyright (c) 2016, Intel Corporation. All rights reserved.<BR>
> + Copyright (c) 2016 - 2019, Intel Corporation. All rights reserved.<BR>
> This program and the accompanying materials
> are licensed and made available under the terms and conditions of the
> BSD License
> which accompanies this distribution. The full text of the license may be
> found at
> @@ -118,7 +116,9 @@ typedef struct {
> UINT64 FDSS; ///< Offset 0x3AA DSS Buffer address allocated
> for IFFS feature
> UINT32 FDSP; ///< Offset 0x3B2 Size of DSS buffer
> UINT32 STAT; ///< Offset 0x3B6 State Indicator
> - UINT8 RM31[0x46]; ///< Offset 0x3BA - 0x3FF Reserved Must be
> zero. Bug in spec 0x45(69)
> + UINT64 RVDA; ///< Offset 0x3BA Physical address of Raw
> VBT data
> + UINT32 RVDS; ///< Offset 0x3C2 Size of Raw VBT data
> + UINT8 RM31[0x3A]; ///< Offset 0x3C6 - 0x3FF Reserved Must be
> zero.
> } IGD_OPREGION_MBOX3;
>
> ///
> --
> 2.18.0.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] IntelSiliconPkg\Include\IndustryStandard: Update IGD_OPREGION_MBOX3 Structure
2019-01-14 9:59 [PATCH] IntelSiliconPkg\Include\IndustryStandard: Update IGD_OPREGION_MBOX3 Structure Digant H Solanki
2019-01-14 14:33 ` Yao, Jiewen
@ 2019-01-14 16:06 ` Chaganty, Rangasai V
1 sibling, 0 replies; 3+ messages in thread
From: Chaganty, Rangasai V @ 2019-01-14 16:06 UTC (permalink / raw)
To: Solanki, Digant H, edk2-devel@lists.01.org
Cc: Gao, Liming, Ni, Ray, Chaganty, Rangasai V
Please add the spec revision in the comment that introduced this change. Also if the spec has provided any additional details or rationale, please add the summary to justify this change.
Thanks,
Sai
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Digant H Solanki
Sent: Monday, January 14, 2019 1:59 AM
To: edk2-devel@lists.01.org
Cc: Gao, Liming <liming.gao@intel.com>
Subject: [edk2] [PATCH] IntelSiliconPkg\Include\IndustryStandard: Update IGD_OPREGION_MBOX3 Structure
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1454
Based on latest IGD OpRegion Spec, IGD_OPREGION_MBOX3 needs to be updated with two new members : Physical Address of Raw VBT Data (RVDA) and Size of Raw VBT Data (RVDS)
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Digant H Solanki <digant.h.solanki@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
---
IntelSiliconPkg/Include/IndustryStandard/IgdOpRegion.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/IntelSiliconPkg/Include/IndustryStandard/IgdOpRegion.h b/IntelSiliconPkg/Include/IndustryStandard/IgdOpRegion.h
index 5ce80a5be8..e1d92717a4 100644
--- a/IntelSiliconPkg/Include/IndustryStandard/IgdOpRegion.h
+++ b/IntelSiliconPkg/Include/IndustryStandard/IgdOpRegion.h
@@ -4,9 +4,7 @@
https://01.org/sites/default/files/documentation/skl_opregion_rev0p5.pdf
- @note Fixed bug in the spec Mailbox3 - RM31 size from 0x45(69) to 0x46(70)
-
- Copyright (c) 2016, Intel Corporation. All rights reserved.<BR>
+ Copyright (c) 2016 - 2019, Intel Corporation. All rights
+ reserved.<BR>
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at @@ -118,7 +116,9 @@ typedef struct {
UINT64 FDSS; ///< Offset 0x3AA DSS Buffer address allocated for IFFS feature
UINT32 FDSP; ///< Offset 0x3B2 Size of DSS buffer
UINT32 STAT; ///< Offset 0x3B6 State Indicator
- UINT8 RM31[0x46]; ///< Offset 0x3BA - 0x3FF Reserved Must be zero. Bug in spec 0x45(69)
+ UINT64 RVDA; ///< Offset 0x3BA Physical address of Raw VBT data
+ UINT32 RVDS; ///< Offset 0x3C2 Size of Raw VBT data
+ UINT8 RM31[0x3A]; ///< Offset 0x3C6 - 0x3FF Reserved Must be zero.
} IGD_OPREGION_MBOX3;
///
--
2.18.0.windows.1
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-14 16:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-14 9:59 [PATCH] IntelSiliconPkg\Include\IndustryStandard: Update IGD_OPREGION_MBOX3 Structure Digant H Solanki
2019-01-14 14:33 ` Yao, Jiewen
2019-01-14 16:06 ` Chaganty, Rangasai V
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox