From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.93; helo=mga11.intel.com; envelope-from=jiewen.yao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 28A5521196206 for ; Mon, 14 Jan 2019 06:33:36 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Jan 2019 06:33:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,477,1539673200"; d="scan'208";a="311673036" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga005.fm.intel.com with ESMTP; 14 Jan 2019 06:33:35 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 14 Jan 2019 06:33:35 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.63]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.159]) with mapi id 14.03.0415.000; Mon, 14 Jan 2019 22:33:33 +0800 From: "Yao, Jiewen" To: "Solanki, Digant H" , "edk2-devel@lists.01.org" CC: "Gao, Liming" Thread-Topic: [edk2] [PATCH] IntelSiliconPkg\Include\IndustryStandard: Update IGD_OPREGION_MBOX3 Structure Thread-Index: AQHUq+/tJXsuXOtT+Em2ZLwlrtHVG6Wuw+CQ Date: Mon, 14 Jan 2019 14:33:33 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503F4A6417@shsmsx102.ccr.corp.intel.com> References: <20190114095925.10244-1-digant.h.solanki@intel.com> In-Reply-To: <20190114095925.10244-1-digant.h.solanki@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiN2IwYzFhMmEtODdmMi00MGNiLWFmYzctNjM3YWMyMzZhYzkxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiMEN5UG5cL0g2a3BieTk1eEIzbDNNelFaVlhQc1NOcFB0aEp0MWcxamQwSVwvejMwRE9xWDZCTlhwT24wUVZEdzhmIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] IntelSiliconPkg\Include\IndustryStandard: Update IGD_OPREGION_MBOX3 Structure X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2019 14:33:37 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi According to https://01.org/sites/default/files/documentation/skl_opregion_= rev0p5.pdf, there is no the new field. Would you please give a new link for the latest spec to make sure code/doc = match ? Thank you Yao Jiewen > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Digant H Solanki > Sent: Monday, January 14, 2019 1:59 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2] [PATCH] IntelSiliconPkg\Include\IndustryStandard: Update > IGD_OPREGION_MBOX3 Structure >=20 > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1454 > Based on latest IGD OpRegion Spec, IGD_OPREGION_MBOX3 needs to be > updated with two new members : Physical Address of Raw VBT Data (RVDA) > and Size of Raw VBT Data (RVDS) >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Digant H Solanki > Cc: Liming Gao > --- > IntelSiliconPkg/Include/IndustryStandard/IgdOpRegion.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/IntelSiliconPkg/Include/IndustryStandard/IgdOpRegion.h > b/IntelSiliconPkg/Include/IndustryStandard/IgdOpRegion.h > index 5ce80a5be8..e1d92717a4 100644 > --- a/IntelSiliconPkg/Include/IndustryStandard/IgdOpRegion.h > +++ b/IntelSiliconPkg/Include/IndustryStandard/IgdOpRegion.h > @@ -4,9 +4,7 @@ >=20 >=20 > https://01.org/sites/default/files/documentation/skl_opregion_rev0p5.pdf >=20 > - @note Fixed bug in the spec Mailbox3 - RM31 size from 0x45(69) to > 0x46(70) > - > - Copyright (c) 2016, Intel Corporation. All rights reserved.
> + Copyright (c) 2016 - 2019, Intel Corporation. All rights reserved.
> This program and the accompanying materials > are licensed and made available under the terms and conditions of the > BSD License > which accompanies this distribution. The full text of the license may= be > found at > @@ -118,7 +116,9 @@ typedef struct { > UINT64 FDSS; ///< Offset 0x3AA DSS Buffer address allocated > for IFFS feature > UINT32 FDSP; ///< Offset 0x3B2 Size of DSS buffer > UINT32 STAT; ///< Offset 0x3B6 State Indicator > - UINT8 RM31[0x46]; ///< Offset 0x3BA - 0x3FF Reserved Must be > zero. Bug in spec 0x45(69) > + UINT64 RVDA; ///< Offset 0x3BA Physical address of Raw > VBT data > + UINT32 RVDS; ///< Offset 0x3C2 Size of Raw VBT data > + UINT8 RM31[0x3A]; ///< Offset 0x3C6 - 0x3FF Reserved Must be > zero. > } IGD_OPREGION_MBOX3; >=20 > /// > -- > 2.18.0.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel