* [PATCH 0/4] Various Packages: add MM_STANDALONE support
@ 2019-01-16 21:22 Ard Biesheuvel
2019-01-16 21:22 ` [PATCH 1/4] CryptoPkg/SmmCryptLib: permit use by MM_STANDALONE modules Ard Biesheuvel
` (4 more replies)
0 siblings, 5 replies; 23+ messages in thread
From: Ard Biesheuvel @ 2019-01-16 21:22 UTC (permalink / raw)
To: edk2-devel
Cc: Ard Biesheuvel, Michael D Kinney, Liming Gao, Ting Ye, Gang Wei,
Jian Wang, Chao Zhang, Jiewen Yao, Hao Wu, Star Zeng, Achin Gupta,
Jagadeesh Ujja
Add MM_STANDALONE to the list of permitted module types of various
libraries that are required to build the standalone MM authenticated
variable stack.
In some cases, this requires the MODULE_TYPE to be modified to BASE,
given that the constructor prototype is different between DXE/UEFI
and MM_STANDALONE drivers.
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Ting Ye <ting.ye@intel.com>
Cc: Gang Wei <gang.wei@intel.com>
Cc: Jian Wang <jian.j.wang@intel.com>
Cc: Chao Zhang <chao.b.zhang@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Hao Wu <hao.a.wu@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Achin Gupta <achin.gupta@arm.com>
Cc: Jagadeesh Ujja <jagadeesh.ujja@arm.com>
Ard Biesheuvel (4):
CryptoPkg/SmmCryptLib: permit use by MM_STANDALONE modules
SecurityPkg/PlatformSecureLibNull: permit use by MM_STANDALONE modules
MdeModulePkg/VarCheckLib: permit use by MM_STANDALONE modules
MdePkg/UefiDevicePathLib: permit use by MM_STANDALONE modules
CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 2 +-
MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf | 4 ++--
.../Library/VarCheckUefiLib/VarCheckUefiLibNullClass.c | 9 +++++----
MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf | 2 +-
.../PlatformSecureLibNull/PlatformSecureLibNull.c | 9 +++++----
.../PlatformSecureLibNull/PlatformSecureLibNull.inf | 4 ++--
6 files changed, 16 insertions(+), 14 deletions(-)
--
2.17.1
^ permalink raw reply [flat|nested] 23+ messages in thread* [PATCH 1/4] CryptoPkg/SmmCryptLib: permit use by MM_STANDALONE modules 2019-01-16 21:22 [PATCH 0/4] Various Packages: add MM_STANDALONE support Ard Biesheuvel @ 2019-01-16 21:22 ` Ard Biesheuvel 2019-01-18 7:05 ` Wang, Jian J 2019-01-16 21:22 ` [PATCH 2/4] SecurityPkg/PlatformSecureLibNull: " Ard Biesheuvel ` (3 subsequent siblings) 4 siblings, 1 reply; 23+ messages in thread From: Ard Biesheuvel @ 2019-01-16 21:22 UTC (permalink / raw) To: edk2-devel Cc: Ard Biesheuvel, Michael D Kinney, Liming Gao, Ting Ye, Gang Wei, Jian Wang, Chao Zhang, Jiewen Yao, Hao Wu, Star Zeng, Achin Gupta, Jagadeesh Ujja Permit SmmCryptLib to be used by MM_STANDALONE modules Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> --- CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf index c34699cd62bf..a681fe2f36b8 100644 --- a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf +++ b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf @@ -30,7 +30,7 @@ [Defines] MODULE_TYPE = DXE_SMM_DRIVER VERSION_STRING = 1.0 PI_SPECIFICATION_VERSION = 0x0001000A - LIBRARY_CLASS = BaseCryptLib|DXE_SMM_DRIVER SMM_CORE + LIBRARY_CLASS = BaseCryptLib|DXE_SMM_DRIVER SMM_CORE MM_STANDALONE # # The following information is for reference only and not required by the build tools. -- 2.17.1 ^ permalink raw reply related [flat|nested] 23+ messages in thread
* Re: [PATCH 1/4] CryptoPkg/SmmCryptLib: permit use by MM_STANDALONE modules 2019-01-16 21:22 ` [PATCH 1/4] CryptoPkg/SmmCryptLib: permit use by MM_STANDALONE modules Ard Biesheuvel @ 2019-01-18 7:05 ` Wang, Jian J 2019-01-18 11:12 ` Ard Biesheuvel 0 siblings, 1 reply; 23+ messages in thread From: Wang, Jian J @ 2019-01-18 7:05 UTC (permalink / raw) To: Ard Biesheuvel, edk2-devel@lists.01.org Cc: Kinney, Michael D, Gao, Liming, Ye, Ting, Wei, Gang, Zhang, Chao B, Yao, Jiewen, Wu, Hao A, Zeng, Star, Achin Gupta, Jagadeesh Ujja Reviewed-by: Jian J Wang <jian.j.wang@intel.com> > -----Original Message----- > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > Sent: Thursday, January 17, 2019 5:22 AM > To: edk2-devel@lists.01.org > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Kinney, Michael D > <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; Ye, Ting > <ting.ye@intel.com>; Wei, Gang <gang.wei@intel.com>; Wang, Jian J > <jian.j.wang@intel.com>; Zhang, Chao B <chao.b.zhang@intel.com>; Yao, > Jiewen <jiewen.yao@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Zeng, Star > <star.zeng@intel.com>; Achin Gupta <achin.gupta@arm.com>; Jagadeesh Ujja > <jagadeesh.ujja@arm.com> > Subject: [PATCH 1/4] CryptoPkg/SmmCryptLib: permit use by MM_STANDALONE > modules > > Permit SmmCryptLib to be used by MM_STANDALONE modules > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > --- > CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > index c34699cd62bf..a681fe2f36b8 100644 > --- a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > +++ b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > @@ -30,7 +30,7 @@ [Defines] > MODULE_TYPE = DXE_SMM_DRIVER > VERSION_STRING = 1.0 > PI_SPECIFICATION_VERSION = 0x0001000A > - LIBRARY_CLASS = BaseCryptLib|DXE_SMM_DRIVER SMM_CORE > + LIBRARY_CLASS = BaseCryptLib|DXE_SMM_DRIVER SMM_CORE > MM_STANDALONE > > # > # The following information is for reference only and not required by the build > tools. > -- > 2.17.1 ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 1/4] CryptoPkg/SmmCryptLib: permit use by MM_STANDALONE modules 2019-01-18 7:05 ` Wang, Jian J @ 2019-01-18 11:12 ` Ard Biesheuvel 2019-01-21 12:36 ` Ard Biesheuvel 0 siblings, 1 reply; 23+ messages in thread From: Ard Biesheuvel @ 2019-01-18 11:12 UTC (permalink / raw) To: Wang, Jian J Cc: edk2-devel@lists.01.org, Kinney, Michael D, Gao, Liming, Ye, Ting, Wei, Gang, Zhang, Chao B, Yao, Jiewen, Wu, Hao A, Zeng, Star, Achin Gupta, Jagadeesh Ujja On Fri, 18 Jan 2019 at 08:08, Wang, Jian J <jian.j.wang@intel.com> wrote: > > > > Reviewed-by: Jian J Wang <jian.j.wang@intel.com> > Ting, do you have any objections to this patch? > > > -----Original Message----- > > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > > Sent: Thursday, January 17, 2019 5:22 AM > > To: edk2-devel@lists.01.org > > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Kinney, Michael D > > <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; Ye, Ting > > <ting.ye@intel.com>; Wei, Gang <gang.wei@intel.com>; Wang, Jian J > > <jian.j.wang@intel.com>; Zhang, Chao B <chao.b.zhang@intel.com>; Yao, > > Jiewen <jiewen.yao@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Zeng, Star > > <star.zeng@intel.com>; Achin Gupta <achin.gupta@arm.com>; Jagadeesh Ujja > > <jagadeesh.ujja@arm.com> > > Subject: [PATCH 1/4] CryptoPkg/SmmCryptLib: permit use by MM_STANDALONE > > modules > > > > Permit SmmCryptLib to be used by MM_STANDALONE modules > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > --- > > CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > > b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > > index c34699cd62bf..a681fe2f36b8 100644 > > --- a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > > +++ b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > > @@ -30,7 +30,7 @@ [Defines] > > MODULE_TYPE = DXE_SMM_DRIVER > > VERSION_STRING = 1.0 > > PI_SPECIFICATION_VERSION = 0x0001000A > > - LIBRARY_CLASS = BaseCryptLib|DXE_SMM_DRIVER SMM_CORE > > + LIBRARY_CLASS = BaseCryptLib|DXE_SMM_DRIVER SMM_CORE > > MM_STANDALONE > > > > # > > # The following information is for reference only and not required by the build > > tools. > > -- > > 2.17.1 > ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 1/4] CryptoPkg/SmmCryptLib: permit use by MM_STANDALONE modules 2019-01-18 11:12 ` Ard Biesheuvel @ 2019-01-21 12:36 ` Ard Biesheuvel 2019-01-21 12:40 ` Gao, Liming 0 siblings, 1 reply; 23+ messages in thread From: Ard Biesheuvel @ 2019-01-21 12:36 UTC (permalink / raw) To: Wang, Jian J, Ye, Ting Cc: edk2-devel@lists.01.org, Kinney, Michael D, Gao, Liming, Wei, Gang, Zhang, Chao B, Yao, Jiewen, Wu, Hao A, Zeng, Star, Achin Gupta, Jagadeesh Ujja On Fri, 18 Jan 2019 at 12:12, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote: > > On Fri, 18 Jan 2019 at 08:08, Wang, Jian J <jian.j.wang@intel.com> wrote: > > > > > > > > Reviewed-by: Jian J Wang <jian.j.wang@intel.com> > > > > Ting, do you have any objections to this patch? > Ping? > > > > > -----Original Message----- > > > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > > > Sent: Thursday, January 17, 2019 5:22 AM > > > To: edk2-devel@lists.01.org > > > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Kinney, Michael D > > > <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; Ye, Ting > > > <ting.ye@intel.com>; Wei, Gang <gang.wei@intel.com>; Wang, Jian J > > > <jian.j.wang@intel.com>; Zhang, Chao B <chao.b.zhang@intel.com>; Yao, > > > Jiewen <jiewen.yao@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Zeng, Star > > > <star.zeng@intel.com>; Achin Gupta <achin.gupta@arm.com>; Jagadeesh Ujja > > > <jagadeesh.ujja@arm.com> > > > Subject: [PATCH 1/4] CryptoPkg/SmmCryptLib: permit use by MM_STANDALONE > > > modules > > > > > > Permit SmmCryptLib to be used by MM_STANDALONE modules > > > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > > --- > > > CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > > > b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > > > index c34699cd62bf..a681fe2f36b8 100644 > > > --- a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > > > +++ b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > > > @@ -30,7 +30,7 @@ [Defines] > > > MODULE_TYPE = DXE_SMM_DRIVER > > > VERSION_STRING = 1.0 > > > PI_SPECIFICATION_VERSION = 0x0001000A > > > - LIBRARY_CLASS = BaseCryptLib|DXE_SMM_DRIVER SMM_CORE > > > + LIBRARY_CLASS = BaseCryptLib|DXE_SMM_DRIVER SMM_CORE > > > MM_STANDALONE > > > > > > # > > > # The following information is for reference only and not required by the build > > > tools. > > > -- > > > 2.17.1 > > ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 1/4] CryptoPkg/SmmCryptLib: permit use by MM_STANDALONE modules 2019-01-21 12:36 ` Ard Biesheuvel @ 2019-01-21 12:40 ` Gao, Liming 2019-01-21 12:40 ` Ard Biesheuvel 0 siblings, 1 reply; 23+ messages in thread From: Gao, Liming @ 2019-01-21 12:40 UTC (permalink / raw) To: Ard Biesheuvel, Wang, Jian J, Ye, Ting Cc: edk2-devel@lists.01.org, Kinney, Michael D, Wei, Gang, Zhang, Chao B, Yao, Jiewen, Wu, Hao A, Zeng, Star, Achin Gupta, Jagadeesh Ujja Ard: Wang, Jian is the reviewer of CryptoPkg. I think that his review-by is enough. Thanks Liming > -----Original Message----- > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > Sent: Monday, January 21, 2019 8:36 PM > To: Wang, Jian J <jian.j.wang@intel.com>; Ye, Ting <ting.ye@intel.com> > Cc: edk2-devel@lists.01.org; Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; Wei, Gang > <gang.wei@intel.com>; Zhang, Chao B <chao.b.zhang@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Wu, Hao A > <hao.a.wu@intel.com>; Zeng, Star <star.zeng@intel.com>; Achin Gupta <achin.gupta@arm.com>; Jagadeesh Ujja > <jagadeesh.ujja@arm.com> > Subject: Re: [PATCH 1/4] CryptoPkg/SmmCryptLib: permit use by MM_STANDALONE modules > > On Fri, 18 Jan 2019 at 12:12, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote: > > > > On Fri, 18 Jan 2019 at 08:08, Wang, Jian J <jian.j.wang@intel.com> wrote: > > > > > > > > > > > > Reviewed-by: Jian J Wang <jian.j.wang@intel.com> > > > > > > > Ting, do you have any objections to this patch? > > > > Ping? > > > > > > > > > > -----Original Message----- > > > > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > > > > Sent: Thursday, January 17, 2019 5:22 AM > > > > To: edk2-devel@lists.01.org > > > > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Kinney, Michael D > > > > <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; Ye, Ting > > > > <ting.ye@intel.com>; Wei, Gang <gang.wei@intel.com>; Wang, Jian J > > > > <jian.j.wang@intel.com>; Zhang, Chao B <chao.b.zhang@intel.com>; Yao, > > > > Jiewen <jiewen.yao@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Zeng, Star > > > > <star.zeng@intel.com>; Achin Gupta <achin.gupta@arm.com>; Jagadeesh Ujja > > > > <jagadeesh.ujja@arm.com> > > > > Subject: [PATCH 1/4] CryptoPkg/SmmCryptLib: permit use by MM_STANDALONE > > > > modules > > > > > > > > Permit SmmCryptLib to be used by MM_STANDALONE modules > > > > > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > > > --- > > > > CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > > > > b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > > > > index c34699cd62bf..a681fe2f36b8 100644 > > > > --- a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > > > > +++ b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > > > > @@ -30,7 +30,7 @@ [Defines] > > > > MODULE_TYPE = DXE_SMM_DRIVER > > > > VERSION_STRING = 1.0 > > > > PI_SPECIFICATION_VERSION = 0x0001000A > > > > - LIBRARY_CLASS = BaseCryptLib|DXE_SMM_DRIVER SMM_CORE > > > > + LIBRARY_CLASS = BaseCryptLib|DXE_SMM_DRIVER SMM_CORE > > > > MM_STANDALONE > > > > > > > > # > > > > # The following information is for reference only and not required by the build > > > > tools. > > > > -- > > > > 2.17.1 > > > ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 1/4] CryptoPkg/SmmCryptLib: permit use by MM_STANDALONE modules 2019-01-21 12:40 ` Gao, Liming @ 2019-01-21 12:40 ` Ard Biesheuvel 2019-01-22 2:42 ` Ye, Ting 0 siblings, 1 reply; 23+ messages in thread From: Ard Biesheuvel @ 2019-01-21 12:40 UTC (permalink / raw) To: Gao, Liming Cc: Wang, Jian J, Ye, Ting, edk2-devel@lists.01.org, Kinney, Michael D, Wei, Gang, Zhang, Chao B, Yao, Jiewen, Wu, Hao A, Zeng, Star, Achin Gupta, Jagadeesh Ujja On Mon, 21 Jan 2019 at 13:40, Gao, Liming <liming.gao@intel.com> wrote: > > Ard: > Wang, Jian is the reviewer of CryptoPkg. I think that his review-by is enough. > OK, thanks! > Thanks > Liming > > -----Original Message----- > > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > > Sent: Monday, January 21, 2019 8:36 PM > > To: Wang, Jian J <jian.j.wang@intel.com>; Ye, Ting <ting.ye@intel.com> > > Cc: edk2-devel@lists.01.org; Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; Wei, Gang > > <gang.wei@intel.com>; Zhang, Chao B <chao.b.zhang@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Wu, Hao A > > <hao.a.wu@intel.com>; Zeng, Star <star.zeng@intel.com>; Achin Gupta <achin.gupta@arm.com>; Jagadeesh Ujja > > <jagadeesh.ujja@arm.com> > > Subject: Re: [PATCH 1/4] CryptoPkg/SmmCryptLib: permit use by MM_STANDALONE modules > > > > On Fri, 18 Jan 2019 at 12:12, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote: > > > > > > On Fri, 18 Jan 2019 at 08:08, Wang, Jian J <jian.j.wang@intel.com> wrote: > > > > > > > > > > > > > > > > Reviewed-by: Jian J Wang <jian.j.wang@intel.com> > > > > > > > > > > Ting, do you have any objections to this patch? > > > > > > > Ping? > > > > > > > > > > > > > > > -----Original Message----- > > > > > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > > > > > Sent: Thursday, January 17, 2019 5:22 AM > > > > > To: edk2-devel@lists.01.org > > > > > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Kinney, Michael D > > > > > <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; Ye, Ting > > > > > <ting.ye@intel.com>; Wei, Gang <gang.wei@intel.com>; Wang, Jian J > > > > > <jian.j.wang@intel.com>; Zhang, Chao B <chao.b.zhang@intel.com>; Yao, > > > > > Jiewen <jiewen.yao@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Zeng, Star > > > > > <star.zeng@intel.com>; Achin Gupta <achin.gupta@arm.com>; Jagadeesh Ujja > > > > > <jagadeesh.ujja@arm.com> > > > > > Subject: [PATCH 1/4] CryptoPkg/SmmCryptLib: permit use by MM_STANDALONE > > > > > modules > > > > > > > > > > Permit SmmCryptLib to be used by MM_STANDALONE modules > > > > > > > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > > > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > > > > --- > > > > > CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 2 +- > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > diff --git a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > > > > > b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > > > > > index c34699cd62bf..a681fe2f36b8 100644 > > > > > --- a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > > > > > +++ b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > > > > > @@ -30,7 +30,7 @@ [Defines] > > > > > MODULE_TYPE = DXE_SMM_DRIVER > > > > > VERSION_STRING = 1.0 > > > > > PI_SPECIFICATION_VERSION = 0x0001000A > > > > > - LIBRARY_CLASS = BaseCryptLib|DXE_SMM_DRIVER SMM_CORE > > > > > + LIBRARY_CLASS = BaseCryptLib|DXE_SMM_DRIVER SMM_CORE > > > > > MM_STANDALONE > > > > > > > > > > # > > > > > # The following information is for reference only and not required by the build > > > > > tools. > > > > > -- > > > > > 2.17.1 > > > > ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 1/4] CryptoPkg/SmmCryptLib: permit use by MM_STANDALONE modules 2019-01-21 12:40 ` Ard Biesheuvel @ 2019-01-22 2:42 ` Ye, Ting 0 siblings, 0 replies; 23+ messages in thread From: Ye, Ting @ 2019-01-22 2:42 UTC (permalink / raw) To: Ard Biesheuvel, Gao, Liming Cc: Wang, Jian J, edk2-devel@lists.01.org, Kinney, Michael D, Wei, Gang, Zhang, Chao B, Yao, Jiewen, Wu, Hao A, Zeng, Star, Achin Gupta, Jagadeesh Ujja Yes. No objections from me. Sorry for missed the previous mail. Thanks, Ting -----Original Message----- From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] Sent: Monday, January 21, 2019 8:41 PM To: Gao, Liming <liming.gao@intel.com> Cc: Wang, Jian J <jian.j.wang@intel.com>; Ye, Ting <ting.ye@intel.com>; edk2-devel@lists.01.org; Kinney, Michael D <michael.d.kinney@intel.com>; Wei, Gang <gang.wei@intel.com>; Zhang, Chao B <chao.b.zhang@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Zeng, Star <star.zeng@intel.com>; Achin Gupta <achin.gupta@arm.com>; Jagadeesh Ujja <jagadeesh.ujja@arm.com> Subject: Re: [PATCH 1/4] CryptoPkg/SmmCryptLib: permit use by MM_STANDALONE modules On Mon, 21 Jan 2019 at 13:40, Gao, Liming <liming.gao@intel.com> wrote: > > Ard: > Wang, Jian is the reviewer of CryptoPkg. I think that his review-by is enough. > OK, thanks! > Thanks > Liming > > -----Original Message----- > > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > > Sent: Monday, January 21, 2019 8:36 PM > > To: Wang, Jian J <jian.j.wang@intel.com>; Ye, Ting > > <ting.ye@intel.com> > > Cc: edk2-devel@lists.01.org; Kinney, Michael D > > <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; > > Wei, Gang <gang.wei@intel.com>; Zhang, Chao B > > <chao.b.zhang@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Wu, > > Hao A <hao.a.wu@intel.com>; Zeng, Star <star.zeng@intel.com>; Achin > > Gupta <achin.gupta@arm.com>; Jagadeesh Ujja <jagadeesh.ujja@arm.com> > > Subject: Re: [PATCH 1/4] CryptoPkg/SmmCryptLib: permit use by > > MM_STANDALONE modules > > > > On Fri, 18 Jan 2019 at 12:12, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote: > > > > > > On Fri, 18 Jan 2019 at 08:08, Wang, Jian J <jian.j.wang@intel.com> wrote: > > > > > > > > > > > > > > > > Reviewed-by: Jian J Wang <jian.j.wang@intel.com> > > > > > > > > > > Ting, do you have any objections to this patch? > > > > > > > Ping? > > > > > > > > > > > > > > > -----Original Message----- > > > > > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > > > > > Sent: Thursday, January 17, 2019 5:22 AM > > > > > To: edk2-devel@lists.01.org > > > > > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Kinney, > > > > > Michael D <michael.d.kinney@intel.com>; Gao, Liming > > > > > <liming.gao@intel.com>; Ye, Ting <ting.ye@intel.com>; Wei, > > > > > Gang <gang.wei@intel.com>; Wang, Jian J > > > > > <jian.j.wang@intel.com>; Zhang, Chao B > > > > > <chao.b.zhang@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; > > > > > Wu, Hao A <hao.a.wu@intel.com>; Zeng, Star > > > > > <star.zeng@intel.com>; Achin Gupta <achin.gupta@arm.com>; > > > > > Jagadeesh Ujja <jagadeesh.ujja@arm.com> > > > > > Subject: [PATCH 1/4] CryptoPkg/SmmCryptLib: permit use by > > > > > MM_STANDALONE modules > > > > > > > > > > Permit SmmCryptLib to be used by MM_STANDALONE modules > > > > > > > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > > > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > > > > --- > > > > > CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 2 +- > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > diff --git a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > > > > > b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > > > > > index c34699cd62bf..a681fe2f36b8 100644 > > > > > --- a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > > > > > +++ b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > > > > > @@ -30,7 +30,7 @@ [Defines] > > > > > MODULE_TYPE = DXE_SMM_DRIVER > > > > > VERSION_STRING = 1.0 > > > > > PI_SPECIFICATION_VERSION = 0x0001000A > > > > > - LIBRARY_CLASS = BaseCryptLib|DXE_SMM_DRIVER SMM_CORE > > > > > + LIBRARY_CLASS = BaseCryptLib|DXE_SMM_DRIVER SMM_CORE > > > > > MM_STANDALONE > > > > > > > > > > # > > > > > # The following information is for reference only and not > > > > > required by the build tools. > > > > > -- > > > > > 2.17.1 > > > > ^ permalink raw reply [flat|nested] 23+ messages in thread
* [PATCH 2/4] SecurityPkg/PlatformSecureLibNull: permit use by MM_STANDALONE modules 2019-01-16 21:22 [PATCH 0/4] Various Packages: add MM_STANDALONE support Ard Biesheuvel 2019-01-16 21:22 ` [PATCH 1/4] CryptoPkg/SmmCryptLib: permit use by MM_STANDALONE modules Ard Biesheuvel @ 2019-01-16 21:22 ` Ard Biesheuvel 2019-01-18 7:06 ` Wang, Jian J 2019-01-16 21:22 ` [PATCH 3/4] MdeModulePkg/VarCheckLib: " Ard Biesheuvel ` (2 subsequent siblings) 4 siblings, 1 reply; 23+ messages in thread From: Ard Biesheuvel @ 2019-01-16 21:22 UTC (permalink / raw) To: edk2-devel Cc: Ard Biesheuvel, Michael D Kinney, Liming Gao, Ting Ye, Gang Wei, Jian Wang, Chao Zhang, Jiewen Yao, Hao Wu, Star Zeng, Achin Gupta, Jagadeesh Ujja Add MM_STANDALONE to the list of module types that are permitted to link to this library. Also, since the constructor prototype is different between MM_STANDALONE and DXE_DRIVER type libraries, convert the library into BASE type. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> --- SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.c | 9 +++++---- SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.inf | 4 ++-- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.c b/SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.c index 0c6ded22f3e6..b2493a029393 100644 --- a/SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.c +++ b/SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.c @@ -15,6 +15,8 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. **/ +#include <Uefi/UefiBaseType.h> + BOOLEAN mUserPhysicalPresence = FALSE; /** @@ -53,15 +55,14 @@ UserPhysicalPresent ( @retval EFI_SUCCESS PcdUserPhysicalPresence is got successfully. **/ -EFI_STATUS +RETURN_STATUS EFIAPI PlatformSecureLibNullConstructor ( - IN EFI_HANDLE ImageHandle, - IN EFI_SYSTEM_TABLE *SystemTable + VOID ) { mUserPhysicalPresence = PcdGetBool(PcdUserPhysicalPresence); - return EFI_SUCCESS; + return RETURN_SUCCESS; } diff --git a/SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.inf b/SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.inf index 979a33705de0..70051a27a0a9 100644 --- a/SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.inf +++ b/SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.inf @@ -21,9 +21,9 @@ [Defines] BASE_NAME = PlatformSecureLibNull MODULE_UNI_FILE = PlatformSecureLibNull.uni FILE_GUID = 7FA68D82-10A4-4e71-9524-D3D9500D3CDF - MODULE_TYPE = DXE_DRIVER + MODULE_TYPE = BASE VERSION_STRING = 1.0 - LIBRARY_CLASS = PlatformSecureLib|DXE_RUNTIME_DRIVER DXE_SMM_DRIVER DXE_DRIVER + LIBRARY_CLASS = PlatformSecureLib|DXE_RUNTIME_DRIVER DXE_SMM_DRIVER DXE_DRIVER MM_STANDALONE CONSTRUCTOR = PlatformSecureLibNullConstructor # -- 2.17.1 ^ permalink raw reply related [flat|nested] 23+ messages in thread
* Re: [PATCH 2/4] SecurityPkg/PlatformSecureLibNull: permit use by MM_STANDALONE modules 2019-01-16 21:22 ` [PATCH 2/4] SecurityPkg/PlatformSecureLibNull: " Ard Biesheuvel @ 2019-01-18 7:06 ` Wang, Jian J 2019-01-18 11:13 ` Ard Biesheuvel 0 siblings, 1 reply; 23+ messages in thread From: Wang, Jian J @ 2019-01-18 7:06 UTC (permalink / raw) To: Ard Biesheuvel, edk2-devel@lists.01.org Cc: Kinney, Michael D, Gao, Liming, Ye, Ting, Wei, Gang, Zhang, Chao B, Yao, Jiewen, Wu, Hao A, Zeng, Star, Achin Gupta, Jagadeesh Ujja Reviewed-by: Jian J Wang <jian.j.wang@intel.com> > -----Original Message----- > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > Sent: Thursday, January 17, 2019 5:22 AM > To: edk2-devel@lists.01.org > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Kinney, Michael D > <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; Ye, Ting > <ting.ye@intel.com>; Wei, Gang <gang.wei@intel.com>; Wang, Jian J > <jian.j.wang@intel.com>; Zhang, Chao B <chao.b.zhang@intel.com>; Yao, > Jiewen <jiewen.yao@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Zeng, Star > <star.zeng@intel.com>; Achin Gupta <achin.gupta@arm.com>; Jagadeesh Ujja > <jagadeesh.ujja@arm.com> > Subject: [PATCH 2/4] SecurityPkg/PlatformSecureLibNull: permit use by > MM_STANDALONE modules > > Add MM_STANDALONE to the list of module types that are permitted to > link to this library. Also, since the constructor prototype is > different between MM_STANDALONE and DXE_DRIVER type libraries, > convert the library into BASE type. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > --- > SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.c | 9 +++++- > --- > SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.inf | 4 ++-- > 2 files changed, 7 insertions(+), 6 deletions(-) > > diff --git a/SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.c > b/SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.c > index 0c6ded22f3e6..b2493a029393 100644 > --- a/SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.c > +++ b/SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.c > @@ -15,6 +15,8 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY > KIND, EITHER EXPRESS OR IMPLIED. > > **/ > > +#include <Uefi/UefiBaseType.h> > + > BOOLEAN mUserPhysicalPresence = FALSE; > > /** > @@ -53,15 +55,14 @@ UserPhysicalPresent ( > @retval EFI_SUCCESS PcdUserPhysicalPresence is got successfully. > > **/ > -EFI_STATUS > +RETURN_STATUS > EFIAPI > PlatformSecureLibNullConstructor ( > - IN EFI_HANDLE ImageHandle, > - IN EFI_SYSTEM_TABLE *SystemTable > + VOID > ) > { > > mUserPhysicalPresence = PcdGetBool(PcdUserPhysicalPresence); > > - return EFI_SUCCESS; > + return RETURN_SUCCESS; > } > diff --git a/SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.inf > b/SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.inf > index 979a33705de0..70051a27a0a9 100644 > --- a/SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.inf > +++ b/SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.inf > @@ -21,9 +21,9 @@ [Defines] > BASE_NAME = PlatformSecureLibNull > MODULE_UNI_FILE = PlatformSecureLibNull.uni > FILE_GUID = 7FA68D82-10A4-4e71-9524-D3D9500D3CDF > - MODULE_TYPE = DXE_DRIVER > + MODULE_TYPE = BASE > VERSION_STRING = 1.0 > - LIBRARY_CLASS = PlatformSecureLib|DXE_RUNTIME_DRIVER > DXE_SMM_DRIVER DXE_DRIVER > + LIBRARY_CLASS = PlatformSecureLib|DXE_RUNTIME_DRIVER > DXE_SMM_DRIVER DXE_DRIVER MM_STANDALONE > CONSTRUCTOR = PlatformSecureLibNullConstructor > > # > -- > 2.17.1 ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 2/4] SecurityPkg/PlatformSecureLibNull: permit use by MM_STANDALONE modules 2019-01-18 7:06 ` Wang, Jian J @ 2019-01-18 11:13 ` Ard Biesheuvel 2019-01-18 15:01 ` Yao, Jiewen 0 siblings, 1 reply; 23+ messages in thread From: Ard Biesheuvel @ 2019-01-18 11:13 UTC (permalink / raw) To: Wang, Jian J Cc: edk2-devel@lists.01.org, Kinney, Michael D, Gao, Liming, Ye, Ting, Wei, Gang, Zhang, Chao B, Yao, Jiewen, Wu, Hao A, Zeng, Star, Achin Gupta, Jagadeesh Ujja On Fri, 18 Jan 2019 at 08:06, Wang, Jian J <jian.j.wang@intel.com> wrote: > > > > Reviewed-by: Jian J Wang <jian.j.wang@intel.com> > Chao, Jiewen, do you have any objections to this patch? > > > -----Original Message----- > > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > > Sent: Thursday, January 17, 2019 5:22 AM > > To: edk2-devel@lists.01.org > > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Kinney, Michael D > > <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; Ye, Ting > > <ting.ye@intel.com>; Wei, Gang <gang.wei@intel.com>; Wang, Jian J > > <jian.j.wang@intel.com>; Zhang, Chao B <chao.b.zhang@intel.com>; Yao, > > Jiewen <jiewen.yao@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Zeng, Star > > <star.zeng@intel.com>; Achin Gupta <achin.gupta@arm.com>; Jagadeesh Ujja > > <jagadeesh.ujja@arm.com> > > Subject: [PATCH 2/4] SecurityPkg/PlatformSecureLibNull: permit use by > > MM_STANDALONE modules > > > > Add MM_STANDALONE to the list of module types that are permitted to > > link to this library. Also, since the constructor prototype is > > different between MM_STANDALONE and DXE_DRIVER type libraries, > > convert the library into BASE type. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > --- > > SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.c | 9 +++++- > > --- > > SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.inf | 4 ++-- > > 2 files changed, 7 insertions(+), 6 deletions(-) > > > > diff --git a/SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.c > > b/SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.c > > index 0c6ded22f3e6..b2493a029393 100644 > > --- a/SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.c > > +++ b/SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.c > > @@ -15,6 +15,8 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY > > KIND, EITHER EXPRESS OR IMPLIED. > > > > **/ > > > > +#include <Uefi/UefiBaseType.h> > > + > > BOOLEAN mUserPhysicalPresence = FALSE; > > > > /** > > @@ -53,15 +55,14 @@ UserPhysicalPresent ( > > @retval EFI_SUCCESS PcdUserPhysicalPresence is got successfully. > > > > **/ > > -EFI_STATUS > > +RETURN_STATUS > > EFIAPI > > PlatformSecureLibNullConstructor ( > > - IN EFI_HANDLE ImageHandle, > > - IN EFI_SYSTEM_TABLE *SystemTable > > + VOID > > ) > > { > > > > mUserPhysicalPresence = PcdGetBool(PcdUserPhysicalPresence); > > > > - return EFI_SUCCESS; > > + return RETURN_SUCCESS; > > } > > diff --git a/SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.inf > > b/SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.inf > > index 979a33705de0..70051a27a0a9 100644 > > --- a/SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.inf > > +++ b/SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.inf > > @@ -21,9 +21,9 @@ [Defines] > > BASE_NAME = PlatformSecureLibNull > > MODULE_UNI_FILE = PlatformSecureLibNull.uni > > FILE_GUID = 7FA68D82-10A4-4e71-9524-D3D9500D3CDF > > - MODULE_TYPE = DXE_DRIVER > > + MODULE_TYPE = BASE > > VERSION_STRING = 1.0 > > - LIBRARY_CLASS = PlatformSecureLib|DXE_RUNTIME_DRIVER > > DXE_SMM_DRIVER DXE_DRIVER > > + LIBRARY_CLASS = PlatformSecureLib|DXE_RUNTIME_DRIVER > > DXE_SMM_DRIVER DXE_DRIVER MM_STANDALONE > > CONSTRUCTOR = PlatformSecureLibNullConstructor > > > > # > > -- > > 2.17.1 > ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 2/4] SecurityPkg/PlatformSecureLibNull: permit use by MM_STANDALONE modules 2019-01-18 11:13 ` Ard Biesheuvel @ 2019-01-18 15:01 ` Yao, Jiewen 0 siblings, 0 replies; 23+ messages in thread From: Yao, Jiewen @ 2019-01-18 15:01 UTC (permalink / raw) To: Ard Biesheuvel, Wang, Jian J Cc: edk2-devel@lists.01.org, Kinney, Michael D, Gao, Liming, Ye, Ting, Wei, Gang, Zhang, Chao B, Wu, Hao A, Zeng, Star, Achin Gupta, Jagadeesh Ujja Reviewed-by: Jiewen.yao@intel.com > -----Original Message----- > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > Sent: Friday, January 18, 2019 3:13 AM > To: Wang, Jian J <jian.j.wang@intel.com> > Cc: edk2-devel@lists.01.org; Kinney, Michael D > <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; Ye, > Ting <ting.ye@intel.com>; Wei, Gang <gang.wei@intel.com>; Zhang, Chao B > <chao.b.zhang@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Wu, Hao > A <hao.a.wu@intel.com>; Zeng, Star <star.zeng@intel.com>; Achin Gupta > <achin.gupta@arm.com>; Jagadeesh Ujja <jagadeesh.ujja@arm.com> > Subject: Re: [PATCH 2/4] SecurityPkg/PlatformSecureLibNull: permit use by > MM_STANDALONE modules > > On Fri, 18 Jan 2019 at 08:06, Wang, Jian J <jian.j.wang@intel.com> wrote: > > > > > > > > Reviewed-by: Jian J Wang <jian.j.wang@intel.com> > > > > Chao, Jiewen, do you have any objections to this patch? > > > > > > -----Original Message----- > > > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > > > Sent: Thursday, January 17, 2019 5:22 AM > > > To: edk2-devel@lists.01.org > > > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Kinney, Michael D > > > <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; Ye, > Ting > > > <ting.ye@intel.com>; Wei, Gang <gang.wei@intel.com>; Wang, Jian J > > > <jian.j.wang@intel.com>; Zhang, Chao B <chao.b.zhang@intel.com>; > Yao, > > > Jiewen <jiewen.yao@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; > Zeng, Star > > > <star.zeng@intel.com>; Achin Gupta <achin.gupta@arm.com>; > Jagadeesh Ujja > > > <jagadeesh.ujja@arm.com> > > > Subject: [PATCH 2/4] SecurityPkg/PlatformSecureLibNull: permit use by > > > MM_STANDALONE modules > > > > > > Add MM_STANDALONE to the list of module types that are permitted to > > > link to this library. Also, since the constructor prototype is > > > different between MM_STANDALONE and DXE_DRIVER type libraries, > > > convert the library into BASE type. > > > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > > --- > > > SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.c > | 9 +++++- > > > --- > > > SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.inf | > 4 ++-- > > > 2 files changed, 7 insertions(+), 6 deletions(-) > > > > > > diff --git > a/SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.c > > > b/SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.c > > > index 0c6ded22f3e6..b2493a029393 100644 > > > --- a/SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.c > > > +++ > b/SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.c > > > @@ -15,6 +15,8 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF > ANY > > > KIND, EITHER EXPRESS OR IMPLIED. > > > > > > **/ > > > > > > +#include <Uefi/UefiBaseType.h> > > > + > > > BOOLEAN mUserPhysicalPresence = FALSE; > > > > > > /** > > > @@ -53,15 +55,14 @@ UserPhysicalPresent ( > > > @retval EFI_SUCCESS PcdUserPhysicalPresence is got > successfully. > > > > > > **/ > > > -EFI_STATUS > > > +RETURN_STATUS > > > EFIAPI > > > PlatformSecureLibNullConstructor ( > > > - IN EFI_HANDLE ImageHandle, > > > - IN EFI_SYSTEM_TABLE *SystemTable > > > + VOID > > > ) > > > { > > > > > > mUserPhysicalPresence = PcdGetBool(PcdUserPhysicalPresence); > > > > > > - return EFI_SUCCESS; > > > + return RETURN_SUCCESS; > > > } > > > diff --git > a/SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.inf > > > b/SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.inf > > > index 979a33705de0..70051a27a0a9 100644 > > > --- > a/SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.inf > > > +++ > b/SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.inf > > > @@ -21,9 +21,9 @@ [Defines] > > > BASE_NAME = PlatformSecureLibNull > > > MODULE_UNI_FILE = PlatformSecureLibNull.uni > > > FILE_GUID = > 7FA68D82-10A4-4e71-9524-D3D9500D3CDF > > > - MODULE_TYPE = DXE_DRIVER > > > + MODULE_TYPE = BASE > > > VERSION_STRING = 1.0 > > > - LIBRARY_CLASS = > PlatformSecureLib|DXE_RUNTIME_DRIVER > > > DXE_SMM_DRIVER DXE_DRIVER > > > + LIBRARY_CLASS = > PlatformSecureLib|DXE_RUNTIME_DRIVER > > > DXE_SMM_DRIVER DXE_DRIVER MM_STANDALONE > > > CONSTRUCTOR = > PlatformSecureLibNullConstructor > > > > > > # > > > -- > > > 2.17.1 > > ^ permalink raw reply [flat|nested] 23+ messages in thread
* [PATCH 3/4] MdeModulePkg/VarCheckLib: permit use by MM_STANDALONE modules 2019-01-16 21:22 [PATCH 0/4] Various Packages: add MM_STANDALONE support Ard Biesheuvel 2019-01-16 21:22 ` [PATCH 1/4] CryptoPkg/SmmCryptLib: permit use by MM_STANDALONE modules Ard Biesheuvel 2019-01-16 21:22 ` [PATCH 2/4] SecurityPkg/PlatformSecureLibNull: " Ard Biesheuvel @ 2019-01-16 21:22 ` Ard Biesheuvel 2019-01-18 7:06 ` Wang, Jian J 2019-01-18 8:15 ` Zeng, Star 2019-01-16 21:22 ` [PATCH 4/4] MdePkg/UefiDevicePathLib: " Ard Biesheuvel 2019-01-21 12:43 ` [PATCH 0/4] Various Packages: add MM_STANDALONE support Ard Biesheuvel 4 siblings, 2 replies; 23+ messages in thread From: Ard Biesheuvel @ 2019-01-16 21:22 UTC (permalink / raw) To: edk2-devel Cc: Ard Biesheuvel, Michael D Kinney, Liming Gao, Ting Ye, Gang Wei, Jian Wang, Chao Zhang, Jiewen Yao, Hao Wu, Star Zeng, Achin Gupta, Jagadeesh Ujja Permit VarCheckLib and VarCheckUefiLib to be used by MM_STANDALONE modules. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> --- MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf | 4 ++-- MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLibNullClass.c | 9 +++++---- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf b/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf index 128c44d695e1..8873fd51a02a 100644 --- a/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf +++ b/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf @@ -19,9 +19,9 @@ [Defines] BASE_NAME = VarCheckUefiLib MODULE_UNI_FILE = VarCheckUefiLib.uni FILE_GUID = AC24A4C7-F845-4665-90E5-6431D6E28DC0 - MODULE_TYPE = DXE_RUNTIME_DRIVER + MODULE_TYPE = BASE VERSION_STRING = 1.0 - LIBRARY_CLASS = NULL|DXE_RUNTIME_DRIVER DXE_SMM_DRIVER + LIBRARY_CLASS = NULL|DXE_RUNTIME_DRIVER DXE_SMM_DRIVER MM_STANDALONE CONSTRUCTOR = VarCheckUefiLibNullClassConstructor # diff --git a/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLibNullClass.c b/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLibNullClass.c index 80dc6341adcf..5e419831e8cc 100644 --- a/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLibNullClass.c +++ b/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLibNullClass.c @@ -12,6 +12,8 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. **/ +#include <Uefi/UefiBaseType.h> + #include <Library/VarCheckLib.h> #include <Library/BaseLib.h> #include <Library/BaseMemoryLib.h> @@ -927,15 +929,14 @@ VariablePropertySetUefiDefined ( @retval EFI_SUCCESS The constructor executed correctly. **/ -EFI_STATUS +RETURN_STATUS EFIAPI VarCheckUefiLibNullClassConstructor ( - IN EFI_HANDLE ImageHandle, - IN EFI_SYSTEM_TABLE *SystemTable + VOID ) { VariablePropertySetUefiDefined (); VarCheckLibRegisterSetVariableCheckHandler (SetVariableCheckHandlerUefiDefined); - return EFI_SUCCESS; + return RETURN_SUCCESS; } -- 2.17.1 ^ permalink raw reply related [flat|nested] 23+ messages in thread
* Re: [PATCH 3/4] MdeModulePkg/VarCheckLib: permit use by MM_STANDALONE modules 2019-01-16 21:22 ` [PATCH 3/4] MdeModulePkg/VarCheckLib: " Ard Biesheuvel @ 2019-01-18 7:06 ` Wang, Jian J 2019-01-18 8:15 ` Zeng, Star 1 sibling, 0 replies; 23+ messages in thread From: Wang, Jian J @ 2019-01-18 7:06 UTC (permalink / raw) To: Ard Biesheuvel, edk2-devel@lists.01.org Cc: Kinney, Michael D, Gao, Liming, Ye, Ting, Wei, Gang, Zhang, Chao B, Yao, Jiewen, Wu, Hao A, Zeng, Star, Achin Gupta, Jagadeesh Ujja Reviewed-by: Jian J Wang <jian.j.wang@intel.com> > -----Original Message----- > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > Sent: Thursday, January 17, 2019 5:22 AM > To: edk2-devel@lists.01.org > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Kinney, Michael D > <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; Ye, Ting > <ting.ye@intel.com>; Wei, Gang <gang.wei@intel.com>; Wang, Jian J > <jian.j.wang@intel.com>; Zhang, Chao B <chao.b.zhang@intel.com>; Yao, > Jiewen <jiewen.yao@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Zeng, Star > <star.zeng@intel.com>; Achin Gupta <achin.gupta@arm.com>; Jagadeesh Ujja > <jagadeesh.ujja@arm.com> > Subject: [PATCH 3/4] MdeModulePkg/VarCheckLib: permit use by > MM_STANDALONE modules > > Permit VarCheckLib and VarCheckUefiLib to be used by MM_STANDALONE > modules. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > --- > MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf | 4 ++-- > MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLibNullClass.c | 9 > +++++---- > 2 files changed, 7 insertions(+), 6 deletions(-) > > diff --git a/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf > b/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf > index 128c44d695e1..8873fd51a02a 100644 > --- a/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf > +++ b/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf > @@ -19,9 +19,9 @@ [Defines] > BASE_NAME = VarCheckUefiLib > MODULE_UNI_FILE = VarCheckUefiLib.uni > FILE_GUID = AC24A4C7-F845-4665-90E5-6431D6E28DC0 > - MODULE_TYPE = DXE_RUNTIME_DRIVER > + MODULE_TYPE = BASE > VERSION_STRING = 1.0 > - LIBRARY_CLASS = NULL|DXE_RUNTIME_DRIVER DXE_SMM_DRIVER > + LIBRARY_CLASS = NULL|DXE_RUNTIME_DRIVER DXE_SMM_DRIVER > MM_STANDALONE > CONSTRUCTOR = VarCheckUefiLibNullClassConstructor > > # > diff --git a/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLibNullClass.c > b/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLibNullClass.c > index 80dc6341adcf..5e419831e8cc 100644 > --- a/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLibNullClass.c > +++ b/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLibNullClass.c > @@ -12,6 +12,8 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY > KIND, EITHER EXPRESS OR IMPLIED. > > **/ > > +#include <Uefi/UefiBaseType.h> > + > #include <Library/VarCheckLib.h> > #include <Library/BaseLib.h> > #include <Library/BaseMemoryLib.h> > @@ -927,15 +929,14 @@ VariablePropertySetUefiDefined ( > @retval EFI_SUCCESS The constructor executed correctly. > > **/ > -EFI_STATUS > +RETURN_STATUS > EFIAPI > VarCheckUefiLibNullClassConstructor ( > - IN EFI_HANDLE ImageHandle, > - IN EFI_SYSTEM_TABLE *SystemTable > + VOID > ) > { > VariablePropertySetUefiDefined (); > VarCheckLibRegisterSetVariableCheckHandler > (SetVariableCheckHandlerUefiDefined); > > - return EFI_SUCCESS; > + return RETURN_SUCCESS; > } > -- > 2.17.1 ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 3/4] MdeModulePkg/VarCheckLib: permit use by MM_STANDALONE modules 2019-01-16 21:22 ` [PATCH 3/4] MdeModulePkg/VarCheckLib: " Ard Biesheuvel 2019-01-18 7:06 ` Wang, Jian J @ 2019-01-18 8:15 ` Zeng, Star 2019-01-18 10:45 ` Zeng, Star 1 sibling, 1 reply; 23+ messages in thread From: Zeng, Star @ 2019-01-18 8:15 UTC (permalink / raw) To: Ard Biesheuvel, edk2-devel@lists.01.org Cc: Kinney, Michael D, Gao, Liming, Ye, Ting, Wei, Gang, Wang, Jian J, Zhang, Chao B, Yao, Jiewen, Wu, Hao A, Achin Gupta, Jagadeesh Ujja, Zeng, Star This patch does not touch VarCheckLib at all, but only touch VarCheckUefiLib, so the title and commit message need be updated. With them updated correctly, Reviewed-by: Star Zeng <star.zeng@intel.com>. Thanks, Star -----Original Message----- From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] Sent: Thursday, January 17, 2019 5:22 AM To: edk2-devel@lists.01.org Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; Ye, Ting <ting.ye@intel.com>; Wei, Gang <gang.wei@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Zhang, Chao B <chao.b.zhang@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Zeng, Star <star.zeng@intel.com>; Achin Gupta <achin.gupta@arm.com>; Jagadeesh Ujja <jagadeesh.ujja@arm.com> Subject: [PATCH 3/4] MdeModulePkg/VarCheckLib: permit use by MM_STANDALONE modules Permit VarCheckLib and VarCheckUefiLib to be used by MM_STANDALONE modules. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> --- MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf | 4 ++-- MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLibNullClass.c | 9 +++++---- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf b/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf index 128c44d695e1..8873fd51a02a 100644 --- a/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf +++ b/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf @@ -19,9 +19,9 @@ [Defines] BASE_NAME = VarCheckUefiLib MODULE_UNI_FILE = VarCheckUefiLib.uni FILE_GUID = AC24A4C7-F845-4665-90E5-6431D6E28DC0 - MODULE_TYPE = DXE_RUNTIME_DRIVER + MODULE_TYPE = BASE VERSION_STRING = 1.0 - LIBRARY_CLASS = NULL|DXE_RUNTIME_DRIVER DXE_SMM_DRIVER + LIBRARY_CLASS = NULL|DXE_RUNTIME_DRIVER DXE_SMM_DRIVER MM_STANDALONE CONSTRUCTOR = VarCheckUefiLibNullClassConstructor # diff --git a/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLibNullClass.c b/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLibNullClass.c index 80dc6341adcf..5e419831e8cc 100644 --- a/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLibNullClass.c +++ b/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLibNullClass.c @@ -12,6 +12,8 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. **/ +#include <Uefi/UefiBaseType.h> + #include <Library/VarCheckLib.h> #include <Library/BaseLib.h> #include <Library/BaseMemoryLib.h> @@ -927,15 +929,14 @@ VariablePropertySetUefiDefined ( @retval EFI_SUCCESS The constructor executed correctly. **/ -EFI_STATUS +RETURN_STATUS EFIAPI VarCheckUefiLibNullClassConstructor ( - IN EFI_HANDLE ImageHandle, - IN EFI_SYSTEM_TABLE *SystemTable + VOID ) { VariablePropertySetUefiDefined (); VarCheckLibRegisterSetVariableCheckHandler (SetVariableCheckHandlerUefiDefined); - return EFI_SUCCESS; + return RETURN_SUCCESS; } -- 2.17.1 ^ permalink raw reply related [flat|nested] 23+ messages in thread
* Re: [PATCH 3/4] MdeModulePkg/VarCheckLib: permit use by MM_STANDALONE modules 2019-01-18 8:15 ` Zeng, Star @ 2019-01-18 10:45 ` Zeng, Star 0 siblings, 0 replies; 23+ messages in thread From: Zeng, Star @ 2019-01-18 10:45 UTC (permalink / raw) To: Ard Biesheuvel, edk2-devel@lists.01.org Cc: Kinney, Michael D, Gao, Liming, Ye, Ting, Wei, Gang, Wang, Jian J, Zhang, Chao B, Yao, Jiewen, Wu, Hao A, Achin Gupta, Jagadeesh Ujja, Zeng, Star Anther, the parameters of constructor are removed, so their descriptions in function header also need to be cleaned up. Same comment to patch 2. With them fixed, Reviewed-by: Star Zeng <star.zeng@intel.com> to the series. Thanks, Star -----Original Message----- From: Zeng, Star Sent: Friday, January 18, 2019 4:15 PM To: Ard Biesheuvel <ard.biesheuvel@linaro.org>; edk2-devel@lists.01.org Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; Ye, Ting <ting.ye@intel.com>; Wei, Gang <gang.wei@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Zhang, Chao B <chao.b.zhang@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Achin Gupta <achin.gupta@arm.com>; Jagadeesh Ujja <jagadeesh.ujja@arm.com>; Zeng, Star <star.zeng@intel.com> Subject: RE: [PATCH 3/4] MdeModulePkg/VarCheckLib: permit use by MM_STANDALONE modules This patch does not touch VarCheckLib at all, but only touch VarCheckUefiLib, so the title and commit message need be updated. With them updated correctly, Reviewed-by: Star Zeng <star.zeng@intel.com>. Thanks, Star -----Original Message----- From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] Sent: Thursday, January 17, 2019 5:22 AM To: edk2-devel@lists.01.org Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; Ye, Ting <ting.ye@intel.com>; Wei, Gang <gang.wei@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Zhang, Chao B <chao.b.zhang@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Zeng, Star <star.zeng@intel.com>; Achin Gupta <achin.gupta@arm.com>; Jagadeesh Ujja <jagadeesh.ujja@arm.com> Subject: [PATCH 3/4] MdeModulePkg/VarCheckLib: permit use by MM_STANDALONE modules Permit VarCheckLib and VarCheckUefiLib to be used by MM_STANDALONE modules. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> --- MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf | 4 ++-- MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLibNullClass.c | 9 +++++---- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf b/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf index 128c44d695e1..8873fd51a02a 100644 --- a/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf +++ b/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf @@ -19,9 +19,9 @@ [Defines] BASE_NAME = VarCheckUefiLib MODULE_UNI_FILE = VarCheckUefiLib.uni FILE_GUID = AC24A4C7-F845-4665-90E5-6431D6E28DC0 - MODULE_TYPE = DXE_RUNTIME_DRIVER + MODULE_TYPE = BASE VERSION_STRING = 1.0 - LIBRARY_CLASS = NULL|DXE_RUNTIME_DRIVER DXE_SMM_DRIVER + LIBRARY_CLASS = NULL|DXE_RUNTIME_DRIVER DXE_SMM_DRIVER MM_STANDALONE CONSTRUCTOR = VarCheckUefiLibNullClassConstructor # diff --git a/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLibNullClass.c b/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLibNullClass.c index 80dc6341adcf..5e419831e8cc 100644 --- a/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLibNullClass.c +++ b/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLibNullClass.c @@ -12,6 +12,8 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. **/ +#include <Uefi/UefiBaseType.h> + #include <Library/VarCheckLib.h> #include <Library/BaseLib.h> #include <Library/BaseMemoryLib.h> @@ -927,15 +929,14 @@ VariablePropertySetUefiDefined ( @retval EFI_SUCCESS The constructor executed correctly. **/ -EFI_STATUS +RETURN_STATUS EFIAPI VarCheckUefiLibNullClassConstructor ( - IN EFI_HANDLE ImageHandle, - IN EFI_SYSTEM_TABLE *SystemTable + VOID ) { VariablePropertySetUefiDefined (); VarCheckLibRegisterSetVariableCheckHandler (SetVariableCheckHandlerUefiDefined); - return EFI_SUCCESS; + return RETURN_SUCCESS; } -- 2.17.1 ^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH 4/4] MdePkg/UefiDevicePathLib: permit use by MM_STANDALONE modules 2019-01-16 21:22 [PATCH 0/4] Various Packages: add MM_STANDALONE support Ard Biesheuvel ` (2 preceding siblings ...) 2019-01-16 21:22 ` [PATCH 3/4] MdeModulePkg/VarCheckLib: " Ard Biesheuvel @ 2019-01-16 21:22 ` Ard Biesheuvel 2019-01-18 11:07 ` Ard Biesheuvel 2019-01-21 12:43 ` [PATCH 0/4] Various Packages: add MM_STANDALONE support Ard Biesheuvel 4 siblings, 1 reply; 23+ messages in thread From: Ard Biesheuvel @ 2019-01-16 21:22 UTC (permalink / raw) To: edk2-devel Cc: Ard Biesheuvel, Michael D Kinney, Liming Gao, Ting Ye, Gang Wei, Jian Wang, Chao Zhang, Jiewen Yao, Hao Wu, Star Zeng, Achin Gupta, Jagadeesh Ujja Add MM_STANDALONE to the list of module types that are permitted to link to this library. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> --- MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf b/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf index d5f7bfa6af39..89ee87e15d0e 100644 --- a/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf +++ b/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf @@ -22,7 +22,7 @@ [Defines] FILE_GUID = 91c1677a-e57f-4191-8b8e-eb7711a716e0 MODULE_TYPE = UEFI_DRIVER VERSION_STRING = 1.0 - LIBRARY_CLASS = DevicePathLib|DXE_CORE DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SMM_DRIVER UEFI_APPLICATION UEFI_DRIVER SMM_CORE + LIBRARY_CLASS = DevicePathLib|DXE_CORE DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SMM_DRIVER UEFI_APPLICATION UEFI_DRIVER SMM_CORE MM_STANDALONE # -- 2.17.1 ^ permalink raw reply related [flat|nested] 23+ messages in thread
* Re: [PATCH 4/4] MdePkg/UefiDevicePathLib: permit use by MM_STANDALONE modules 2019-01-16 21:22 ` [PATCH 4/4] MdePkg/UefiDevicePathLib: " Ard Biesheuvel @ 2019-01-18 11:07 ` Ard Biesheuvel 2019-01-21 12:37 ` Gao, Liming 0 siblings, 1 reply; 23+ messages in thread From: Ard Biesheuvel @ 2019-01-18 11:07 UTC (permalink / raw) To: edk2-devel@lists.01.org Cc: Michael D Kinney, Liming Gao, Ting Ye, Gang Wei, Jian Wang, Chao Zhang, Jiewen Yao, Hao Wu, Star Zeng, Achin Gupta, Jagadeesh Ujja On Wed, 16 Jan 2019 at 22:22, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote: > > Add MM_STANDALONE to the list of module types that are permitted to > link to this library. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > --- > MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf b/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf > index d5f7bfa6af39..89ee87e15d0e 100644 > --- a/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf > +++ b/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf > @@ -22,7 +22,7 @@ [Defines] > FILE_GUID = 91c1677a-e57f-4191-8b8e-eb7711a716e0 > MODULE_TYPE = UEFI_DRIVER > VERSION_STRING = 1.0 > - LIBRARY_CLASS = DevicePathLib|DXE_CORE DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SMM_DRIVER UEFI_APPLICATION UEFI_DRIVER SMM_CORE > + LIBRARY_CLASS = DevicePathLib|DXE_CORE DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SMM_DRIVER UEFI_APPLICATION UEFI_DRIVER SMM_CORE MM_STANDALONE > > Liming, Mike: do you have any objections? ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 4/4] MdePkg/UefiDevicePathLib: permit use by MM_STANDALONE modules 2019-01-18 11:07 ` Ard Biesheuvel @ 2019-01-21 12:37 ` Gao, Liming 0 siblings, 0 replies; 23+ messages in thread From: Gao, Liming @ 2019-01-21 12:37 UTC (permalink / raw) To: Ard Biesheuvel, edk2-devel@lists.01.org Cc: Ye, Ting, Wu, Hao A, Yao, Jiewen, Zeng, Star, Kinney, Michael D, Zhang, Chao B Reviewed-by: Liming Gao <liming.gao@intel.com> > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ard Biesheuvel > Sent: Friday, January 18, 2019 7:07 PM > To: edk2-devel@lists.01.org > Cc: Ye, Ting <ting.ye@intel.com>; Gao, Liming <liming.gao@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Yao, Jiewen > <jiewen.yao@intel.com>; Zeng, Star <star.zeng@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Zhang, Chao B > <chao.b.zhang@intel.com> > Subject: Re: [edk2] [PATCH 4/4] MdePkg/UefiDevicePathLib: permit use by MM_STANDALONE modules > > On Wed, 16 Jan 2019 at 22:22, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote: > > > > Add MM_STANDALONE to the list of module types that are permitted to > > link to this library. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > --- > > MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf b/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf > > index d5f7bfa6af39..89ee87e15d0e 100644 > > --- a/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf > > +++ b/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf > > @@ -22,7 +22,7 @@ [Defines] > > FILE_GUID = 91c1677a-e57f-4191-8b8e-eb7711a716e0 > > MODULE_TYPE = UEFI_DRIVER > > VERSION_STRING = 1.0 > > - LIBRARY_CLASS = DevicePathLib|DXE_CORE DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SMM_DRIVER > UEFI_APPLICATION UEFI_DRIVER SMM_CORE > > + LIBRARY_CLASS = DevicePathLib|DXE_CORE DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SMM_DRIVER > UEFI_APPLICATION UEFI_DRIVER SMM_CORE MM_STANDALONE > > > > > > Liming, Mike: do you have any objections? > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 0/4] Various Packages: add MM_STANDALONE support 2019-01-16 21:22 [PATCH 0/4] Various Packages: add MM_STANDALONE support Ard Biesheuvel ` (3 preceding siblings ...) 2019-01-16 21:22 ` [PATCH 4/4] MdePkg/UefiDevicePathLib: " Ard Biesheuvel @ 2019-01-21 12:43 ` Ard Biesheuvel 2019-01-21 12:49 ` Gao, Liming 4 siblings, 1 reply; 23+ messages in thread From: Ard Biesheuvel @ 2019-01-21 12:43 UTC (permalink / raw) To: edk2-devel@lists.01.org Cc: Michael D Kinney, Liming Gao, Ting Ye, Gang Wei, Jian Wang, Chao Zhang, Jiewen Yao, Hao Wu, Star Zeng, Achin Gupta, Jagadeesh Ujja On Wed, 16 Jan 2019 at 22:22, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote: > > Add MM_STANDALONE to the list of permitted module types of various > libraries that are required to build the standalone MM authenticated > variable stack. > > In some cases, this requires the MODULE_TYPE to be modified to BASE, > given that the constructor prototype is different between DXE/UEFI > and MM_STANDALONE drivers. > > Cc: Michael D Kinney <michael.d.kinney@intel.com> > Cc: Liming Gao <liming.gao@intel.com> > Cc: Ting Ye <ting.ye@intel.com> > Cc: Gang Wei <gang.wei@intel.com> > Cc: Jian Wang <jian.j.wang@intel.com> > Cc: Chao Zhang <chao.b.zhang@intel.com> > Cc: Jiewen Yao <jiewen.yao@intel.com> > Cc: Hao Wu <hao.a.wu@intel.com> > Cc: Star Zeng <star.zeng@intel.com> > Cc: Achin Gupta <achin.gupta@arm.com> > Cc: Jagadeesh Ujja <jagadeesh.ujja@arm.com> > > Ard Biesheuvel (4): > CryptoPkg/SmmCryptLib: permit use by MM_STANDALONE modules > SecurityPkg/PlatformSecureLibNull: permit use by MM_STANDALONE modules > MdeModulePkg/VarCheckLib: permit use by MM_STANDALONE modules > MdePkg/UefiDevicePathLib: permit use by MM_STANDALONE modules > Series pushed as 5c5ca9f1fbf8..f634e32db5b6 Thanks all! ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 0/4] Various Packages: add MM_STANDALONE support 2019-01-21 12:43 ` [PATCH 0/4] Various Packages: add MM_STANDALONE support Ard Biesheuvel @ 2019-01-21 12:49 ` Gao, Liming 2019-01-21 14:34 ` Ard Biesheuvel 0 siblings, 1 reply; 23+ messages in thread From: Gao, Liming @ 2019-01-21 12:49 UTC (permalink / raw) To: Ard Biesheuvel, edk2-devel@lists.01.org Cc: Ye, Ting, Wu, Hao A, Yao, Jiewen, Zeng, Star, Kinney, Michael D, Zhang, Chao B Ard: The patches created by you recently is to support the standalone MM authenticated variable stack. This is likely a new feature. Could you help submit BZ for this new feature or reuse the existing BZ? And, update https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning to include it for edk2-stable201903 tag. Thanks Liming > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ard Biesheuvel > Sent: Monday, January 21, 2019 8:44 PM > To: edk2-devel@lists.01.org > Cc: Ye, Ting <ting.ye@intel.com>; Gao, Liming <liming.gao@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Yao, Jiewen > <jiewen.yao@intel.com>; Zeng, Star <star.zeng@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Zhang, Chao B > <chao.b.zhang@intel.com> > Subject: Re: [edk2] [PATCH 0/4] Various Packages: add MM_STANDALONE support > > On Wed, 16 Jan 2019 at 22:22, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote: > > > > Add MM_STANDALONE to the list of permitted module types of various > > libraries that are required to build the standalone MM authenticated > > variable stack. > > > > In some cases, this requires the MODULE_TYPE to be modified to BASE, > > given that the constructor prototype is different between DXE/UEFI > > and MM_STANDALONE drivers. > > > > Cc: Michael D Kinney <michael.d.kinney@intel.com> > > Cc: Liming Gao <liming.gao@intel.com> > > Cc: Ting Ye <ting.ye@intel.com> > > Cc: Gang Wei <gang.wei@intel.com> > > Cc: Jian Wang <jian.j.wang@intel.com> > > Cc: Chao Zhang <chao.b.zhang@intel.com> > > Cc: Jiewen Yao <jiewen.yao@intel.com> > > Cc: Hao Wu <hao.a.wu@intel.com> > > Cc: Star Zeng <star.zeng@intel.com> > > Cc: Achin Gupta <achin.gupta@arm.com> > > Cc: Jagadeesh Ujja <jagadeesh.ujja@arm.com> > > > > Ard Biesheuvel (4): > > CryptoPkg/SmmCryptLib: permit use by MM_STANDALONE modules > > SecurityPkg/PlatformSecureLibNull: permit use by MM_STANDALONE modules > > MdeModulePkg/VarCheckLib: permit use by MM_STANDALONE modules > > MdePkg/UefiDevicePathLib: permit use by MM_STANDALONE modules > > > > Series pushed as 5c5ca9f1fbf8..f634e32db5b6 > > Thanks all! > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 0/4] Various Packages: add MM_STANDALONE support 2019-01-21 12:49 ` Gao, Liming @ 2019-01-21 14:34 ` Ard Biesheuvel 2019-02-28 14:53 ` Ard Biesheuvel 0 siblings, 1 reply; 23+ messages in thread From: Ard Biesheuvel @ 2019-01-21 14:34 UTC (permalink / raw) To: Gao, Liming Cc: edk2-devel@lists.01.org, Ye, Ting, Wu, Hao A, Yao, Jiewen, Zeng, Star, Kinney, Michael D, Zhang, Chao B On Mon, 21 Jan 2019 at 13:49, Gao, Liming <liming.gao@intel.com> wrote: > > Ard: > The patches created by you recently is to support the standalone MM authenticated variable stack. This is likely a new feature. > > Could you help submit BZ for this new feature or reuse the existing BZ? And, update https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning to include it for edk2-stable201903 tag. > I will add a bugzilla entry for the remaining standalone MM work, but could someone please add StandaloneMmPkg to the bugzilla packages list? Thanks. ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 0/4] Various Packages: add MM_STANDALONE support 2019-01-21 14:34 ` Ard Biesheuvel @ 2019-02-28 14:53 ` Ard Biesheuvel 0 siblings, 0 replies; 23+ messages in thread From: Ard Biesheuvel @ 2019-02-28 14:53 UTC (permalink / raw) To: Gao, Liming, Kinney, Michael D Cc: edk2-devel@lists.01.org, Ye, Ting, Wu, Hao A, Yao, Jiewen, Zeng, Star, Zhang, Chao B On Mon, 21 Jan 2019 at 15:34, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote: > > On Mon, 21 Jan 2019 at 13:49, Gao, Liming <liming.gao@intel.com> wrote: > > > > Ard: > > The patches created by you recently is to support the standalone MM authenticated variable stack. This is likely a new feature. > > > > Could you help submit BZ for this new feature or reuse the existing BZ? And, update https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning to include it for edk2-stable201903 tag. > > > > I will add a bugzilla entry for the remaining standalone MM work, but > could someone please add StandaloneMmPkg to the bugzilla packages > list? Thanks. Mike, Could you please make this change to bugzilla? We need it to log work for StandaloneMmPkg. Thanks, Ard. ^ permalink raw reply [flat|nested] 23+ messages in thread
end of thread, other threads:[~2019-02-28 14:53 UTC | newest] Thread overview: 23+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-01-16 21:22 [PATCH 0/4] Various Packages: add MM_STANDALONE support Ard Biesheuvel 2019-01-16 21:22 ` [PATCH 1/4] CryptoPkg/SmmCryptLib: permit use by MM_STANDALONE modules Ard Biesheuvel 2019-01-18 7:05 ` Wang, Jian J 2019-01-18 11:12 ` Ard Biesheuvel 2019-01-21 12:36 ` Ard Biesheuvel 2019-01-21 12:40 ` Gao, Liming 2019-01-21 12:40 ` Ard Biesheuvel 2019-01-22 2:42 ` Ye, Ting 2019-01-16 21:22 ` [PATCH 2/4] SecurityPkg/PlatformSecureLibNull: " Ard Biesheuvel 2019-01-18 7:06 ` Wang, Jian J 2019-01-18 11:13 ` Ard Biesheuvel 2019-01-18 15:01 ` Yao, Jiewen 2019-01-16 21:22 ` [PATCH 3/4] MdeModulePkg/VarCheckLib: " Ard Biesheuvel 2019-01-18 7:06 ` Wang, Jian J 2019-01-18 8:15 ` Zeng, Star 2019-01-18 10:45 ` Zeng, Star 2019-01-16 21:22 ` [PATCH 4/4] MdePkg/UefiDevicePathLib: " Ard Biesheuvel 2019-01-18 11:07 ` Ard Biesheuvel 2019-01-21 12:37 ` Gao, Liming 2019-01-21 12:43 ` [PATCH 0/4] Various Packages: add MM_STANDALONE support Ard Biesheuvel 2019-01-21 12:49 ` Gao, Liming 2019-01-21 14:34 ` Ard Biesheuvel 2019-02-28 14:53 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox