Re: [Patch 2/2] MdeModulePkg:Tpm2Acpi.h: Upgrade UEFI supporting TCG spec info

["Yao, Jiewen" <jiewen.yao@intel.com>]

Hi Chao
Do you think we need provide a way to let a platform fill " PlatformSpecificParameters ", then the core driver can fill laml and lasl ?

Thank you
Yao Jiewen


> -----Original Message-----
> From: Zhang, Chao B
> Sent: Friday, January 25, 2019 11:31 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>
> Subject: [Patch 2/2] MdeModulePkg:Tpm2Acpi.h: Upgrade UEFI supporting
> TCG spec info
> 
> Update "TCG ACPI Specification Level 00 Revision 00.37" to "TCG ACPI
> Specification 1.2 Revision 8"
> https://trustedcomputinggroup.org/wp-content/uploads/TCG_ACPIGeneralS
> pecification_v1.20_r8.pdf
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Cc: Yao Jiewen <jiewen.yao@intel.com>
> Signed-off-by: Zhang, Chao B <chao.b.zhang@intel.com>
> ---
>  MdePkg/Include/IndustryStandard/Tpm2Acpi.h | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/MdePkg/Include/IndustryStandard/Tpm2Acpi.h
> b/MdePkg/Include/IndustryStandard/Tpm2Acpi.h
> index 6b8161e6a6..6bae0a0aa5 100644
> --- a/MdePkg/Include/IndustryStandard/Tpm2Acpi.h
> +++ b/MdePkg/Include/IndustryStandard/Tpm2Acpi.h
> @@ -1,9 +1,9 @@
>  /** @file
>    TPM2 ACPI table definition.
> 
> -Copyright (c) 2013 - 2017, Intel Corporation. All rights reserved. <BR>
> +Copyright (c) 2013 - 2019, Intel Corporation. All rights reserved. <BR>
>  This program and the accompanying materials
>  are licensed and made available under the terms and conditions of the BSD
> License
>  which accompanies this distribution.  The full text of the license may be
> found at
>  http://opensource.org/licenses/bsd-license.php
> 
> @@ -29,17 +29,20 @@ typedef struct {
>    //    BIT0~15:  PlatformClass      This field is only valid for version
> 4 and above
>    //    BIT16~31: Reserved
>    UINT32                      Flags;
>    UINT64                      AddressOfControlArea;
>    UINT32                      StartMethod;
> -//UINT8                       PlatformSpecificParameters[];
> +//UINT8                       PlatformSpecificParameters[];  // size
> up to 12
> +//UINT32                      Laml;
> // Optional
> +//UINT32                      Lasa;
> // Optional
>  } EFI_TPM2_ACPI_TABLE;
> 
>  #define EFI_TPM2_ACPI_TABLE_START_METHOD_ACPI
> 2
>  #define EFI_TPM2_ACPI_TABLE_START_METHOD_TIS
> 6
>  #define
> EFI_TPM2_ACPI_TABLE_START_METHOD_COMMAND_RESPONSE_BUFFER_
> INTERFACE             7
>  #define
> EFI_TPM2_ACPI_TABLE_START_METHOD_COMMAND_RESPONSE_BUFFER_
> INTERFACE_WITH_ACPI   8
> +#define
> EFI_TPM2_ACPI_TABLE_START_METHOD_COMMAND_RESPONSE_BUFFER_
> INTERFACE_WITH_SMC    11
> 
>  typedef struct {
>    UINT32   Reserved;
>    UINT32   Error;
>    UINT32   Cancel;
> --
> 2.16.2.windows.1