From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <jiewen.yao@intel.com>
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
client-ip=192.55.52.88; helo=mga01.intel.com;
envelope-from=jiewen.yao@intel.com; receiver=edk2-devel@lists.01.org
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by ml01.01.org (Postfix) with ESMTPS id E5B84211D3917
for <edk2-devel@lists.01.org>; Tue, 5 Mar 2019 05:52:48 -0800 (PST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga007.fm.intel.com ([10.253.24.52])
by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
05 Mar 2019 05:52:46 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.58,444,1544515200"; d="scan'208";a="131736650"
Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201])
by fmsmga007.fm.intel.com with ESMTP; 05 Mar 2019 05:52:44 -0800
Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by
FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS)
id 14.3.408.0; Tue, 5 Mar 2019 05:52:44 -0800
Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by
FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS)
id 14.3.408.0; Tue, 5 Mar 2019 05:52:44 -0800
Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.163]) by
SHSMSX104.ccr.corp.intel.com ([169.254.5.74]) with mapi id 14.03.0415.000;
Tue, 5 Mar 2019 21:52:42 +0800
From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>, "edk2-devel@lists.01.org"
<edk2-devel@lists.01.org>
Thread-Topic: [PATCH 05/10] StandaloneMmPkg/StandaloneMmCoreEntryPoint: drop
explicit SerialPortLib call
Thread-Index: AQHU01gKZvX5W2G9I0yqbY7V+91HCKX9Dqng
Date: Tue, 5 Mar 2019 13:52:41 +0000
Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503F54CDFB@shsmsx102.ccr.corp.intel.com>
References: <20190305133248.4828-1-ard.biesheuvel@linaro.org>
<20190305133248.4828-6-ard.biesheuvel@linaro.org>
In-Reply-To: <20190305133248.4828-6-ard.biesheuvel@linaro.org>
Accept-Language: zh-CN, en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzYwZjMyYmItZWE1ZS00OWM2LTliNDEtMTVhODgzOTQxYWNmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoia01oQVFlckk4S3ZER0hPQlZFR29KV052bVpoMlBmTmdSUmdtNUVnQ0NFY0c1RmJtNXRHNUtSTEhpckNBS1g1XC8ifQ==
x-ctpclassification: CTP_NT
dlp-product: dlpe-windows
dlp-version: 11.0.400.15
dlp-reaction: no-action
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Subject: Re: [PATCH 05/10] StandaloneMmPkg/StandaloneMmCoreEntryPoint: drop explicit SerialPortLib call
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: EDK II Development <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
<mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
<mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Mar 2019 13:52:49 -0000
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Reviewed-by: Jiewen.yao@intel.com
> -----Original Message-----
> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
> Sent: Tuesday, March 5, 2019 5:33 AM
> To: edk2-devel@lists.01.org
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Achin Gupta
> <achin.gupta@arm.com>; Supreeth Venkatesh
> <supreeth.venkatesh@arm.com>; Yao, Jiewen <jiewen.yao@intel.com>;
> Leif Lindholm <leif.lindholm@linaro.org>; Jagadeesh Ujja
> <jagadeesh.ujja@arm.com>
> Subject: [PATCH 05/10] StandaloneMmPkg/StandaloneMmCoreEntryPoint:
> drop explicit SerialPortLib call
>=20
> Sending DEBUG output to the serial port should only be done via
> DebugLib calls, which is in charge of initializing the serial
> port when appropriate. So drop the explicit SerialPortInitialize ()
> invocation, and rely on normal constructor ordering to get the
> serial port into the appropriate state at the right time.
>=20
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
>=20
> StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/Standal
> oneMmCoreEntryPoint.c | 3 ---
> 1 file changed, 3 deletions(-)
>=20
> diff --git
> a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/Stand
> aloneMmCoreEntryPoint.c
> b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/Stand
> aloneMmCoreEntryPoint.c
> index 5cca532456fd..c8e11a253d24 100644
> ---
> a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/Stand
> aloneMmCoreEntryPoint.c
> +++
> b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/Stand
> aloneMmCoreEntryPoint.c
> @@ -232,9 +232,6 @@ _ModuleEntryPoint (
> VOID *TeData;
> UINTN TeDataSize;
>=20
> - Status =3D SerialPortInitialize ();
> - ASSERT_EFI_ERROR (Status);
> -
> // Get Secure Partition Manager Version Information
> Status =3D GetSpmVersion ();
> if (EFI_ERROR (Status)) {
> --
> 2.20.1