From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=jiewen.yao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C2A80211D3917 for ; Tue, 5 Mar 2019 05:55:07 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Mar 2019 05:55:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,444,1544515200"; d="scan'208";a="279911866" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga004.jf.intel.com with ESMTP; 05 Mar 2019 05:55:06 -0800 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 5 Mar 2019 05:55:06 -0800 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 5 Mar 2019 05:55:04 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.163]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.223]) with mapi id 14.03.0415.000; Tue, 5 Mar 2019 21:55:03 +0800 From: "Yao, Jiewen" To: Ard Biesheuvel , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [PATCH 02/10] StandaloneMmPkg: drop unused PCD PcdStandaloneMmEnable Thread-Index: AQHU01f8uI9NP793dEi4uvb7gvV8K6X9D1FQ Date: Tue, 5 Mar 2019 13:55:02 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503F54CEAB@shsmsx102.ccr.corp.intel.com> References: <20190305133248.4828-1-ard.biesheuvel@linaro.org> <20190305133248.4828-3-ard.biesheuvel@linaro.org> In-Reply-To: <20190305133248.4828-3-ard.biesheuvel@linaro.org> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiM2JkZjg3MjQtOGVhZS00Y2ZjLWE2NDMtZTJhOTdlNDA2OGNlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiK0dYOWk2ellobmo4aE5IU2MyTkV6blJWbWdtam1lTmRlNU1sQ3JmVjM5TlRRK1NKdko0V1wvdUhSRlJlOGFzSnkifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 02/10] StandaloneMmPkg: drop unused PCD PcdStandaloneMmEnable X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Mar 2019 13:55:08 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: jiewen.yao@intel.com > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Ard Biesheuvel > Sent: Tuesday, March 5, 2019 5:33 AM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen > Subject: [edk2] [PATCH 02/10] StandaloneMmPkg: drop unused PCD > PcdStandaloneMmEnable >=20 > The PCD PcdStandaloneMmEnable is unused, and shouldn't exist in the > first place since the value is implied by the context (it is never > valid to set it to FALSE for standalone MM or TRUE for traditional > MM). So drop it. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > StandaloneMmPkg/StandaloneMmPkg.dec > | 3 --- > StandaloneMmPkg/StandaloneMmPkg.dsc > | 3 --- >=20 > StandaloneMmPkg/Library/StandaloneMmPeCoffExtraActionLib/Standalone > MmPeCoffExtraActionLib.inf | 3 --- > 3 files changed, 9 deletions(-) >=20 > diff --git a/StandaloneMmPkg/StandaloneMmPkg.dec > b/StandaloneMmPkg/StandaloneMmPkg.dec > index 0b5fbf9e1767..2d178c5e20a6 100644 > --- a/StandaloneMmPkg/StandaloneMmPkg.dec > +++ b/StandaloneMmPkg/StandaloneMmPkg.dec > @@ -39,6 +39,3 @@ [Guids] > gEfiStandaloneMmNonSecureBufferGuid =3D { 0xf00497e3, 0xbfa2, > 0x41a1, { 0x9d, 0x29, 0x54, 0xc2, 0xe9, 0x37, 0x21, 0xc5 }} > gEfiArmTfCpuDriverEpDescriptorGuid =3D { 0x6ecbd5a1, 0xc0f8, > 0x4702, { 0x83, 0x01, 0x4f, 0xc2, 0xc5, 0x47, 0x0a, 0x51 }} >=20 > -[PcdsFeatureFlag] > - > gStandaloneMmPkgTokenSpaceGuid.PcdStandaloneMmEnable|FALSE|BOOL > EAN|0x00000001 > - > diff --git a/StandaloneMmPkg/StandaloneMmPkg.dsc > b/StandaloneMmPkg/StandaloneMmPkg.dsc > index e8d71ad56f52..f279d9e7e5c7 100644 > --- a/StandaloneMmPkg/StandaloneMmPkg.dsc > +++ b/StandaloneMmPkg/StandaloneMmPkg.dsc > @@ -78,9 +78,6 @@ [LibraryClasses.AARCH64] > # Pcd Section - list of all EDK II PCD Entries defined by this Platform > # >=20 > ############################################################## > ################## > -[PcdsFeatureFlag] > - gStandaloneMmPkgTokenSpaceGuid.PcdStandaloneMmEnable|TRUE > - > [PcdsFixedAtBuild] > gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x800000CF > gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0xff > diff --git > a/StandaloneMmPkg/Library/StandaloneMmPeCoffExtraActionLib/Standalo > neMmPeCoffExtraActionLib.inf > b/StandaloneMmPkg/Library/StandaloneMmPeCoffExtraActionLib/Standalo > neMmPeCoffExtraActionLib.inf > index eef3d7c6e253..181c15b9345a 100644 > --- > a/StandaloneMmPkg/Library/StandaloneMmPeCoffExtraActionLib/Standalo > neMmPeCoffExtraActionLib.inf > +++ > b/StandaloneMmPkg/Library/StandaloneMmPeCoffExtraActionLib/Standalo > neMmPeCoffExtraActionLib.inf > @@ -37,9 +37,6 @@ [Packages] > MdePkg/MdePkg.dec > StandaloneMmPkg/StandaloneMmPkg.dec >=20 > -[FeaturePcd] > - gStandaloneMmPkgTokenSpaceGuid.PcdStandaloneMmEnable > - > [LibraryClasses] > StandaloneMmMmuLib > PcdLib > -- > 2.20.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel