From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.31; helo=mga06.intel.com; envelope-from=jiewen.yao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 07BFD211CF36A for ; Tue, 5 Mar 2019 06:22:25 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Mar 2019 06:22:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,444,1544515200"; d="scan'208";a="122797079" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga008.jf.intel.com with ESMTP; 05 Mar 2019 06:22:24 -0800 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 5 Mar 2019 06:22:24 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 5 Mar 2019 06:22:23 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.163]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.134]) with mapi id 14.03.0415.000; Tue, 5 Mar 2019 22:22:22 +0800 From: "Yao, Jiewen" To: Ard Biesheuvel , "edk2-devel@lists.01.org" Thread-Topic: [PATCH 04/10] StandaloneMmPkg: remove redundant StandaloneMmDriverEntryPoint driver Thread-Index: AQHU01gG7dQqdU2V0EaZF+aCKW3jtaX9FvEg Date: Tue, 5 Mar 2019 14:22:20 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503F54D00A@shsmsx102.ccr.corp.intel.com> References: <20190305133248.4828-1-ard.biesheuvel@linaro.org> <20190305133248.4828-5-ard.biesheuvel@linaro.org> In-Reply-To: <20190305133248.4828-5-ard.biesheuvel@linaro.org> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTNlYWZjYzMtMWEyMC00MDQzLWFkYzQtMmViYmQ0NWVlZGFjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWmtKelZkY3NqRXFwbGJPWjN6cGhvK3dEUFd1ZE53ZFBPN1lxVDdjb1wvd09aQ1wvU01TNTV3aEExdTBSNmRwV01yIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 04/10] StandaloneMmPkg: remove redundant StandaloneMmDriverEntryPoint driver X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Mar 2019 14:22:26 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: jiewen.yao@intel.com > -----Original Message----- > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > Sent: Tuesday, March 5, 2019 5:33 AM > To: edk2-devel@lists.01.org > Cc: Ard Biesheuvel ; Achin Gupta > ; Supreeth Venkatesh > ; Yao, Jiewen ; > Leif Lindholm ; Jagadeesh Ujja > > Subject: [PATCH 04/10] StandaloneMmPkg: remove redundant > StandaloneMmDriverEntryPoint driver >=20 > StandaloneMmDriverEntryPoint is implemented in MdePkg now, so let's > drop the redundant StandaloneMmPkg version. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- >=20 > StandaloneMmPkg/Library/StandaloneMmDriverEntryPoint/StandaloneMmD > riverEntryPoint.inf | 41 -------- >=20 > StandaloneMmPkg/Library/StandaloneMmDriverEntryPoint/StandaloneMmD > riverEntryPoint.c | 99 -------------------- > 2 files changed, 140 deletions(-) >=20 > diff --git > a/StandaloneMmPkg/Library/StandaloneMmDriverEntryPoint/StandaloneM > mDriverEntryPoint.inf > b/StandaloneMmPkg/Library/StandaloneMmDriverEntryPoint/StandaloneM > mDriverEntryPoint.inf > deleted file mode 100644 > index 4d1896db10ba..000000000000 > --- > a/StandaloneMmPkg/Library/StandaloneMmDriverEntryPoint/StandaloneM > mDriverEntryPoint.inf > +++ /dev/null > @@ -1,41 +0,0 @@ > -## @file > -# Module entry point library for Standalone MM driver. > -# > -# Copyright (c) 2015, Intel Corporation. All rights reserved.
> -# Copyright (c) 2016-2018, ARM Ltd. All rights reserved.
> -# > -# This program and the accompanying materials > -# are licensed and made available under the terms and conditions of the > BSD License > -# which accompanies this distribution. The full text of the license may= be > found at > -# http://opensource.org/licenses/bsd-license.php. > -# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" > BASIS, > -# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER > EXPRESS OR IMPLIED. > -# > -# > -## > - > -[Defines] > - INF_VERSION =3D 0x0001001A > - BASE_NAME =3D StandaloneMmDriverEntryPoint > - FILE_GUID =3D > BBC33478-98F8-4B78-B29D-574D681B7E43 > - MODULE_TYPE =3D MM_STANDALONE > - VERSION_STRING =3D 1.0 > - PI_SPECIFICATION_VERSION =3D 0x00010032 > - LIBRARY_CLASS =3D > StandaloneMmDriverEntryPoint|MM_STANDALONE > - > -# > -# The following information is for reference only and not required by th= e > build tools. > -# > -# VALID_ARCHITECTURES =3D IA32 X64 IPF EBC > -# > - > -[Sources] > - StandaloneMmDriverEntryPoint.c > - > -[Packages] > - MdePkg/MdePkg.dec > - > -[LibraryClasses] > - BaseLib > - DebugLib > - > diff --git > a/StandaloneMmPkg/Library/StandaloneMmDriverEntryPoint/StandaloneM > mDriverEntryPoint.c > b/StandaloneMmPkg/Library/StandaloneMmDriverEntryPoint/StandaloneM > mDriverEntryPoint.c > deleted file mode 100644 > index 64bffcfccc8a..000000000000 > --- > a/StandaloneMmPkg/Library/StandaloneMmDriverEntryPoint/StandaloneM > mDriverEntryPoint.c > +++ /dev/null > @@ -1,99 +0,0 @@ > -/** @file > - Entry point to a Standalone MM driver. > - > -Copyright (c) 2015, Intel Corporation. All rights reserved.
> -Copyright (c) 2016 - 2018, ARM Ltd. All rights reserved.
> - > -This program and the accompanying materials > -are licensed and made available under the terms and conditions of the BS= D > License > -which accompanies this distribution. The full text of the license may b= e > found at > -http://opensource.org/licenses/bsd-license.php > - > -THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" > BASIS, > -WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER > EXPRESS OR IMPLIED. > - > -**/ > - > -#include > - > -#include > -#include > - > -VOID > -EFIAPI > -ProcessLibraryConstructorList ( > - IN EFI_HANDLE ImageHandle, > - IN IN EFI_MM_SYSTEM_TABLE *MmSystemTable > - ); > - > -EFI_STATUS > -EFIAPI > -ProcessModuleEntryPointList ( > - IN EFI_HANDLE ImageHandle, > - IN IN EFI_MM_SYSTEM_TABLE *MmSystemTable > - ); > - > -VOID > -EFIAPI > -ProcessLibraryDestructorList ( > - IN EFI_HANDLE ImageHandle, > - IN IN EFI_MM_SYSTEM_TABLE *MmSystemTable > - ); > - > -/** > - The entry point of PE/COFF Image for a Standalone MM Driver. > - > - This function is the entry point for a Standalone MM Driver. > - This function must call ProcessLibraryConstructorList() and > - ProcessModuleEntryPointList(). > - If the return status from ProcessModuleEntryPointList() > - is an error status, then ProcessLibraryDestructorList() must be called= . > - The return value from ProcessModuleEntryPointList() is returned. > - If _gDriverUnloadImageCount is greater than zero, then an unload > - handler must be registered for this image > - and the unload handler must invoke ProcessModuleUnloadList(). > - If _gUefiDriverRevision is not zero and SystemTable->Hdr.Revision is l= ess > - than _gUefiDriverRevison, then return EFI_INCOMPATIBLE_VERSION. > - > - > - @param ImageHandle The image handle of the Standalone MM > Driver. > - @param SystemTable A pointer to the EFI System Table. > - > - @retval EFI_SUCCESS The Standalone MM Driver > exited normally. > - @retval EFI_INCOMPATIBLE_VERSION _gUefiDriverRevision is > greater than > - SystemTable->Hdr.Revision. > - @retval Other Return value from > ProcessModuleEntryPointList(). > - > -**/ > -EFI_STATUS > -EFIAPI > -_ModuleEntryPoint ( > - IN EFI_HANDLE ImageHandle, > - IN IN EFI_MM_SYSTEM_TABLE *MmSystemTable > - ) > -{ > - EFI_STATUS Status; > - > - // > - // Call constructor for all libraries > - // > - ProcessLibraryConstructorList (ImageHandle, MmSystemTable); > - > - // > - // Call the driver entry point > - // > - Status =3D ProcessModuleEntryPointList (ImageHandle, MmSystemTable); > - > - // > - // If all of the drivers returned errors, then invoke all of the libra= ry > destructors > - // > - if (EFI_ERROR (Status)) { > - ProcessLibraryDestructorList (ImageHandle, MmSystemTable); > - } > - > - // > - // Return the cumulative return status code from all of the driver ent= ry > points > - // > - return Status; > -} > - > -- > 2.20.1