From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: jiewen.yao@intel.com) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by groups.io with SMTP; Thu, 13 Jun 2019 15:31:50 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Jun 2019 15:31:49 -0700 X-ExtLoop1: 1 Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga007.fm.intel.com with ESMTP; 13 Jun 2019 15:31:48 -0700 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 13 Jun 2019 15:31:49 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.33]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.156]) with mapi id 14.03.0439.000; Fri, 14 Jun 2019 06:31:47 +0800 From: "Yao, Jiewen" To: "Zurcher, Christopher J" , "Gao, Liming" , "devel@edk2.groups.io" CC: "Kinney, Michael D" , "Wang, Jian J" , "Ni, Ray" , "Wu, Hao A" Subject: Re: [PATCH v4 0/2] Add SCSI Support for Storage Security Command Protocol Thread-Topic: [PATCH v4 0/2] Add SCSI Support for Storage Security Command Protocol Thread-Index: AQHVIYxnFiRSwQynEUKScyp7VUlPfKaZiy2ggACSu7CAAA2l8A== Date: Thu, 13 Jun 2019 22:31:46 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503F6B2BD5@shsmsx102.ccr.corp.intel.com> References: <20190613020454.19324-1-christopher.j.zurcher@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4809BF@SHSMSX104.ccr.corp.intel.com> <8EE4873E19344F4DA986A2AC15D512AE4613B908@CRSMSX104.amr.corp.intel.com> In-Reply-To: <8EE4873E19344F4DA986A2AC15D512AE4613B908@CRSMSX104.amr.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODFmOGZlMTYtYzM1NS00ZDBlLTk2NTctMDNmNTEwZTA2ZWE1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiQkVCbEtQZzhqTVIwODNlbkdxUm9vTVBcL29hZHR5U2JtZWhMQVBya2g2XC9scWV2TWw1TSttT2MyQjhucWdCbkUyIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: jiewen.yao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thank you Christopher. Your code looks good to me. I also recommend MdeModulePkg/SCSI owner take a look and give r-b. Ray or Hao Can you help on that? Thank you Yao Jiewen > -----Original Message----- > From: Zurcher, Christopher J > Sent: Friday, June 14, 2019 6:26 AM > To: Gao, Liming ; devel@edk2.groups.io > Cc: Kinney, Michael D ; Yao, Jiewen > ; Wang, Jian J > Subject: RE: [PATCH v4 0/2] Add SCSI Support for Storage Security Command > Protocol >=20 > A unit test has been run which provisions RPMB key, writes data, and veri= fies > it after reading on the following boot. > Further, this code is being exercised for secure storage on multiple plat= forms > as part of standard boot flow. >=20 > Unit test files emailed separately. >=20 > Thanks, > Christopher Zurcher >=20 >=20 > -----Original Message----- > From: Gao, Liming > Sent: Thursday, June 13, 2019 05:59 > To: Zurcher, Christopher J ; > devel@edk2.groups.io > Cc: Kinney, Michael D ; Yao, Jiewen > ; Wang, Jian J > Subject: RE: [PATCH v4 0/2] Add SCSI Support for Storage Security Command > Protocol >=20 > Zurcher: > Can you share what test has been done for this feature? >=20 > Thanks > Liming > > -----Original Message----- > > From: Zurcher, Christopher J > > Sent: Thursday, June 13, 2019 10:05 AM > > To: devel@edk2.groups.io > > Cc: Kinney, Michael D ; Yao, Jiewen > ; Wang, Jian J ; Gao, > > Liming > > Subject: [PATCH v4 0/2] Add SCSI Support for Storage Security Command > Protocol > > > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1546 > > > > V4 changes: > > Add SSC Protocol in addition to BlockIo instead of in place of BlockIo. > > Add error handling for (BlockSize =3D=3D 0) in Read and WriteBlocks com= mands > > to handle partitions that do not support ReadCapacity(). > > > > V3 changes: > > Initialize AlignedBuffer variable in ScsiDiskReceiveData and > > ScsiDiskSendData functions. Remove redundant input validation and debug > > message in ScsiDiskSendData. > > > > V2 changes: > > Split the patch into separate commits for separate packages. > > > > To support RPMB access on UFS devices, support must be added to > > the ScsiDiskDxe driver for the Storage Security Command Protocol. > > > > Cc: Michael D Kinney > > Cc: Jiewen Yao > > Cc: Jian J Wang > > Cc: Liming Gao > > > > Christopher J Zurcher (2): > > MdePkg: Implement SCSI commands for Security Protocol In/Out > > MdeModulePkg/ScsiDiskDxe: Support Storage Security Command > Protocol > > > > MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf | 3 +- > > MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h | 171 ++++++- > > MdePkg/Include/IndustryStandard/Scsi.h | 48 +- > > MdePkg/Include/Library/UefiScsiLib.h | 126 ++++- > > MdePkg/Include/Protocol/ScsiIo.h | 9 +- > > MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.c | 5 +- > > MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c | 522 > +++++++++++++++++++- > > MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThru.c | 19 +- > > MdePkg/Library/UefiScsiLib/UefiScsiLib.c | 205 +++++++- > > 9 files changed, 1064 insertions(+), 44 deletions(-) > > > > -- > > 2.16.2.windows.1