From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: jiewen.yao@intel.com) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by groups.io with SMTP; Fri, 14 Jun 2019 01:47:59 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Jun 2019 01:47:58 -0700 X-ExtLoop1: 1 Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga006.fm.intel.com with ESMTP; 14 Jun 2019 01:47:58 -0700 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 14 Jun 2019 01:47:58 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 14 Jun 2019 01:47:57 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.33]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.104]) with mapi id 14.03.0439.000; Fri, 14 Jun 2019 16:47:56 +0800 From: "Yao, Jiewen" To: "devel@edk2.groups.io" , "Gao, Zhichao" CC: Bret Barkelew , "Zhang, Chao B" , "Wang, Jian J" , "Gao, Liming" , Sean Brogan , Michael Turner , Leif Lindholm Subject: Re: [edk2-devel] [PATCH v2] SecurityPkg: Add missing instances for build only Thread-Topic: [edk2-devel] [PATCH v2] SecurityPkg: Add missing instances for build only Thread-Index: AQHVIowjqdinKSPJ0023LosMym38ZKaa1epg Date: Fri, 14 Jun 2019 08:47:55 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503F6B3E82@shsmsx102.ccr.corp.intel.com> References: <20190614083438.10728-1-zhichao.gao@intel.com> In-Reply-To: <20190614083438.10728-1-zhichao.gao@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDZkYzEwMmItMzQyYS00YWNhLTlkZjMtNjAwYTZiNjcxNWFlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiNDVQT2t3MVBGdmpoZTc0ME1qSHp6R0hTaUQrQjZSXC9pb3NyTEI0NU1MVEg4MXRRWlpWaTlEZUIxU2ZBXC82RTRjIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: jiewen.yao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi It is good to add those to build. However, I think we should remove SecurityPkg\Library\DxeDeferImageLoadLib= from the code base. This lib supports old UID and may conflict with MdeModulePkg\Universal\Sec= urityStubDxe\Defer3rdPartyImageLoad.c Thank you Yao Jiewen > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Gao, Zhichao > Sent: Friday, June 14, 2019 4:35 PM > To: devel@edk2.groups.io > Cc: Bret Barkelew ; Zhang, Chao B > ; Yao, Jiewen ; Wang, > Jian J ; Gao, Liming ; Sean > Brogan ; Michael Turner > ; Leif Lindholm = ; > Gao, Zhichao > Subject: [edk2-devel] [PATCH v2] SecurityPkg: Add missing instances for = build > only >=20 > From: Bret Barkelew >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1902 >=20 > Add the missing instances to the [Components] of dsc file > for build only. >=20 > Cc: Chao Zhang > Cc: Jiewen Yao > Cc: Jian Wang > Cc: Liming Gao > Cc: Sean Brogan > Cc: Michael Turner > Cc: Bret Barkelew > Cc: Leif Lindholm > Signed-off-by: Zhichao gao > --- > V2: fix with Laszlo's comment: > https://edk2.groups.io/g/devel/message/42273 >=20 > SecurityPkg/SecurityPkg.dsc | 6 ++++++ > 1 file changed, 6 insertions(+) >=20 > diff --git a/SecurityPkg/SecurityPkg.dsc b/SecurityPkg/SecurityPkg.dsc > index a2ee0528f0..ed0da7563d 100644 > --- a/SecurityPkg/SecurityPkg.dsc > +++ b/SecurityPkg/SecurityPkg.dsc > @@ -199,6 +199,12 @@ >=20 > SecurityPkg/Library/FmpAuthenticationLibPkcs7/FmpAuthenticationLibPkcs7 > .inf >=20 > SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthenticatio > nLibRsa2048Sha256.inf >=20 > + SecurityPkg/Library/DxeDeferImageLoadLib/DxeDeferImageLoadLib.inf > + > SecurityPkg/Library/DxeTpmMeasurementLib/DxeTpmMeasurementLib.inf > + SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.inf > + SecurityPkg/Library/Tcg2PpVendorLibNull/Tcg2PpVendorLibNull.inf > + SecurityPkg/Library/TcgPpVendorLibNull/TcgPpVendorLibNull.inf > + > [Components.IA32, Components.X64, Components.ARM, > Components.AARCH64] > SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf >=20 > -- > 2.21.0.windows.1 >=20 >=20 >=20