From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: jiewen.yao@intel.com) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by groups.io with SMTP; Tue, 25 Jun 2019 07:08:50 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Jun 2019 07:08:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,416,1557212400"; d="scan'208";a="336859433" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga005.jf.intel.com with ESMTP; 25 Jun 2019 07:08:48 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 25 Jun 2019 07:08:48 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 25 Jun 2019 07:08:47 -0700 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 25 Jun 2019 07:08:47 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.33]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.89]) with mapi id 14.03.0439.000; Tue, 25 Jun 2019 22:08:45 +0800 From: "Yao, Jiewen" To: "Wang, Jian J" , "devel@edk2.groups.io" CC: "Zhang, Chao B" , "Hernandez Beltran, Jorge" , "Han, Harry" Subject: Re: [PATCH v4 0/3] Common OBB verification feature Thread-Topic: [PATCH v4 0/3] Common OBB verification feature Thread-Index: AQHVJwvAHWpXTgC3n0K1LcEDuU4J+aasb5XQ Date: Tue, 25 Jun 2019 14:08:44 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503F6CC3FD@shsmsx102.ccr.corp.intel.com> References: <20190620015859.6424-1-jian.j.wang@intel.com> In-Reply-To: <20190620015859.6424-1-jian.j.wang@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTQ0ZjIwMjUtOGMyNi00ZmU5LThlZDgtYjE0MWFiOTdkZDQ1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVFhqbXA5MnJPMXhOTE1cL0lPUk1JTU1XXC9weEUwTnhFTkpQOUx1bk9YV01KdktNdU56QkhndkRtcjBrenBLTE9hIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: jiewen.yao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks Jian. Comment below: 1) My previous comment 8 is NOT addressed. Please add assert for "StoredHashFvPpi->FvNumber". if (!EFI_ERROR(Status) && StoredHashFvPpi !=3D NULL && StoredHashFvPpi->F= vNumber > 0) { With that fixed, reviewed-by: Jiewen.yao@intel.com Thank you Yao Jiewen > -----Original Message----- > From: Wang, Jian J > Sent: Thursday, June 20, 2019 9:59 AM > To: devel@edk2.groups.io > Cc: Zhang, Chao B ; Yao, Jiewen > ; Hernandez Beltran, Jorge > ; Han, Harry > Subject: [PATCH v4 0/3] Common OBB verification feature >=20 > >V4: change FV_HASH_FLAG_BOOT_MODE definition >=20 > >V3: update per Jiewen's comments >=20 > >V2: fix parameter description error found by ECC >=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1617 >=20 > Cc: Chao Zhang > Cc: Jiewen Yao > Cc: "Hernandez Beltran, Jorge" > Cc: Harry Han >=20 > Jian J Wang (3): > SecurityPkg: add definitions for OBB verification > SecurityPkg/FvReportPei: implement a common FV verifier and reporter > SecurityPkg: add FvReportPei.inf in dsc for build validation >=20 > SecurityPkg/FvReportPei/FvReportPei.c | 416 > ++++++++++++++++++ > SecurityPkg/FvReportPei/FvReportPei.h | 122 +++++ > SecurityPkg/FvReportPei/FvReportPei.inf | 57 +++ > SecurityPkg/FvReportPei/FvReportPei.uni | 14 + > .../FvReportPei/FvReportPeiPeiExtra.uni | 12 + > .../Ppi/FirmwareVolumeInfoStoredHashFv.h | 62 +++ > SecurityPkg/SecurityPkg.dec | 9 + > SecurityPkg/SecurityPkg.dsc | 5 + > 8 files changed, 697 insertions(+) > create mode 100644 SecurityPkg/FvReportPei/FvReportPei.c > create mode 100644 SecurityPkg/FvReportPei/FvReportPei.h > create mode 100644 SecurityPkg/FvReportPei/FvReportPei.inf > create mode 100644 SecurityPkg/FvReportPei/FvReportPei.uni > create mode 100644 SecurityPkg/FvReportPei/FvReportPeiPeiExtra.uni > create mode 100644 > SecurityPkg/Include/Ppi/FirmwareVolumeInfoStoredHashFv.h >=20 > -- > 2.17.1.windows.2