From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "Gao, Liming" <liming.gao@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"Zhang, Shenglei" <shenglei.zhang@intel.com>,
"ard.biesheuvel@linaro.org" <ard.biesheuvel@linaro.org>,
"leif.lindholm@linaro.org" <leif.lindholm@linaro.org>
Cc: "Feng, Bob C" <bob.c.feng@intel.com>
Subject: Re: [edk2-devel] [edk2-platform patch 0/6] Add tools FMMT FCE and FitGen
Date: Tue, 25 Jun 2019 14:14:57 +0000 [thread overview]
Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503F6CC44F@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E48D1AA@SHSMSX104.ccr.corp.intel.com>
Thanks Liming.
I would treat that as *a general help request* to validate the BaseTool update on ARM/AARCH64 Linux OS.
If we can have Ard or any other ARM person to help validate a new base tool patch, that will be great.
In this case, it is about the new added FCE or FMMT.
In the future, maybe we have other C-tool update.
Should we add them to CC list in any tool patch?
Thank you
Yao Jiewen
> -----Original Message-----
> From: Gao, Liming
> Sent: Tuesday, June 25, 2019 10:09 PM
> To: Yao, Jiewen <jiewen.yao@intel.com>; devel@edk2.groups.io; Zhang,
> Shenglei <shenglei.zhang@intel.com>; ard.biesheuvel@linaro.org;
> leif.lindholm@linaro.org
> Cc: Feng, Bob C <bob.c.feng@intel.com>
> Subject: RE: [edk2-devel] [edk2-platform patch 0/6] Add tools FMMT FCE
> and FitGen
>
> Jiewen:
> For FCE/FMMT C tools, I only compile them on X64 Linux OS. I don't
> compile them on ARM or AARCH64 Linux OS for ARM native build. Now,
> edk2 BaseTools C tools top level Makefile supports ARM, AARCH64, IA32 and
> X64. If they don't pass build on ARM native Linux OS, this change will bring
> the break for some user. If we can avoid the break, I agree to add them into
> edk2 BaseTools.
>
> Ard:
> I have no ARM or AARCH64 Linux OS. Could you help compile FCE/FMMT
> tools in ARM or AARCH64 Linux OS? These patches are in
> https://github.com/shenglei10/edk2/commits/movetool. After pick those
> patches, you just need to type make in BaseTools directory and compile all C
> tools. FCE/FMMT are common tools to update FD/FV image binaries. FMMT
> is a tool to enable removal, addition and replacement of FFS files in FD
> image binaries. FCE is a tool to retrieve and change HII configuration data as
> the default NV variable in Firmware Device(*.fd) files. They are used in post
> build step to replace FFS or insert the default NV storage in FD image.
>
> Thanks
> Liming
> > -----Original Message-----
> > From: Yao, Jiewen
> > Sent: Friday, June 21, 2019 11:34 AM
> > To: Gao, Liming <liming.gao@intel.com>; devel@edk2.groups.io; Zhang,
> Shenglei <shenglei.zhang@intel.com>
> > Cc: Feng, Bob C <bob.c.feng@intel.com>
> > Subject: RE: [edk2-devel] [edk2-platform patch 0/6] Add tools FMMT FCE
> and FitGen
> >
> > Sorry, I missed the first mail.
> > I saw there is no V2 tag in this series, so I think it is the first mail. My
> apology.
> >
> > I have no concern on FitGen - it is Intel only. You can check in at first.
> > FMMT/FCE is common. I think BaseTools is more proper place.
> >
> > "It is not validated" - it seems a weird justification to me.
> > Or does it mean, for any future feature Intel/ARM people contribute, we
> should treat Platform package as the first choice, just because the
> > it is cross validated?
> >
> > May I understand more on the rule we have today on what goes to EDK2
> repo and what goes to EDK2-PLATFORM repo?
> >
> > Thank you
> > Yao Jiewen
> >
> >
> > > -----Original Message-----
> > > From: Gao, Liming
> > > Sent: Friday, June 21, 2019 10:31 AM
> > > To: Yao, Jiewen <jiewen.yao@intel.com>; devel@edk2.groups.io; Zhang,
> > > Shenglei <shenglei.zhang@intel.com>
> > > Cc: Feng, Bob C <bob.c.feng@intel.com>
> > > Subject: RE: [edk2-devel] [edk2-platform patch 0/6] Add tools FMMT FCE
> > > and FitGen
> > >
> > > Jiewen:
> > > I give the comments
> > >
> https://edk2.groups.io/g/devel/message/42545?p=,,,20,0,0,0::Created,,FM
> > > MT,20,2,0,32013143 for the patch BaseTools/FCE: Add a tool FCE
> > >
> > > I give new proposal https://edk2.groups.io/g/devel/message/42546
> for
> > > those tools.
> > >
> > > Thanks
> > > Liming
> > > > -----Original Message-----
> > > > From: Yao, Jiewen
> > > > Sent: Friday, June 21, 2019 10:26 AM
> > > > To: devel@edk2.groups.io; Zhang, Shenglei
> <shenglei.zhang@intel.com>
> > > > Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming
> > > <liming.gao@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>
> > > > Subject: RE: [edk2-devel] [edk2-platform patch 0/6] Add tools FMMT
> FCE
> > > and FitGen
> > > >
> > > > HI
> > > > I saw some conflict:
> > > > =========
> > > > BaseTools/FCE: Add a tool FCE
> > > > Add FMMT and FCE into Platform/Intel/Tools.
> > > > =========
> > > >
> > > > I agree that FitGet goes to Intel silicon.
> > > >
> > > > Should we put both FCE/FMMT to BaseTools?
> > > >
> > > > Thank you
> > > > Yao Jiewen
> > > >
> > > >
> > > > > -----Original Message-----
> > > > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On
> Behalf
> > > Of
> > > > > Zhang, Shenglei
> > > > > Sent: Friday, June 21, 2019 9:27 AM
> > > > > To: devel@edk2.groups.io
> > > > > Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming
> > > > > <liming.gao@intel.com>
> > > > > Subject: [edk2-devel] [edk2-platform patch 0/6] Add tools FMMT FCE
> and
> > > > > FitGen
> > > > >
> > > > > Add FMMT and FCE into Platform/Intel/Tools.
> > > > > Add FitGen into Silicon/Intel/Tools.
> > > > > https://bugzilla.tianocore.org/show_bug.cgi?id=1847
> > > > > https://bugzilla.tianocore.org/show_bug.cgi?id=1848
> > > > > https://bugzilla.tianocore.org/show_bug.cgi?id=1849
> > > > >
> > > > > Cc: Bob Feng <bob.c.feng@intel.com>
> > > > > Cc: Liming Gao <liming.gao@intel.com>
> > > > > Shenglei Zhang (6):
> > > > > Platform/Tools: Add a tool FMMT
> > > > > Platform/Tools: Add a tool BfmLib
> > > > > BaseTools/FCE: Add a tool FCE
> > > > > Platform/Tools: Add top level Makefile and GNUMakefile
> > > > > Silicon/Tools: Add a tool FitGen
> > > > > Silicon/Tools: Add top level Makefile and GNUMakefile
> > > > >
> > > > > Platform/Intel/Tools/BfmLib/BfmLib.c | 4355
> +++++++++++
> > > > > Platform/Intel/Tools/BfmLib/BinFileManager.c | 1024 +++
> > > > > Platform/Intel/Tools/BfmLib/BinFileManager.h | 439 ++
> > > > > Platform/Intel/Tools/BfmLib/GNUmakefile | 15 +
> > > > > Platform/Intel/Tools/BfmLib/Makefile | 17 +
> > > > > Platform/Intel/Tools/FCE/BinaryCreate.c | 216 +
> > > > > Platform/Intel/Tools/FCE/BinaryCreate.h | 157 +
> > > > > Platform/Intel/Tools/FCE/BinaryParse.c | 1326 ++++
> > > > > Platform/Intel/Tools/FCE/BinaryParse.h | 187 +
> > > > > Platform/Intel/Tools/FCE/Common.c | 2183 ++++++
> > > > > Platform/Intel/Tools/FCE/Common.h | 999 +++
> > > > > Platform/Intel/Tools/FCE/Expression.c | 2367 ++++++
> > > > > Platform/Intel/Tools/FCE/Fce.c | 6449
> > > > > +++++++++++++++++
> > > > > Platform/Intel/Tools/FCE/Fce.h | 447 ++
> > > > > Platform/Intel/Tools/FCE/GNUmakefile | 22 +
> > > > > Platform/Intel/Tools/FCE/IfrParse.c | 4836
> ++++++++++++
> > > > > Platform/Intel/Tools/FCE/IfrParse.h | 789 ++
> > > > > Platform/Intel/Tools/FCE/Makefile | 19 +
> > > > > .../Intel/Tools/FCE/MonotonicBasedVariable.c | 874 +++
> > > > > .../Intel/Tools/FCE/MonotonicBasedVariable.h | 162 +
> > > > > Platform/Intel/Tools/FCE/TimeBasedVariable.c | 878 +++
> > > > > Platform/Intel/Tools/FCE/TimeBasedVariable.h | 166 +
> > > > > Platform/Intel/Tools/FCE/Variable.c | 1091 +++
> > > > > Platform/Intel/Tools/FCE/Variable.h | 154 +
> > > > > Platform/Intel/Tools/FCE/VariableCommon.h | 55 +
> > > > > .../Tools/FMMT/FirmwareModuleManagement.c | 2559
> +++++++
> > > > > .../Tools/FMMT/FirmwareModuleManagement.h | 479 ++
> > > > > Platform/Intel/Tools/FMMT/FmmtConf.ini | 6 +
> > > > > Platform/Intel/Tools/FMMT/FmmtLib.c | 5051
> > > > > +++++++++++++
> > > > > Platform/Intel/Tools/FMMT/GNUmakefile | 16 +
> > > > > Platform/Intel/Tools/FMMT/Makefile | 17 +
> > > > > Platform/Intel/Tools/FMMT/Rebase.c | 846 +++
> > > > > Platform/Intel/Tools/FMMT/Rebase.h | 31 +
> > > > > Platform/Intel/Tools/GNUmakefile | 30 +
> > > > > Platform/Intel/Tools/Makefile | 33 +
> > > > > Silicon/Intel/Tools/FitGen/FitGen.c | 3137 ++++++++
> > > > > Silicon/Intel/Tools/FitGen/FitGen.h | 48 +
> > > > > Silicon/Intel/Tools/FitGen/GNUmakefile | 16 +
> > > > > Silicon/Intel/Tools/FitGen/Makefile | 17 +
> > > > > Silicon/Intel/Tools/GNUmakefile | 34 +
> > > > > Silicon/Intel/Tools/Makefile | 31 +
> > > > > 41 files changed, 41578 insertions(+)
> > > > > create mode 100644 Platform/Intel/Tools/BfmLib/BfmLib.c
> > > > > create mode 100644
> Platform/Intel/Tools/BfmLib/BinFileManager.c
> > > > > create mode 100644
> Platform/Intel/Tools/BfmLib/BinFileManager.h
> > > > > create mode 100644 Platform/Intel/Tools/BfmLib/GNUmakefile
> > > > > create mode 100644 Platform/Intel/Tools/BfmLib/Makefile
> > > > > create mode 100644 Platform/Intel/Tools/FCE/BinaryCreate.c
> > > > > create mode 100644 Platform/Intel/Tools/FCE/BinaryCreate.h
> > > > > create mode 100644 Platform/Intel/Tools/FCE/BinaryParse.c
> > > > > create mode 100644 Platform/Intel/Tools/FCE/BinaryParse.h
> > > > > create mode 100644 Platform/Intel/Tools/FCE/Common.c
> > > > > create mode 100644 Platform/Intel/Tools/FCE/Common.h
> > > > > create mode 100644 Platform/Intel/Tools/FCE/Expression.c
> > > > > create mode 100644 Platform/Intel/Tools/FCE/Fce.c
> > > > > create mode 100644 Platform/Intel/Tools/FCE/Fce.h
> > > > > create mode 100644 Platform/Intel/Tools/FCE/GNUmakefile
> > > > > create mode 100644 Platform/Intel/Tools/FCE/IfrParse.c
> > > > > create mode 100644 Platform/Intel/Tools/FCE/IfrParse.h
> > > > > create mode 100644 Platform/Intel/Tools/FCE/Makefile
> > > > > create mode 100644
> > > Platform/Intel/Tools/FCE/MonotonicBasedVariable.c
> > > > > create mode 100644
> > > Platform/Intel/Tools/FCE/MonotonicBasedVariable.h
> > > > > create mode 100644
> Platform/Intel/Tools/FCE/TimeBasedVariable.c
> > > > > create mode 100644
> Platform/Intel/Tools/FCE/TimeBasedVariable.h
> > > > > create mode 100644 Platform/Intel/Tools/FCE/Variable.c
> > > > > create mode 100644 Platform/Intel/Tools/FCE/Variable.h
> > > > > create mode 100644 Platform/Intel/Tools/FCE/VariableCommon.h
> > > > > create mode 100644
> > > > > Platform/Intel/Tools/FMMT/FirmwareModuleManagement.c
> > > > > create mode 100644
> > > > > Platform/Intel/Tools/FMMT/FirmwareModuleManagement.h
> > > > > create mode 100644 Platform/Intel/Tools/FMMT/FmmtConf.ini
> > > > > create mode 100644 Platform/Intel/Tools/FMMT/FmmtLib.c
> > > > > create mode 100644 Platform/Intel/Tools/FMMT/GNUmakefile
> > > > > create mode 100644 Platform/Intel/Tools/FMMT/Makefile
> > > > > create mode 100644 Platform/Intel/Tools/FMMT/Rebase.c
> > > > > create mode 100644 Platform/Intel/Tools/FMMT/Rebase.h
> > > > > create mode 100644 Platform/Intel/Tools/GNUmakefile
> > > > > create mode 100644 Platform/Intel/Tools/Makefile
> > > > > create mode 100644 Silicon/Intel/Tools/FitGen/FitGen.c
> > > > > create mode 100644 Silicon/Intel/Tools/FitGen/FitGen.h
> > > > > create mode 100644 Silicon/Intel/Tools/FitGen/GNUmakefile
> > > > > create mode 100644 Silicon/Intel/Tools/FitGen/Makefile
> > > > > create mode 100644 Silicon/Intel/Tools/GNUmakefile
> > > > > create mode 100644 Silicon/Intel/Tools/Makefile
> > > > >
> > > > > --
> > > > > 2.18.0.windows.1
> > > > >
> > > > >
> > > > >
next prev parent reply other threads:[~2019-06-25 14:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-21 1:26 [edk2-platform patch 0/6] Add tools FMMT FCE and FitGen Zhang, Shenglei
2019-06-21 1:26 ` [edk2-platform patch 1/6] Platform\Tools: Add a tool FMMT Zhang, Shenglei
2019-06-21 1:26 ` [edk2-platform patch 2/6] Platform\Tools: Add a tool BfmLib Zhang, Shenglei
2019-06-21 1:26 ` [edk2-platform patch 3/6] BaseTools\FCE: Add a tool FCE Zhang, Shenglei
2019-06-21 1:26 ` [edk2-platform patch 4/6] Platform\Tools: Add top level Makefile and GNUMakefile Zhang, Shenglei
2019-06-21 1:26 ` [edk2-platform patch 5/6] Silicon\Tools: Add a tool FitGen Zhang, Shenglei
2019-06-26 2:03 ` [edk2-devel] " Liming Gao
2019-06-21 1:26 ` [edk2-platform patch 6/6] Silicon\Tools: Add top level Makefile and GNUMakefile Zhang, Shenglei
2019-06-26 2:04 ` Liming Gao
2019-06-21 2:25 ` [edk2-devel] [edk2-platform patch 0/6] Add tools FMMT FCE and FitGen Yao, Jiewen
2019-06-21 2:31 ` Liming Gao
2019-06-21 3:34 ` Yao, Jiewen
2019-06-25 14:09 ` Liming Gao
2019-06-25 14:14 ` Yao, Jiewen [this message]
2019-06-25 15:20 ` Liming Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74D8A39837DF1E4DA445A8C0B3885C503F6CC44F@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox