From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: jiewen.yao@intel.com) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by groups.io with SMTP; Tue, 02 Jul 2019 20:11:08 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Jul 2019 20:11:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,445,1557212400"; d="scan'208";a="166392476" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga003.jf.intel.com with ESMTP; 02 Jul 2019 20:11:07 -0700 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 2 Jul 2019 20:11:07 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 2 Jul 2019 20:11:06 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.3]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.22]) with mapi id 14.03.0439.000; Wed, 3 Jul 2019 11:11:05 +0800 From: "Yao, Jiewen" To: "Dong, Eric" , "devel@edk2.groups.io" CC: "Ni, Ray" , Laszlo Ersek Subject: Re: [edk2-devel] [Patch v3 0/2] Enable new MM MP protocol Thread-Topic: [edk2-devel] [Patch v3 0/2] Enable new MM MP protocol Thread-Index: AQHVMUkLtdpRkaWPfEa9vey3mi+gP6a4L8NQ//997oCAAImOcA== Date: Wed, 3 Jul 2019 03:11:04 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503F6F2053@shsmsx102.ccr.corp.intel.com> References: <20190703024242.33572-1-eric.dong@intel.com> <74D8A39837DF1E4DA445A8C0B3885C503F6F1EB1@shsmsx102.ccr.corp.intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNGQ5NzVhZmUtZTM0NS00N2Q0LWJiMzYtMjkxMjNhOGQ2YjRjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTXhuSzkxU0hQNk9OZEt4WU1Ua2EzSVkyRVNUdlJtUG1sUnRpNE5NaFJGVHpjTUVMZXN4T1FyeEM2Q3pYWXNcLzUifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: jiewen.yao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable It looks great. Thanks! > -----Original Message----- > From: Dong, Eric > Sent: Wednesday, July 3, 2019 10:58 AM > To: Yao, Jiewen ; devel@edk2.groups.io > Cc: Ni, Ray ; Laszlo Ersek > Subject: RE: [edk2-devel] [Patch v3 0/2] Enable new MM MP protocol >=20 > Hi Jiewen, >=20 > I did below tests: > 1. Use MpGetNumberOfProcessors and MpSetStartupProcedure. > 2. Test MpDispatchProcedure > =091.sync mode and async mode, > =092. with and without CpuStatus. > =093. In async mode, use long delay get the final result with > MpWaitForProcedure > =094. In async mode, use short delay to check the final result with > MpCheckForProcedure > 3. Test MpBroadcastProcedure > =091.sync mode and async mode, > =092. with and without CpuStatus. > =093. In async mode, use long delay get the final result with > MpWaitForProcedure. > =094. In async mode, use short delay to check the final result with > MpCheckForProcedure. >=20 > Detail test code can be found in MmMpUnitTest folder at > git@github.com:ydong10/UnitTestPkg.git >=20 > Thanks, > Eric >=20 > > -----Original Message----- > > From: Yao, Jiewen > > Sent: Wednesday, July 3, 2019 10:45 AM > > To: devel@edk2.groups.io; Dong, Eric > > Cc: Ni, Ray ; Laszlo Ersek > > Subject: RE: [edk2-devel] [Patch v3 0/2] Enable new MM MP protocol > > > > HI Eric > > Would you please share what unit test you have done for this new featu= re? > > > > > > > -----Original Message----- > > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf > Of > > > Dong, Eric > > > Sent: Wednesday, July 3, 2019 10:43 AM > > > To: devel@edk2.groups.io > > > Cc: Ni, Ray ; Laszlo Ersek > > > Subject: [edk2-devel] [Patch v3 0/2] Enable new MM MP protocol > > > > > > v3 changes: > > > 1. Fix Token clean up too early caused CheckProcedure return error. > > > > > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1937 > > > > > > PI spec added a new protocol named MM MP protocol. This protocol > > > allows for better remote queuing of execution of procedures on an AP= . > > > This extends the existing procedures to allow: > > > 1. A function to be called in blocking and non-blocking manner > > > explicitly 2. Allow broadcasts. > > > 3. Allow execution of a procedure when a processor powers up. > > > > > > This patch serial enable this new protocol. > > > > > > Cc: Ray Ni > > > Cc: Laszlo Ersek > > > > > > Eric Dong (2): > > > MdePkg: Add new MM MP Protocol definition. > > > UefiCpuPkg/PiSmmCpuDxeSmm: Enable MM MP Protocol. > > > > > > MdePkg/Include/Pi/PiMultiPhase.h | 16 + > > > MdePkg/Include/Protocol/MmMp.h | 333 > +++++++++++ > > > MdePkg/MdePkg.dec | 3 + > > > UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 555 > > > ++++++++++++++++++- > > > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 11 + > > > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 160 +++++- > > > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf | 3 + > > > UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.c | 372 > > > +++++++++++++ > > > UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.h | 286 > > > ++++++++++ > > > 9 files changed, 1722 insertions(+), 17 deletions(-) create mode > > > 100644 MdePkg/Include/Protocol/MmMp.h create mode 100644 > > > UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.c create mode 100644 > > > UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.h > > > > > > -- > > > 2.21.0.windows.1 > > > > > > > > >=20