From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: jiewen.yao@intel.com) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by groups.io with SMTP; Sun, 29 Sep 2019 22:26:00 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Sep 2019 22:25:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,565,1559545200"; d="scan'208";a="204753507" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga001.fm.intel.com with ESMTP; 29 Sep 2019 22:25:59 -0700 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 29 Sep 2019 22:25:58 -0700 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 29 Sep 2019 22:25:58 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.176]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.33]) with mapi id 14.03.0439.000; Mon, 30 Sep 2019 13:25:57 +0800 From: "Yao, Jiewen" To: "Wang, Jian J" , "devel@edk2.groups.io" CC: "Zhang, Chao B" Subject: Re: [edk2-devel] [PATCH 0/3] Add Laml/Lasa to TPM2 acpi table Thread-Topic: [edk2-devel] [PATCH 0/3] Add Laml/Lasa to TPM2 acpi table Thread-Index: AQHVdo1ufjtBHDjhiEu7Wh+gA6Xlg6dDr07AgAACSeA= Date: Mon, 30 Sep 2019 05:25:56 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503F7DF17F@shsmsx102.ccr.corp.intel.com> References: <20190929061558.22512-1-jiewen.yao@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTIxOGVlOGItNDAyOS00NDA0LWE3NmUtYWY1ODRlNzk3YmJjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUnZaRDluS2hxVDhCXC8zeWhMcFloTWtKeDk3S3ZDTTJyOFFraTM5am1KelZ3YnJYN0E2aTI5b1pRN2NDbWpsOVEifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: jiewen.yao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Got it. Thanks for the reminder. I will follow. Thank you Yao Jiewen > -----Original Message----- > From: Wang, Jian J > Sent: Monday, September 30, 2019 1:23 PM > To: devel@edk2.groups.io; Yao, Jiewen > Cc: Zhang, Chao B > Subject: RE: [edk2-devel] [PATCH 0/3] Add Laml/Lasa to TPM2 acpi table >=20 > Thanks for implementing this feature. Just one minor comment. The BZ lin= k > should also > be mentioned in patch1-3, not just cover letter. With this addressed, fo= r the > whole series, >=20 > Reviewed-by: Jian J Wang >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Yao, > Jiewen > > Sent: Sunday, September 29, 2019 2:16 PM > > To: devel@edk2.groups.io > > Cc: Wang, Jian J ; Zhang, Chao B > > > > Subject: [edk2-devel] [PATCH 0/3] Add Laml/Lasa to TPM2 acpi table > > > > Bugzilla https://bugzilla.tianocore.org/show_bug.cgi?id=3D978 > > > > This patch series adds Laml/Lasa to TPM2 ACPI table. > > > > This is defined by TPM2 ACPI table Version 1.2, Revision 8. > > It only impacts the TPM2 ACPI table version 4 or above. > > The default TPM2 ACPI table version is still 3 to keep maximum compati= bility. > > > > The new fields are only for TCG2 log format, but not TCG1.2 log format= . > > > > This new fields are optional and won't be consumed by OS/Loader, becau= se > > the OS/loader still uses TCG2_PROTOCOL to get the event log. > > > > These fields are important for OS utility, because the OS utility can > > not use TCG2_PROTOCOL. > > > > Test: > > Use default TPM2 version 3. No ALMA/ALSA shown in TPM2 table. > > Use TPM2 version 4. The DXE driver reports ALMA/ALSA PCD and the SMM > driver > > installs ALMA/ALSA in TPM2 table. > > > > Cc: Jian J Wang > > Cc: Chao Zhang > > Signed-off-by: Jiewen Yao > > > > Jiewen Yao (3): > > MdePkg/Include: correct Lasa in Tpm2Acpi. > > SecurityPkg/dsc: Add PCD for Laml, Lasa for TPM2. > > SecurityPkg/Tcg2: Add Support Laml, Lasa for TPM2 ACPI. > > > > MdePkg/Include/IndustryStandard/Tpm2Acpi.h | 2 +- > > SecurityPkg/SecurityPkg.dec | 8 ++++++ > > SecurityPkg/SecurityPkg.uni | 9 ++++++ > > SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c | 32 ++++++++++++++++++---= - > > SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf | 3 ++ > > SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c | 32 ++++++++++++++++++++-= - > > SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.inf | 2 ++ > > 7 files changed, 78 insertions(+), 10 deletions(-) > > > > -- > > 2.19.2.windows.1 > > > > > >=20