From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web12.6143.1573028706176180381 for ; Wed, 06 Nov 2019 00:25:06 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: jiewen.yao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Nov 2019 00:25:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,274,1569308400"; d="scan'208";a="205254779" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga003.jf.intel.com with ESMTP; 06 Nov 2019 00:25:05 -0800 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 6 Nov 2019 00:25:04 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 6 Nov 2019 00:25:04 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.108]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.127]) with mapi id 14.03.0439.000; Wed, 6 Nov 2019 16:25:03 +0800 From: "Yao, Jiewen" To: "Ni, Ray" , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Wu, Hao A" , "Lou, Yun" Subject: Re: [edk2-devel] [PATCH V2 2/4] MdeModulePkg/Include: Add DeviceSecurity.h Thread-Topic: [edk2-devel] [PATCH V2 2/4] MdeModulePkg/Include: Add DeviceSecurity.h Thread-Index: AQHVj+cEIgzkXKmuDkyX050d2kV/CKd9zqVAgAAEr/A= Date: Wed, 6 Nov 2019 08:25:02 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503F83EBF9@shsmsx102.ccr.corp.intel.com> References: <20191031123012.16020-1-jiewen.yao@intel.com> <20191031123012.16020-3-jiewen.yao@intel.com> <734D49CCEBEEF84792F5B80ED585239D5C35174D@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C35174D@SHSMSX104.ccr.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzI3MjZkYWYtYzgzMy00ZmU2LTlmNjktYTEyMDQ1YzQxYjBkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoieGR6Z2xBcUpqbTFFS0NaYlwvdUw3Zjd3aXIyZDBFNURcL1B3XC9YZ21VSWc3cVFQM3FCTDZsVTdWVWNXMDh4UWlubCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: jiewen.yao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable HI Good comment. Let me answer it in 2 parts. 1) The consumer may locate the deice path to know the device type. In this = part, you can treat this as redundant information. 2) But we still need a new GUID, because I will install the device access p= rotocol on this new GUID for the temporary access for the authentication dr= iver only. I don't want to install the device access protocol to the original UEFI spe= c defined GUID to notify everyone that the device is ready to use, because = I have seen some device drivers have callback function (such as ATA passthr= u, or NVME passthru) to start access the device once the device access prot= ocol is installed. Thank you Yao Jiewen > -----Original Message----- > From: Ni, Ray > Sent: Wednesday, November 6, 2019 3:56 PM > To: devel@edk2.groups.io; Yao, Jiewen > Cc: Wang, Jian J ; Wu, Hao A ; > Lou, Yun > Subject: RE: [edk2-devel] [PATCH V2 2/4] MdeModulePkg/Include: Add > DeviceSecurity.h >=20 > > + /// > > + /// Type of the device. > > + /// This field is also served as a device Access protocol GUID. > > + /// The device access protocol is installed on the DeviceHandle. > > + /// The device access protocol is device specific. > > + /// EDKII_DEVICE_IDENTIFIER_TYPE_PCI_GUID means the device access > protocol is PciIo. > > + /// EDKII_DEVICE_IDENTIFIER_TYPE_USB_GUID means the device access > protocol is UsbIo. > > + /// > > + EFI_GUID DeviceType; >=20 > Do we still need DeviceType? Consumer can query the Handle to understand = the > device type.