From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web11.1093.1573111075970274513 for ; Wed, 06 Nov 2019 23:17:56 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: jiewen.yao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Nov 2019 23:17:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,277,1569308400"; d="scan'208";a="227742523" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga004.fm.intel.com with ESMTP; 06 Nov 2019 23:17:55 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 6 Nov 2019 23:17:55 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 6 Nov 2019 23:17:54 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 6 Nov 2019 23:17:54 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.108]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.2]) with mapi id 14.03.0439.000; Thu, 7 Nov 2019 15:17:52 +0800 From: "Yao, Jiewen" To: "Ni, Ray" , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" , "Lou, Yun" Subject: Re: [PATCH V2 3/6] IntelSiliconPkg/dec: Add ProtocolGuid definition. Thread-Topic: [PATCH V2 3/6] IntelSiliconPkg/dec: Add ProtocolGuid definition. Thread-Index: AQHVj+cr6KF/4VERFUqRD7elIMcaK6d/Q+jggAASpXA= Date: Thu, 7 Nov 2019 07:17:51 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503F842069@shsmsx102.ccr.corp.intel.com> References: <20191031123127.10900-1-jiewen.yao@intel.com> <20191031123127.10900-4-jiewen.yao@intel.com> <734D49CCEBEEF84792F5B80ED585239D5C352E25@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C352E25@SHSMSX104.ccr.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDJiNDUyYjktOGE3YS00ZTVmLTg4NWYtZDRjYjc1YzczZGU0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibDNkbElEa01FVVFFR0YxYzZrdXY2Z2RWbXV1N1wvZytKenhLSllKNWkwdlRONGZXVFA3RFNXdUk5cGJsQUVLWXYifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: jiewen.yao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I do not see other protocol add such information in DEC file. But I am OK to add. Will do that in V3. > -----Original Message----- > From: Ni, Ray > Sent: Thursday, November 7, 2019 2:12 PM > To: Yao, Jiewen ; devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Lou, Yun > > Subject: RE: [PATCH V2 3/6] IntelSiliconPkg/dec: Add ProtocolGuid definit= ion. >=20 > Jiewen, > Can you add comments to explain the protocol and the associated header fi= le > path? > Like: > ## Guid for EDKII implementation extension, used to indaicate there are= bit > fields in the varstore. > # Include/Guid/MdeModuleHii.h > gEdkiiIfrBitVarstoreGuid =3D {0x82DDD68B, 0x9163, 0x4187, {0x9B, 0x27,= 0x20, > 0xA8, 0xFD, 0x60,0xA7, 0x1D}} >=20 > > -----Original Message----- > > From: Yao, Jiewen > > Sent: Thursday, October 31, 2019 8:31 PM > > To: devel@edk2.groups.io > > Cc: Ni, Ray ; Chaganty, Rangasai V > > ; Lou, Yun > > Subject: [PATCH V2 3/6] IntelSiliconPkg/dec: Add ProtocolGuid definitio= n. > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2303 > > > > Cc: Ray Ni > > Cc: Rangasai V Chaganty > > Cc: Yun Lou > > Signed-off-by: Jiewen Yao > > --- > > Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec > > b/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec > > index 3079fc2869..8c8cd9f49d 100644 > > --- a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec > > +++ b/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec > > @@ -53,6 +53,7 @@ > > > > [Protocols] > > gEdkiiPlatformVTdPolicyProtocolGuid =3D { 0x3d17e448, 0x466, 0x4e20,= { 0x99, > > 0x9f, 0xb2, 0xe1, 0x34, 0x88, 0xee, 0x22 }} > > + gEdkiiDeviceSecurityPolicyProtocolGuid =3D {0x7ea41a99, 0x5e32, 0x4c= 97, > > {0x88, 0xc4, 0xd6, 0xe7, 0x46, 0x84, 0x9, 0xd4}} > > > > [PcdsFixedAtBuild, PcdsPatchableInModule] > > ## Error code for VTd error.

> > -- > > 2.19.2.windows.1