public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"sami.mujawar@arm.com" <sami.mujawar@arm.com>
Cc: "achin.gupta@arm.com" <achin.gupta@arm.com>,
	"supreeth.venkatesh@arm.com" <supreeth.venkatesh@arm.com>,
	"lersek@redhat.com" <lersek@redhat.com>,
	"Matteo.Carlini@arm.com" <Matteo.Carlini@arm.com>,
	"Laura.Moretta@arm.com" <Laura.Moretta@arm.com>,
	"nd@arm.com" <nd@arm.com>
Subject: Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg: Fix build failure - Bug 2253
Date: Thu, 21 Nov 2019 15:15:44 +0000	[thread overview]
Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503F866C0E@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20191121150631.20096-1-sami.mujawar@arm.com>

Reviewed-by: jiewen.yao@intel.com

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sami
> Mujawar
> Sent: Thursday, November 21, 2019 11:07 PM
> To: devel@edk2.groups.io
> Cc: Sami Mujawar <sami.mujawar@arm.com>; achin.gupta@arm.com; Yao,
> Jiewen <jiewen.yao@intel.com>; supreeth.venkatesh@arm.com;
> lersek@redhat.com; Matteo.Carlini@arm.com; Laura.Moretta@arm.com;
> nd@arm.com
> Subject: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg: Fix build failure - Bug
> 2253
> 
> The StandaloneMmPkg currently has code for supporting
> Arm architecture only. Support for X64 and IA32 is
> currently under development on a separate branch.
> 
> However, StandaloneMmPkg/StandaloneMmPkg.dsc is
> indicating that support for X64 and IA32 is
> available which is causing build failures.
> This has been reported in
> https://bugzilla.tianocore.org/show_bug.cgi?id=2253
> 
> This issue has been discussed earlier on the list:
> (1) https://edk2.groups.io/g/devel/message/47276
> 
> (2) https://edk2.groups.io/g/devel/message/47283
> 
> In light of the above, this patch removes IA32 and X64
> from SUPPORTED_ARCHITECTURES, until support for the
> respective architectures is merged into StandaloneMmPkg.
> 
> CC: Achin Gupta <achin.gupta@arm.com>
> CC: Jiewen Yao <jiewen.yao@intel.com>
> CC: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
> CC: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
> 
> ---
> The changes can be seen at:
> https://github.com/samimujawar/edk2/tree/697_stmm_disable_unsupported_a
> rch_v1
> 
> Notes:
>     v1:
>       - Fix for Bug 2253                                            [SAMI]
>         (https://bugzilla.tianocore.org/show_bug.cgi?id=2253)
> 
>  StandaloneMmPkg/StandaloneMmPkg.dsc | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/StandaloneMmPkg/StandaloneMmPkg.dsc
> b/StandaloneMmPkg/StandaloneMmPkg.dsc
> index
> 8a68d397469bdb83586bfeaebedcd52fd528b20f..f9546e182e25fbcd253de0986a
> 1bb554dae1e975 100644
> --- a/StandaloneMmPkg/StandaloneMmPkg.dsc
> +++ b/StandaloneMmPkg/StandaloneMmPkg.dsc
> @@ -2,7 +2,7 @@
>  # Standalone MM Platform.
>  #
>  # Copyright (c) 2015, Intel Corporation. All rights reserved.<BR>
> -# Copyright (c) 2016 - 2018, ARM Limited. All rights reserved.<BR>
> +# Copyright (c) 2016 - 2019, ARM Limited. All rights reserved.<BR>
>  #
>  #    SPDX-License-Identifier: BSD-2-Clause-Patent
>  #
> @@ -19,7 +19,7 @@ [Defines]
>    PLATFORM_VERSION               = 1.0
>    DSC_SPECIFICATION              = 0x00010011
>    OUTPUT_DIRECTORY               = Build/StandaloneMm
> -  SUPPORTED_ARCHITECTURES        = IA32|X64|AARCH64
> +  SUPPORTED_ARCHITECTURES        = AARCH64
>    BUILD_TARGETS                  = DEBUG|RELEASE
>    SKUID_IDENTIFIER               = DEFAULT
> 
> --
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
> 
> 
> 
> 


  reply	other threads:[~2019-11-21 15:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-21 15:06 [PATCH v1 1/1] StandaloneMmPkg: Fix build failure - Bug 2253 Sami Mujawar
2019-11-21 15:15 ` Yao, Jiewen [this message]
2019-11-21 16:03 ` Laszlo Ersek
2019-11-22  2:20   ` Liming Gao
2019-11-22  9:57     ` Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=74D8A39837DF1E4DA445A8C0B3885C503F866C0E@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox