public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: Sami Mujawar <sami.mujawar@arm.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "achin.gupta@arm.com" <achin.gupta@arm.com>,
	"supreeth.venkatesh@arm.com" <supreeth.venkatesh@arm.com>,
	"Matteo.Carlini@arm.com" <Matteo.Carlini@arm.com>,
	"Laura.Moretta@arm.com" <Laura.Moretta@arm.com>,
	"nd@arm.com" <nd@arm.com>
Subject: Re: [PATCH v1 1/1] StandaloneMmPkg: Fix 'missing header' warning
Date: Fri, 22 Nov 2019 02:29:27 +0000	[thread overview]
Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503F868B32@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20191121153828.11096-1-sami.mujawar@arm.com>

Reviewed-by: Jiewen.yao@intel.com

> -----Original Message-----
> From: Sami Mujawar <sami.mujawar@arm.com>
> Sent: Thursday, November 21, 2019 11:38 PM
> To: devel@edk2.groups.io
> Cc: Sami Mujawar <sami.mujawar@arm.com>; achin.gupta@arm.com; Yao,
> Jiewen <jiewen.yao@intel.com>; supreeth.venkatesh@arm.com;
> Matteo.Carlini@arm.com; Laura.Moretta@arm.com; nd@arm.com
> Subject: [PATCH v1 1/1] StandaloneMmPkg: Fix 'missing header' warning
> 
> The Basetools scripts have been updated to report
> warnings if header files are not listed in the
> [Sources] section of the inf files.
> 
> Update StandaloneMmCpu.inf to include the header
> file StandaloneMmCpu.h to fix the warning.
> 
> CC: Achin Gupta <achin.gupta@arm.com>
> CC: Jiewen Yao <jiewen.yao@intel.com>
> CC: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
> Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
> ---
> 
> The changes can be seen at:
> https://github.com/samimujawar/edk2/tree/696_stmm_fix_include_warning_v
> 1
> 
> Notes:
>     v1:
>       - Fix missing header warnings                                 [SAMI]
> 
>  StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf
> | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git
> a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.i
> nf
> b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.i
> nf
> index
> 5cc4915806db72e36da6cec85d5f690c0c958f16..e8f0c97f4513dec261800f4957
> 1e02c9e1e427ce 100644
> ---
> a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.i
> nf
> +++
> b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.i
> nf
> @@ -4,7 +4,7 @@
>  #
>  #  Copyright (c) 2009, Apple Inc. All rights reserved.<BR>
>  #  Copyright (c) 2016 HP Development Company, L.P.
> -#  Copyright (c) 2017 - 2018, ARM Limited. All rights reserved.
> +#  Copyright (c) 2017 - 2019, ARM Limited. All rights reserved.
>  #
>  #  SPDX-License-Identifier: BSD-2-Clause-Patent
>  #
> @@ -21,6 +21,7 @@ [Defines]
> 
>  [Sources]
>    StandaloneMmCpu.c
> +  StandaloneMmCpu.h
>    EventHandle.c
> 
>  [Packages]
> --
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
> 


      parent reply	other threads:[~2019-11-22  2:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-21 15:38 [PATCH v1 1/1] StandaloneMmPkg: Fix 'missing header' warning Sami Mujawar
2019-11-21 15:53 ` [edk2-devel] " Philippe Mathieu-Daudé
2019-11-22  2:29 ` Yao, Jiewen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=74D8A39837DF1E4DA445A8C0B3885C503F868B32@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox