From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web11.1337.1574389771275958190 for ; Thu, 21 Nov 2019 18:29:31 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: jiewen.yao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Nov 2019 18:29:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,228,1571727600"; d="scan'208";a="205269955" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga008.fm.intel.com with ESMTP; 21 Nov 2019 18:29:30 -0800 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 21 Nov 2019 18:29:30 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 21 Nov 2019 18:29:30 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.108]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.60]) with mapi id 14.03.0439.000; Fri, 22 Nov 2019 10:29:28 +0800 From: "Yao, Jiewen" To: Sami Mujawar , "devel@edk2.groups.io" CC: "achin.gupta@arm.com" , "supreeth.venkatesh@arm.com" , "Matteo.Carlini@arm.com" , "Laura.Moretta@arm.com" , "nd@arm.com" Subject: Re: [PATCH v1 1/1] StandaloneMmPkg: Fix 'missing header' warning Thread-Topic: [PATCH v1 1/1] StandaloneMmPkg: Fix 'missing header' warning Thread-Index: AQHVoIHL2d4mbRKKyEqJBWzETAa42aeWeEKg Date: Fri, 22 Nov 2019 02:29:27 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503F868B32@shsmsx102.ccr.corp.intel.com> References: <20191121153828.11096-1-sami.mujawar@arm.com> In-Reply-To: <20191121153828.11096-1-sami.mujawar@arm.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOGIzMjZlNzQtMGQ4ZS00ODVmLTkyZGItZjQ4YjdlODc3MmQyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUTFMNGlWMlByYklGSit3MUEreEdQVkpxb3RnTHA4aFVyblwveFZaV2RxN3VjcnNDdzBwc2pWVmZ4ZnNFQnVcL2p4In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: jiewen.yao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jiewen.yao@intel.com > -----Original Message----- > From: Sami Mujawar > Sent: Thursday, November 21, 2019 11:38 PM > To: devel@edk2.groups.io > Cc: Sami Mujawar ; achin.gupta@arm.com; Yao, > Jiewen ; supreeth.venkatesh@arm.com; > Matteo.Carlini@arm.com; Laura.Moretta@arm.com; nd@arm.com > Subject: [PATCH v1 1/1] StandaloneMmPkg: Fix 'missing header' warning >=20 > The Basetools scripts have been updated to report > warnings if header files are not listed in the > [Sources] section of the inf files. >=20 > Update StandaloneMmCpu.inf to include the header > file StandaloneMmCpu.h to fix the warning. >=20 > CC: Achin Gupta > CC: Jiewen Yao > CC: Supreeth Venkatesh > Signed-off-by: Sami Mujawar > --- >=20 > The changes can be seen at: > https://github.com/samimujawar/edk2/tree/696_stmm_fix_include_warning_v > 1 >=20 > Notes: > v1: > - Fix missing header warnings [SAMI= ] >=20 > StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf > | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git > a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.i > nf > b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.i > nf > index > 5cc4915806db72e36da6cec85d5f690c0c958f16..e8f0c97f4513dec261800f4957 > 1e02c9e1e427ce 100644 > --- > a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.i > nf > +++ > b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.i > nf > @@ -4,7 +4,7 @@ > # > # Copyright (c) 2009, Apple Inc. All rights reserved.
> # Copyright (c) 2016 HP Development Company, L.P. > -# Copyright (c) 2017 - 2018, ARM Limited. All rights reserved. > +# Copyright (c) 2017 - 2019, ARM Limited. All rights reserved. > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > @@ -21,6 +21,7 @@ [Defines] >=20 > [Sources] > StandaloneMmCpu.c > + StandaloneMmCpu.h > EventHandle.c >=20 > [Packages] > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' >=20