From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web09.2493.1576708294867091765 for ; Wed, 18 Dec 2019 14:31:35 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: jiewen.yao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Dec 2019 14:31:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,330,1571727600"; d="scan'208";a="298522781" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga001.jf.intel.com with ESMTP; 18 Dec 2019 14:31:34 -0800 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 18 Dec 2019 14:31:34 -0800 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 18 Dec 2019 14:31:33 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.109]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.46]) with mapi id 14.03.0439.000; Thu, 19 Dec 2019 06:31:32 +0800 From: "Yao, Jiewen" To: "Gao, Liming" , "devel@edk2.groups.io" CC: "Kinney, Michael D" Subject: Re: [PATCH] MdePkg/Spdm: fix Nonce structure error. Thread-Topic: [PATCH] MdePkg/Spdm: fix Nonce structure error. Thread-Index: AQHVtU9dd2bYlZ7Y/02wckVDAh6hs6e/9NvggACGF2A= Date: Wed, 18 Dec 2019 22:31:31 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503F8AB313@shsmsx102.ccr.corp.intel.com> References: <20191218030018.18560-1-jiewen.yao@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E567B89@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E567B89@SHSMSX104.ccr.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDk1YzBjOTctMzhhNy00Y2RjLTlmN2EtOGM2Mzc2NWIyNDU2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTDdIT0R4VzFvWk50OUFTR2hNYUNvM2NkWUp1OU9ZVVpUTlwvbUxvd3Y3Z0NRamFLaXFpWnZRK0htcGREMHMrY1YifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: jiewen.yao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable No impact. Current code does not use Nonce. I just find the issue when I review the final 1.0 spec. Thank you Yao Jiewen > -----Original Message----- > From: Gao, Liming > Sent: Wednesday, December 18, 2019 10:32 PM > To: Yao, Jiewen ; devel@edk2.groups.io > Cc: Kinney, Michael D > Subject: RE: [PATCH] MdePkg/Spdm: fix Nonce structure error. >=20 > Jiewen: > The change is good. Have you found any impact in the existing code? >=20 > Reviewed-by: Liming Gao >=20 > Thanks > Liming > > -----Original Message----- > > From: Yao, Jiewen > > Sent: Wednesday, December 18, 2019 11:00 AM > > To: devel@edk2.groups.io > > Cc: Kinney, Michael D ; Gao, Liming > > > Subject: [PATCH] MdePkg/Spdm: fix Nonce structure error. > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2427 > > > > Align to SPDM 1.0.0 specification. > > Fix Nonce data structure error. > > > > Cc: Michael D Kinney > > Cc: Liming Gao > > Signed-off-by: Jiewen Yao > > --- > > MdePkg/Include/IndustryStandard/Spdm.h | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/MdePkg/Include/IndustryStandard/Spdm.h > b/MdePkg/Include/IndustryStandard/Spdm.h > > index c05395fea7..38ec7748a7 100644 > > --- a/MdePkg/Include/IndustryStandard/Spdm.h > > +++ b/MdePkg/Include/IndustryStandard/Spdm.h > > @@ -1,6 +1,6 @@ > > /** @file > > Definitions of Security Protocol & Data Model Specification (SPDM) > > - version 0.99a in Distributed Management Task Force (DMTF). > > + version 1.0.0 in Distributed Management Task Force (DMTF). > > > > Copyright (c) 2019, Intel Corporation. All rights reserved.
> > SPDX-License-Identifier: BSD-2-Clause-Patent > > @@ -215,7 +215,7 @@ typedef struct { > > /// > > typedef struct { > > SPDM_MESSAGE_HEADER Header; > > - UINT32 Nonce; > > + UINT8 Nonce[32]; > > } SPDM_CHALLENGE_REQUEST; > > > > /// > > @@ -224,7 +224,7 @@ typedef struct { > > typedef struct { > > SPDM_MESSAGE_HEADER Header; > > //UINT8 CertChainHash[DigestSize]; > > -//UINT32 Nonce; > > +//UINT8 Nonce[32]; > > //UINT8 MeasurementSummaryHash[DigestSize]; > > //UINT16 OpaqueLength; > > //UINT8 OpaqueData[OpaqueLength]; > > @@ -236,7 +236,7 @@ typedef struct { > > /// > > typedef struct { > > SPDM_MESSAGE_HEADER Header; > > - UINT32 Nonce; > > + UINT8 Nonce[32]; > > } SPDM_GET_MEASUREMENTS_REQUEST; > > > > /// > > @@ -277,7 +277,7 @@ typedef struct { > > UINT8 NumberOfBlocks; > > UINT8 MeasurementRecordLength[3]; > > //UINT8 MeasurementRecord[MeasurementRecordLength]; > > -//UINT32 Nonce; > > +//UINT8 Nonce[32]; > > //UINT16 OpaqueLength; > > //UINT8 OpaqueData[OpaqueLength]; > > //UINT8 Signature[KeySize]; > > -- > > 2.19.2.windows.1