From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web09.18.1577079361434171675 for ; Sun, 22 Dec 2019 21:36:01 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: jiewen.yao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Dec 2019 21:35:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,346,1571727600"; d="scan'208";a="249369484" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga002.fm.intel.com with ESMTP; 22 Dec 2019 21:35:53 -0800 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 22 Dec 2019 21:35:53 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 22 Dec 2019 21:35:53 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.109]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.29]) with mapi id 14.03.0439.000; Mon, 23 Dec 2019 13:35:51 +0800 From: "Yao, Jiewen" To: "Ni, Ray" , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" Subject: Re: [PATCH] IntelSiliconPkg/IntelPciDeviceSecurity: Use EDKII TCG definition. Thread-Topic: [PATCH] IntelSiliconPkg/IntelPciDeviceSecurity: Use EDKII TCG definition. Thread-Index: AQHVt81gu5WDhddCqUe4XUX5e6fv96fG+JMAgAA9a5A= Date: Mon, 23 Dec 2019 05:35:50 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503F8B2C34@shsmsx102.ccr.corp.intel.com> References: <20191221070743.10720-1-jiewen.yao@intel.com> <734D49CCEBEEF84792F5B80ED585239D5C3A8977@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C3A8977@SHSMSX104.ccr.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTNiNGZlODktYWY2ZC00YjU2LWE4ZmYtNWMzMDMzYzRjMTE3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUXU3T3pUTEtmRStzQVoxSnVaZktZUFUwdWZUZjZSMGRSUUlVaGV1eVpLN0lpNDlTV2p6VUFKVnR0MlQwN0pXdSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: jiewen.yao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Yes. I will. Thank you Yao Jiewen > -----Original Message----- > From: Ni, Ray > Sent: Monday, December 23, 2019 10:00 AM > To: Yao, Jiewen ; devel@edk2.groups.io > Cc: Chaganty, Rangasai V > Subject: RE: [PATCH] IntelSiliconPkg/IntelPciDeviceSecurity: Use EDKII TC= G > definition. >=20 > > > > - PcrIndex =3D EDKII_DEVICE_MEASUREMENT_COMPONENT_PCR_INDEX; > > + PcrIndex =3D 2; >=20 > Jiewen, PcrIndex assignment is using magic value 2 here. > I am ok with this magic value. Can you please add comment to say that thi= s > PCR is a device measurement component PCR? >=20 > With that, Reviewed-by: Ray Ni >=20 > Thanks, > Ray