Re: [PATCH 00/13] Extend and fix the TCG/TCG2 Physical Presence Interface

["Yao, Jiewen" <jiewen.yao@intel.com>]

Hi
I am not clear on the purpose of this extension.

The Bugzilla just describes the solution.
But what is the problem you are trying to resolve? 

I completely don’t understand.

Please do consider add the background information there.
Or it is hard for me to comment.


Thank you
Yao Jiewen

> -----Original Message-----
> From: Gao, Zhichao <zhichao.gao@intel.com>
> Sent: Friday, January 3, 2020 11:04 AM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J <jian.j.wang@intel.com>;
> Zhang, Chao B <chao.b.zhang@intel.com>; Justen, Jordan L
> <jordan.l.justen@intel.com>; Laszlo Ersek <lersek@redhat.com>; Ard Biesheuvel
> <ard.biesheuvel@linaro.org>; Marc-André Lureau
> <marcandre.lureau@redhat.com>; Stefan Berger <stefanb@linux.ibm.com>
> Subject: [PATCH 00/13] Extend and fix the TCG/TCG2 Physical Presence Interface
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2443
> 
> 1. Add two interfaces Tcg2PpVendorLibExecutePendingRequestEx and
> Tcg2PpVendorLibSubmitRequestToPreOSFunctionEx to Tcg2PpVendorLib. It has
> one
> more parameter PPData (type EFI_TCG2_PHYSICAL_PRESENCE) to transfer more
> data.
> 2. Use the Ex version instead of original one in Tcg2PhysicalPresenceLib
> 3. Add a pcd PcdPhysicalPresenceUserConfirmTimeout to control the user
> confirm
> input key timeout.
> 4. Add FunctionIndex to structure type EFI_TCG2_PHYSICAL_PRESENCE to
> transfer
> mTcgNvs->PhysicalPresence.Parameter data.
> 5. Add parameter FunctionIndex to
> Tcg2PhysicalPresenceLibSubmitRequestToPreOSFunctionEx
> to initialize the PPdata.
> 6. Move Tcg2ConfigNvData.h from SecurityPkg/Tcg/Tcg2Config to
> SecurityPkg/Include.
> It is useful for platform code to implement their own Tcg2PhysicalPresenceLib.
> 7. Replace the ASSERT with error code return in TpmPhysicalPresenceLib
> 8. Fix one operation
> (PHYSICAL_PRESENCE_DEACTIVATE_DISABLE_OWNER_FALSE) flow of
> TcgPhysicalPresenceLib (refer to Physical Presence Interface Spec Page 37).
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Chao Zhang <chao.b.zhang@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
> Cc: Stefan Berger <stefanb@linux.ibm.com>
> Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> Zhichao Gao (13):
>   SecurityPkg/Tcg2PpVerndorLib: Add two Ex function to handle PPdata
>   SecurityPkg/Tcg2PpVendorLib: Add implementation of new Ex function
>   SecurityPkg/Tcg2PhysicalPresenceLib: Use the new Ex function
>   SecurityPkg/SmmTcg2PhysicalPresenceLib: Use the new Ex function
>   SecurityPkg/dec: Add a pcd for user response wait time
>   OvmfPkg/Tcg2PhysicalPresenceLib: Use pcd for user response wait time
>   SecurityPkg/Tcg2PhysicalPresenceLib: Use Pcd for user resp wait time
>   SecurityPkg/TcgPyhsicalPresenceLib: Use Pcd for user resp wait time
>   SecurityPkg/Tcg2PhysicalPresenceData.h: Add FunctionIndex for PPdata
>   SecurityPkg/Tcg2PhysicalPresenceLib: Extend the submit preOS func
>   SecurityPkg: Move the Tcg2ConfigNvData.h to Include folder
>   SecurityPkg/TcgPhysicalPresenceLib: Replace the ASSERT with error code
>   SecurityPkg/TcgPhysicalPresenceLib: Fix the operation of 11
> 
>  .../DxeTcg2PhysicalPresenceLib.c              |  63 +++++++---
>  .../DxeTcg2PhysicalPresenceLib.inf            |   6 +-
>  .../Include/Guid/Tcg2PhysicalPresenceData.h   |   3 +-
>  .../Include/Library/Tcg2PhysicalPresenceLib.h |   4 +-
>  SecurityPkg/Include/Library/Tcg2PpVendorLib.h |  54 ++++++++-
>  .../Tcg2Config => Include}/Tcg2ConfigNvData.h |   2 +-
>  .../DxeTcg2PhysicalPresenceLib.c              |  68 ++++++++---
>  .../DxeTcg2PhysicalPresenceLib.inf            |   4 +-
>  .../DxeTcgPhysicalPresenceLib.c               | 110 ++++++++++++------
>  .../DxeTcgPhysicalPresenceLib.inf             |   6 +-
>  .../SmmTcg2PhysicalPresenceLib.c              |  15 ++-
>  .../Tcg2PpVendorLibNull/Tcg2PpVendorLibNull.c |  61 +++++++++-
>  SecurityPkg/SecurityPkg.dec                   |   7 +-
>  SecurityPkg/SecurityPkg.uni                   |   7 +-
>  SecurityPkg/Tcg/Tcg2Config/Tcg2Config.vfr     |   4 +-
>  SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDxe.inf  |   3 +-
>  SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigImpl.h   |   4 +-
>  SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigPei.inf  |   3 +-
>  SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigPeim.c   |   4 +-
>  SecurityPkg/Tcg/Tcg2Config/TpmDetection.c     |   4 +-
>  SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c             |  10 +-
>  21 files changed, 347 insertions(+), 95 deletions(-)
>  rename SecurityPkg/{Tcg/Tcg2Config => Include}/Tcg2ConfigNvData.h (94%)
> 
> --
> 2.21.0.windows.1