From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: Philippe Mathieu-Daude <philmd@redhat.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Antoine Coeur <coeur@gmx.fr>,
"Wang, Jian J" <jian.j.wang@intel.com>,
"Zhang, Chao B" <chao.b.zhang@intel.com>
Subject: Re: [PATCH v2 64/78] SecurityPkg/Library/Tpm: Fix various typos
Date: Fri, 3 Jan 2020 09:54:45 +0000 [thread overview]
Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503F8CA422@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20200103090812.10592-65-philmd@redhat.com>
Reviewed-by: jiewen.yao@intel.com
> -----Original Message-----
> From: Philippe Mathieu-Daude <philmd@redhat.com>
> Sent: Friday, January 3, 2020 5:08 PM
> To: devel@edk2.groups.io
> Cc: Antoine Coeur <coeur@gmx.fr>; Yao, Jiewen <jiewen.yao@intel.com>;
> Wang, Jian J <jian.j.wang@intel.com>; Zhang, Chao B
> <chao.b.zhang@intel.com>; Philippe Mathieu-Daude <philmd@redhat.com>
> Subject: [PATCH v2 64/78] SecurityPkg/Library/Tpm: Fix various typos
>
> From: Antoine Coeur <coeur@gmx.fr>
>
> Fix various typos in comments and documentation.
>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Chao Zhang <chao.b.zhang@intel.com>
> Signed-off-by: Antoine Coeur <coeur@gmx.fr>
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
> ---
> SecurityPkg/Include/Library/TpmCommLib.h | 4 ++--
> SecurityPkg/Library/Tpm12DeviceLibDTpm/Tpm12Tis.c | 4 ++--
> SecurityPkg/Library/Tpm2CommandLib/Tpm2Miscellaneous.c | 2 +-
> SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c | 4 ++--
> SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Tis.c | 6 +++---
> SecurityPkg/Library/TpmCommLib/TisPc.c | 2 +-
> 6 files changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/SecurityPkg/Include/Library/TpmCommLib.h
> b/SecurityPkg/Include/Library/TpmCommLib.h
> index 7e102a6a117d..1d18f8d837db 100644
> --- a/SecurityPkg/Include/Library/TpmCommLib.h
> +++ b/SecurityPkg/Include/Library/TpmCommLib.h
> @@ -185,7 +185,7 @@ typedef TIS_PC_REGISTERS *TIS_PC_REGISTERS_PTR;
> #define TIS_TIMEOUT_D 750 * 1000 // 750ms
>
> //
> -// Max TPM command/reponse length
> +// Max TPM command/response length
> //
> #define TPMCMDBUFLENGTH 1024
>
> @@ -210,7 +210,7 @@ TisPcWaitRegisterBits (
> );
>
> /**
> - Get BurstCount by reading the burstCount field of a TIS regiger
> + Get BurstCount by reading the burstCount field of a TIS register
> in the time of default TIS_TIMEOUT_D.
>
> @param[in] TisReg Pointer to TIS register.
> diff --git a/SecurityPkg/Library/Tpm12DeviceLibDTpm/Tpm12Tis.c
> b/SecurityPkg/Library/Tpm12DeviceLibDTpm/Tpm12Tis.c
> index 1caa076203ba..f858090479e6 100644
> --- a/SecurityPkg/Library/Tpm12DeviceLibDTpm/Tpm12Tis.c
> +++ b/SecurityPkg/Library/Tpm12DeviceLibDTpm/Tpm12Tis.c
> @@ -28,7 +28,7 @@ typedef enum {
> } PTP_INTERFACE_TYPE;
>
> //
> -// Max TPM command/reponse length
> +// Max TPM command/response length
> //
> #define TPMCMDBUFLENGTH 1024
>
> @@ -121,7 +121,7 @@ Tpm12TisPcWaitRegisterBits (
> }
>
> /**
> - Get BurstCount by reading the burstCount field of a TIS regiger
> + Get BurstCount by reading the burstCount field of a TIS register
> in the time of default TIS_TIMEOUT_D.
>
> @param[in] TisReg Pointer to TIS register.
> diff --git a/SecurityPkg/Library/Tpm2CommandLib/Tpm2Miscellaneous.c
> b/SecurityPkg/Library/Tpm2CommandLib/Tpm2Miscellaneous.c
> index 21f3bb5adf8e..32bff458448e 100644
> --- a/SecurityPkg/Library/Tpm2CommandLib/Tpm2Miscellaneous.c
> +++ b/SecurityPkg/Library/Tpm2CommandLib/Tpm2Miscellaneous.c
> @@ -1,5 +1,5 @@
> /** @file
> - Implement TPM2 Miscellanenous related command.
> + Implement TPM2 Miscellaneous related command.
>
> Copyright (c) 2013 - 2016, Intel Corporation. All rights reserved. <BR>
> SPDX-License-Identifier: BSD-2-Clause-Patent
> diff --git a/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c
> b/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c
> index b671cef04ed7..2c73385b6ce5 100644
> --- a/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c
> +++ b/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c
> @@ -26,7 +26,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
> #define PTP_TIMEOUT_MAX (90000 * 1000) // 90s
>
> //
> -// Max TPM command/reponse length
> +// Max TPM command/response length
> //
> #define TPMCMDBUFLENGTH 0x500
>
> @@ -290,7 +290,7 @@ PtpCrbTpmCommand (
> DEBUG ((EFI_D_VERBOSE, "\n"));
> );
> //
> - // Check the reponse data header (tag, parasize and returncode)
> + // Check the response data header (tag, parasize and returncode)
> //
> CopyMem (&Data16, BufferOut, sizeof (UINT16));
> // TPM2 should not use this RSP_COMMAND
> diff --git a/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Tis.c
> b/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Tis.c
> index bbebc94b4d01..9a809612b3d9 100644
> --- a/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Tis.c
> +++ b/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Tis.c
> @@ -22,7 +22,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
> #define TIS_TIMEOUT_MAX (90000 * 1000) // 90s
>
> //
> -// Max TPM command/reponse length
> +// Max TPM command/response length
> //
> #define TPMCMDBUFLENGTH 0x500
>
> @@ -77,7 +77,7 @@ TisPcWaitRegisterBits (
> }
>
> /**
> - Get BurstCount by reading the burstCount field of a TIS regiger
> + Get BurstCount by reading the burstCount field of a TIS register
> in the time of default TIS_TIMEOUT_D.
>
> @param[in] TisReg Pointer to TIS register.
> @@ -340,7 +340,7 @@ Tpm2TisTpmCommand (
> DEBUG ((EFI_D_VERBOSE, "\n"));
> );
> //
> - // Check the reponse data header (tag,parasize and returncode )
> + // Check the response data header (tag,parasize and returncode )
> //
> CopyMem (&Data16, BufferOut, sizeof (UINT16));
> // TPM2 should not use this RSP_COMMAND
> diff --git a/SecurityPkg/Library/TpmCommLib/TisPc.c
> b/SecurityPkg/Library/TpmCommLib/TisPc.c
> index 4a14a2bf8193..533a42e53cee 100644
> --- a/SecurityPkg/Library/TpmCommLib/TisPc.c
> +++ b/SecurityPkg/Library/TpmCommLib/TisPc.c
> @@ -60,7 +60,7 @@ TisPcWaitRegisterBits (
> }
>
> /**
> - Get BurstCount by reading the burstCount field of a TIS regiger
> + Get BurstCount by reading the burstCount field of a TIS register
> in the time of default TIS_TIMEOUT_D.
>
> @param[in] TisReg Pointer to TIS register.
> --
> 2.21.0
next prev parent reply other threads:[~2020-01-03 9:54 UTC|newest]
Thread overview: 122+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-03 9:06 [PATCH v2 00/78] Fix a bunch of typos (part 1) Philippe Mathieu-Daudé
2020-01-03 9:06 ` [PATCH v2 01/78] CryptoPkg/OpensslLib: Fix few typos Philippe Mathieu-Daudé
2020-01-06 2:39 ` Wang, Jian J
2020-01-03 9:06 ` [PATCH v2 02/78] EmbeddedPkg/VirtualKeyboard: Fix a typo in EFI_INVALID_PARAMETER Philippe Mathieu-Daudé
2020-01-08 12:41 ` Ard Biesheuvel
2020-01-03 9:06 ` [PATCH v2 03/78] EmbeddedPkg/VirtualKeyboard: Fix few typos Philippe Mathieu-Daudé
2020-01-08 12:42 ` Ard Biesheuvel
2020-01-08 14:26 ` Philippe Mathieu-Daudé
2020-01-03 9:06 ` [PATCH v2 04/78] EmulatorPkg/Sec: Fix various typos Philippe Mathieu-Daudé
2020-01-03 9:06 ` [PATCH v2 05/78] EmulatorPkg/Unix: " Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 06/78] EmulatorPkg/Win: " Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 07/78] FatPkg/EnhancedFatDxe: " Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 08/78] FatPkg/FatPei: Fix few typos Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 09/78] MdeModulePkg/Application: Improve French translation Philippe Mathieu-Daudé
2020-02-07 0:49 ` Philippe Mathieu-Daudé
2020-02-07 0:53 ` [edk2-devel] " Wu, Hao A
2020-02-07 0:55 ` Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 10/78] MdeModulePkg/Application: Fix various typos Philippe Mathieu-Daudé
2020-02-07 0:26 ` [edk2-devel] " Wu, Hao A
2020-01-03 9:07 ` [PATCH v2 11/78] MdeModulePkg/Bus/Ata: " Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 12/78] MdeModulePkg/Bus/I2c: Fix few typos Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 13/78] MdeModulePkg/Bus/Isa: Fix various typos Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 14/78] MdeModulePkg/Bus/Scsi: " Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 15/78] MdeModulePkg/Bus/Sd: " Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 16/78] MdeModulePkg/Core/Pei: " Philippe Mathieu-Daudé
2020-02-07 0:26 ` Wu, Hao A
2020-01-03 9:07 ` [PATCH v2 17/78] MdeModulePkg/Core/PiSmmCore: " Philippe Mathieu-Daudé
2020-02-07 0:26 ` Wu, Hao A
2020-01-03 9:07 ` [PATCH v2 18/78] MdeModulePkg/UsbBusDxe: Fix a typo Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 19/78] MdeModulePkg/UsbMass: Fix various typos Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 20/78] MdeModulePkg/UsbMouse: Fix few typos Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 21/78] MdeModulePkg/UsbBus: Fix various typos Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 22/78] MdeModulePkg/Usb: " Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 23/78] MdePkg/IndustryStandard: " Philippe Mathieu-Daudé
2020-01-06 3:32 ` Liming Gao
2020-01-03 9:07 ` [PATCH v2 24/78] MdePkg/Library/Dxe: " Philippe Mathieu-Daudé
2020-01-06 3:35 ` Liming Gao
2020-01-03 9:07 ` [PATCH v2 25/78] MdePkg/Library/Pci: " Philippe Mathieu-Daudé
2020-01-06 3:35 ` [edk2-devel] " Liming Gao
2020-01-03 9:07 ` [PATCH v2 26/78] MdePkg/Library/Smm: " Philippe Mathieu-Daudé
2020-01-06 3:35 ` Liming Gao
2020-01-03 9:07 ` [PATCH v2 27/78] MdePkg/Ppi: " Philippe Mathieu-Daudé
2020-01-06 3:36 ` [edk2-devel] " Liming Gao
2020-01-03 9:07 ` [PATCH v2 28/78] MdePkg/Register: " Philippe Mathieu-Daudé
2020-01-06 3:38 ` Liming Gao
2020-01-03 9:07 ` [PATCH v2 29/78] NetworkPkg: Fix a typo Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 30/78] NetworkPkg/ArpDxe: Fix various typos Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 31/78] NetworkPkg/Dhcp4Dxe: " Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 32/78] NetworkPkg/Dhcp6Dxe: " Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 33/78] NetworkPkg/DnsDxe: Fix a typo Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 34/78] NetworkPkg/DnsDxe: Fix various typos Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 35/78] NetworkPkg/DpcDxe: Fix few typos Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 36/78] NetworkPkg/HttpBootDxe: Fix a typo in variable name Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 37/78] NetworkPkg/HttpBootDxe: Fix various typos Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 38/78] NetworkPkg/HttpDxe: " Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 39/78] NetworkPkg/Ip4Dxe: " Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 40/78] NetworkPkg/Ip6Dxe: " Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 41/78] NetworkPkg/IScsiDxe: " Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 42/78] NetworkPkg/Library: " Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 43/78] NetworkPkg/MnpDxe: " Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 44/78] NetworkPkg/Mtftp4Dxe: " Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 45/78] NetworkPkg/Mtftp6Dxe: " Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 46/78] NetworkPkg/SnpDxe: Fix few typos Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 47/78] NetworkPkg/TcpDxe/Sock: " Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 48/78] NetworkPkg/TcpDxe/Tcp: Fix various typos Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 49/78] NetworkPkg/Tls: Fix few typos Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 50/78] NetworkPkg/Udp4Dxe: Fix various typos Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 51/78] NetworkPkg/Udp6Dxe: " Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 52/78] NetworkPkg/UefiPxeBcDxe: " Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 53/78] NetworkPkg/VlanConfigDxe: Fix few typos Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 54/78] OvmfPkg/Acpi: " Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 55/78] OvmfPkg/Csm: Fix various typos Philippe Mathieu-Daudé
2020-01-03 13:40 ` [edk2-devel] " Laszlo Ersek
2020-01-03 9:07 ` [PATCH v2 56/78] OvmfPkg/Csm/LegacyBios: Fix a typo Philippe Mathieu-Daudé
2020-01-03 13:40 ` [edk2-devel] " Laszlo Ersek
2020-01-03 9:07 ` [PATCH v2 57/78] OvmfPkg/Qemu: Fix various typos Philippe Mathieu-Daudé
2020-01-03 13:37 ` Laszlo Ersek
2020-01-03 9:07 ` [PATCH v2 58/78] OvmfPkg/Virtio: Fix few typos Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 59/78] OvmfPkg/Xen: Fix a typo Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 60/78] OvmfPkg/Xen: Fix various typos Philippe Mathieu-Daudé
2020-01-03 13:42 ` [edk2-devel] " Laszlo Ersek
2020-01-06 10:36 ` Anthony PERARD
2020-01-06 16:06 ` Laszlo Ersek
2020-01-03 9:07 ` [PATCH v2 61/78] PcAtChipsetPkg: Fix few typos Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 62/78] SecurityPkg: " Philippe Mathieu-Daudé
2020-01-03 9:56 ` [edk2-devel] " Yao, Jiewen
2020-01-03 9:07 ` [PATCH v2 63/78] SecurityPkg/Hash2DxeCrypto: " Philippe Mathieu-Daudé
2020-01-03 9:55 ` [edk2-devel] " Yao, Jiewen
2020-01-03 9:07 ` [PATCH v2 64/78] SecurityPkg/Library/Tpm: Fix various typos Philippe Mathieu-Daudé
2020-01-03 9:54 ` Yao, Jiewen [this message]
2020-01-03 9:07 ` [PATCH v2 65/78] SecurityPkg/Tcg: " Philippe Mathieu-Daudé
2020-01-03 9:56 ` [edk2-devel] " Yao, Jiewen
2020-01-03 9:08 ` [PATCH v2 66/78] SecurityPkg/VariableAuthenticated: Fix few typos Philippe Mathieu-Daudé
2020-01-03 9:56 ` Yao, Jiewen
2020-01-03 9:08 ` [PATCH v2 67/78] ShellPkg/Application: Fix various typos Philippe Mathieu-Daudé
2020-01-03 9:08 ` [PATCH v2 68/78] ShellPkg/DynamicCommand: " Philippe Mathieu-Daudé
2020-01-03 9:08 ` [PATCH v2 69/78] SignedCapsulePkg: " Philippe Mathieu-Daudé
2020-01-03 9:56 ` Yao, Jiewen
2020-01-03 9:08 ` [PATCH v2 70/78] SignedCapsulePkg/Universal: " Philippe Mathieu-Daudé
2020-01-03 12:13 ` Yao, Jiewen
2020-01-03 9:08 ` [PATCH v2 71/78] SourceLevelDebugPkg/DebugAgent: " Philippe Mathieu-Daudé
2020-01-03 9:08 ` [PATCH v2 72/78] SourceLevelDebugPkg/DebugCommunicationLib: " Philippe Mathieu-Daudé
2020-01-03 9:08 ` [PATCH v2 73/78] SourceLevelDebugPkg: Fix few typos Philippe Mathieu-Daudé
2020-01-03 9:08 ` [PATCH v2 74/78] StandaloneMmPkg: Fix a typo Philippe Mathieu-Daudé
2020-01-03 12:13 ` [edk2-devel] " Yao, Jiewen
2020-01-03 9:08 ` [PATCH v2 75/78] StandaloneMmPkg: Fix few typos Philippe Mathieu-Daudé
2020-01-03 12:14 ` Yao, Jiewen
2020-01-03 9:08 ` [PATCH v2 76/78] UefiCpuPkg/CpuDxe: " Philippe Mathieu-Daudé
2020-01-07 8:28 ` [edk2-devel] " Dong, Eric
2020-01-03 9:08 ` [PATCH v2 77/78] UefiCpuPkg/PiSmm: Fix various typos Philippe Mathieu-Daudé
2020-01-07 8:27 ` [edk2-devel] " Dong, Eric
2020-01-03 9:08 ` [PATCH v2 78/78] UefiCpuPkg/Smm: " Philippe Mathieu-Daudé
2020-01-07 8:28 ` Dong, Eric
2020-01-03 10:59 ` [PATCH v2 00/78] Fix a bunch of typos (part 1) Cœur
2020-01-07 12:44 ` [edk2-devel] " Maciej Rabeda
2020-01-17 17:13 ` Philippe Mathieu-Daudé
2020-01-19 5:14 ` [edk2-devel] " Liming Gao
2020-01-20 8:35 ` Philippe Mathieu-Daudé
2020-01-17 17:15 ` Philippe Mathieu-Daudé
2020-02-06 23:46 ` Philippe Mathieu-Daudé
2020-02-10 15:22 ` [edk2-devel] " Maciej Rabeda
2020-02-10 23:51 ` 答复: " Yao, Jiewen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74D8A39837DF1E4DA445A8C0B3885C503F8CA422@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox