Re: [edk2-devel] [PATCH v2 62/78] SecurityPkg: Fix few typos

["Yao, Jiewen" <jiewen.yao@intel.com>]

Reviewed-by: jiewen.yao@intel.com

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Philippe
> Mathieu-Daudé
> Sent: Friday, January 3, 2020 5:08 PM
> To: devel@edk2.groups.io
> Cc: Antoine Coeur <coeur@gmx.fr>; Yao, Jiewen <jiewen.yao@intel.com>;
> Wang, Jian J <jian.j.wang@intel.com>; Zhang, Chao B
> <chao.b.zhang@intel.com>; Philippe Mathieu-Daude <philmd@redhat.com>
> Subject: [edk2-devel] [PATCH v2 62/78] SecurityPkg: Fix few typos
> 
> From: Antoine Coeur <coeur@gmx.fr>
> 
> Fix few typos in comments and documentation.
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Chao Zhang <chao.b.zhang@intel.com>
> Signed-off-by: Antoine Coeur <coeur@gmx.fr>
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
> ---
>  .../Library/PlatformSecureLibNull/PlatformSecureLibNull.inf     | 2 +-
>  .../DxeTcgPhysicalPresenceLib/DxeTcgPhysicalPresenceLib.c       | 2 +-
>  .../Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLib.c       | 2 +-
>  SecurityPkg/Library/DxeTpmMeasureBootLib/DxeTpmMeasureBootLib.c | 2 +-
>  .../HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.c        | 2 +-
>  .../HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.c        | 2 +-
>  SecurityPkg/Pkcs7Verify/Pkcs7VerifyDxe/Pkcs7VerifyDxe.c         | 2 +-
>  SecurityPkg/RandomNumberGenerator/RngDxe/RngDxe.c               | 2 +-
>  .../Library/PlatformSecureLibNull/PlatformSecureLibNull.uni     | 2 +-
>  9 files changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.inf
> b/SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.inf
> index 9ae597d381fc..85607aa645a1 100644
> --- a/SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.inf
> +++ b/SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.inf
> @@ -1,5 +1,5 @@
>  ## @file
> -#  NULL platform secure library instance that alway returns TRUE for a user
> physical present
> +#  NULL platform secure library instance that always returns TRUE for a user
> physical present
>  #
>  #  NULL PlatformSecureLib instance does NOT really detect whether a physical
> present
>  #  user exists but returns TRUE directly. This instance can be used to verify
> security
> diff --git
> a/SecurityPkg/Library/DxeTcgPhysicalPresenceLib/DxeTcgPhysicalPresenceLib.c
> b/SecurityPkg/Library/DxeTcgPhysicalPresenceLib/DxeTcgPhysicalPresenceLib.c
> index 174172d5d7a5..1a9bd4659a65 100644
> ---
> a/SecurityPkg/Library/DxeTcgPhysicalPresenceLib/DxeTcgPhysicalPresenceLib.c
> +++
> b/SecurityPkg/Library/DxeTcgPhysicalPresenceLib/DxeTcgPhysicalPresenceLib.c
> @@ -175,7 +175,7 @@ TpmPhysicalPresence (
>    @param[in] TcgProtocol              EFI TCG Protocol instance.
>    @param[in] Ordinal                  TPM command code.
>    @param[in] AdditionalParameterSize  Additional parameter size.
> -  @param[in] AdditionalParameters     Pointer to the Additional paramaters.
> +  @param[in] AdditionalParameters     Pointer to the Additional parameters.
> 
>    @retval TCG_PP_OPERATION_RESPONSE_BIOS_FAILURE  Error occurred
> during sending command to TPM or
>                                                    receiving response from TPM.
> diff --git
> a/SecurityPkg/Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLib.c
> b/SecurityPkg/Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLib.c
> index 04b9b0d7fbf3..5ea2d3ba8ed1 100644
> --- a/SecurityPkg/Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLib.c
> +++
> b/SecurityPkg/Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLib.c
> @@ -471,7 +471,7 @@ DxeTpm2MeasureBootHandler (
>    Status = gBS->LocateDevicePath (&gEfiBlockIoProtocolGuid,
> &DevicePathNode, &Handle);
>    if (!EFI_ERROR (Status) && !mTcg2MeasureGptTableFlag) {
>      //
> -    // Find the gpt partion on the given devicepath
> +    // Find the gpt partition on the given devicepath
>      //
>      DevicePathNode = OrigDevicePathNode;
>      ASSERT (DevicePathNode != NULL);
> diff --git
> a/SecurityPkg/Library/DxeTpmMeasureBootLib/DxeTpmMeasureBootLib.c
> b/SecurityPkg/Library/DxeTpmMeasureBootLib/DxeTpmMeasureBootLib.c
> index 1f2eed29a1df..d5aeb35eb72c 100644
> --- a/SecurityPkg/Library/DxeTpmMeasureBootLib/DxeTpmMeasureBootLib.c
> +++ b/SecurityPkg/Library/DxeTpmMeasureBootLib/DxeTpmMeasureBootLib.c
> @@ -769,7 +769,7 @@ DxeTpmMeasureBootHandler (
>    Status = gBS->LocateDevicePath (&gEfiBlockIoProtocolGuid,
> &DevicePathNode, &Handle);
>    if (!EFI_ERROR (Status) && !mMeasureGptTableFlag) {
>      //
> -    // Find the gpt partion on the given devicepath
> +    // Find the gpt partition on the given devicepath
>      //
>      DevicePathNode = OrigDevicePathNode;
>      ASSERT (DevicePathNode != NULL);
> diff --git
> a/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.
> c
> b/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.
> c
> index a7cb05849c00..7a0f61efbb8c 100644
> ---
> a/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.
> c
> +++
> b/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.
> c
> @@ -1,6 +1,6 @@
>  /** @file
>    This library is BaseCrypto router. It will redirect hash request to each individual
> -  hash handler registerd, such as SHA1, SHA256.
> +  hash handler registered, such as SHA1, SHA256.
>    Platform can use PcdTpm2HashMask to mask some hash engines.
> 
>  Copyright (c) 2013 - 2018, Intel Corporation. All rights reserved. <BR>
> diff --git
> a/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.c
> b/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.c
> index d31c8b0782d4..42cb562f67d3 100644
> ---
> a/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.c
> +++
> b/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.c
> @@ -1,6 +1,6 @@
>  /** @file
>    This library is BaseCrypto router. It will redirect hash request to each individual
> -  hash handler registerd, such as SHA1, SHA256.
> +  hash handler registered, such as SHA1, SHA256.
>    Platform can use PcdTpm2HashMask to mask some hash engines.
> 
>  Copyright (c) 2013 - 2018, Intel Corporation. All rights reserved. <BR>
> diff --git a/SecurityPkg/Pkcs7Verify/Pkcs7VerifyDxe/Pkcs7VerifyDxe.c
> b/SecurityPkg/Pkcs7Verify/Pkcs7VerifyDxe/Pkcs7VerifyDxe.c
> index a96862f93733..42282e33a913 100644
> --- a/SecurityPkg/Pkcs7Verify/Pkcs7VerifyDxe/Pkcs7VerifyDxe.c
> +++ b/SecurityPkg/Pkcs7Verify/Pkcs7VerifyDxe/Pkcs7VerifyDxe.c
> @@ -519,7 +519,7 @@ IsValidTimestamp (
>    @param[in]  SignedData      Pointer to buffer containing ASN.1 DER-encoded
> PKCS7
>                                signature.
>    @param[in]  SignedDataSize  The size of SignedData buffer in bytes.
> -  @param[in]  InHash          Pointer to the buffer containing the hash of the
> mesage data
> +  @param[in]  InHash          Pointer to the buffer containing the hash of the
> message data
>                                previously signed and to be verified.
>    @param[in]  InHashSize      The size of InHash buffer in bytes.
>    @param[in]  RevokedDb       Pointer to a list of pointers to
> EFI_SIGNATURE_LIST
> diff --git a/SecurityPkg/RandomNumberGenerator/RngDxe/RngDxe.c
> b/SecurityPkg/RandomNumberGenerator/RngDxe/RngDxe.c
> index 90e54a89ce2b..13d3dbd0bfbe 100644
> --- a/SecurityPkg/RandomNumberGenerator/RngDxe/RngDxe.c
> +++ b/SecurityPkg/RandomNumberGenerator/RngDxe/RngDxe.c
> @@ -4,7 +4,7 @@
>    The driver will use the new RDRAND instruction to produce high-quality, high-
> performance
>    entropy and random number.
> 
> -  RNG Algoritnms defined in UEFI 2.4:
> +  RNG Algorithms defined in UEFI 2.4:
>     - EFI_RNG_ALGORITHM_SP800_90_CTR_256_GUID  - Supported
>       (RDRAND implements a hardware NIST SP800-90 AES-CTR-256 based DRBG)
>     - EFI_RNG_ALGORITHM_RAW                    - Supported
> diff --git a/SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.uni
> b/SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.uni
> index e5c9d1020ff9..860b8cbb5a05 100644
> --- a/SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.uni
> +++ b/SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.uni
> @@ -1,5 +1,5 @@
>  // /** @file
> -// NULL platform secure library instance that alway returns TRUE for a user
> physical present
> +// NULL platform secure library instance that always returns TRUE for a user
> physical present
>  //
>  // NULL PlatformSecureLib instance does NOT really detect whether a physical
> present
>  // user exists but returns TRUE directly. This instance can be used to verify
> security
> --
> 2.21.0
> 
> 
>