From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "Wang, Iwen Evelyn" <iwen.evelyn.wang@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Huang, Jenny" <jenny.huang@intel.com>,
"Shih, More" <more.shih@intel.com>, "Ni, Ray" <ray.ni@intel.com>,
"Chaganty, Rangasai V" <rangasai.v.chaganty@intel.com>
Subject: Re: [PATCH v1] IntelSiliconPkg-VTd: Fixed a ECC Error
Date: Fri, 10 Jan 2020 00:25:58 +0000 [thread overview]
Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503F8D9015@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20200109221438.12172-1-iwen.evelyn.wang@intel.com>
Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
> -----Original Message-----
> From: Wang, Iwen Evelyn <iwen.evelyn.wang@intel.com>
> Sent: Friday, January 10, 2020 6:15 AM
> To: devel@edk2.groups.io
> Cc: Huang, Jenny <jenny.huang@intel.com>; Shih, More <more.shih@intel.com>;
> Ni, Ray <ray.ni@intel.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>
> Subject: [PATCH v1] IntelSiliconPkg-VTd: Fixed a ECC Error
>
> The function has NO comment immediately preceding it.
> Need to remove the space between the function and the comment
>
> Signed-off-by: Evelyn Wang <iwen.evelyn.wang@intel.com>
> Cc: Jenny Huang <jenny.huang@intel.com>
> Cc: More Shih <more.shih@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
>
> ---
> In V1:
> Add a issue description
> ---
> Silicon/Intel/IntelSiliconPkg/Include/Library/PeiGetVtdPmrAlignmentLib.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git
> a/Silicon/Intel/IntelSiliconPkg/Include/Library/PeiGetVtdPmrAlignmentLib.h
> b/Silicon/Intel/IntelSiliconPkg/Include/Library/PeiGetVtdPmrAlignmentLib.h
> index ebfe904053..86c519f48d 100644
> --- a/Silicon/Intel/IntelSiliconPkg/Include/Library/PeiGetVtdPmrAlignmentLib.h
> +++ b/Silicon/Intel/IntelSiliconPkg/Include/Library/PeiGetVtdPmrAlignmentLib.h
> @@ -13,7 +13,6 @@
> Get the global VT-d protected memory alignment.
> @return The maximum protected memory alignment. Ex: 0x100000
> **/
> -
> UINTN
> EFIAPI
> GetGlobalVtdPmrAlignment (
> --
> 2.16.2.windows.1
prev parent reply other threads:[~2020-01-10 0:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-09 22:14 [PATCH v1] IntelSiliconPkg-VTd: Fixed a ECC Error Evelyn Wang
2020-01-09 22:25 ` Chaganty, Rangasai V
2020-01-10 0:25 ` Yao, Jiewen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74D8A39837DF1E4DA445A8C0B3885C503F8D9015@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox