From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web11.3369.1578615962612118997 for ; Thu, 09 Jan 2020 16:26:02 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: jiewen.yao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jan 2020 16:26:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,414,1571727600"; d="scan'208";a="396260148" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga005.jf.intel.com with ESMTP; 09 Jan 2020 16:26:01 -0800 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 9 Jan 2020 16:26:01 -0800 Received: from shsmsx153.ccr.corp.intel.com (10.239.6.53) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 9 Jan 2020 16:26:00 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.202]) by SHSMSX153.ccr.corp.intel.com ([169.254.12.89]) with mapi id 14.03.0439.000; Fri, 10 Jan 2020 08:25:58 +0800 From: "Yao, Jiewen" To: "Wang, Iwen Evelyn" , "devel@edk2.groups.io" CC: "Huang, Jenny" , "Shih, More" , "Ni, Ray" , "Chaganty, Rangasai V" Subject: Re: [PATCH v1] IntelSiliconPkg-VTd: Fixed a ECC Error Thread-Topic: [PATCH v1] IntelSiliconPkg-VTd: Fixed a ECC Error Thread-Index: AQHVxzoy/CALCBtIHUGyOQnI/W+D1qfjCoBg Date: Fri, 10 Jan 2020 00:25:58 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503F8D9015@shsmsx102.ccr.corp.intel.com> References: <20200109221438.12172-1-iwen.evelyn.wang@intel.com> In-Reply-To: <20200109221438.12172-1-iwen.evelyn.wang@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOGViZWI1NGEtZjU1ZC00YjE5LWE5NjctNTUyOThkODlmMDY2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoieTVPZWJCeXdSSzJrcnE0Z3NhWG1XNzRvT21Zd0JMelZkQjJwXC9BOEpaSFlLRzhrK1wvVlhDZzdwZ0tiT0Z4VHN6In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: jiewen.yao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jiewen Yao > -----Original Message----- > From: Wang, Iwen Evelyn > Sent: Friday, January 10, 2020 6:15 AM > To: devel@edk2.groups.io > Cc: Huang, Jenny ; Shih, More ; > Ni, Ray ; Chaganty, Rangasai V > ; Yao, Jiewen > Subject: [PATCH v1] IntelSiliconPkg-VTd: Fixed a ECC Error >=20 > The function has NO comment immediately preceding it. > Need to remove the space between the function and the comment >=20 > Signed-off-by: Evelyn Wang > Cc: Jenny Huang > Cc: More Shih > Cc: Ray Ni > Cc: Rangasai V Chaganty > Cc: Jiewen Yao >=20 > --- > In V1: > Add a issue description > --- > Silicon/Intel/IntelSiliconPkg/Include/Library/PeiGetVtdPmrAlignmentLib.h= | 1 - > 1 file changed, 1 deletion(-) >=20 > diff --git > a/Silicon/Intel/IntelSiliconPkg/Include/Library/PeiGetVtdPmrAlignmentLib.= h > b/Silicon/Intel/IntelSiliconPkg/Include/Library/PeiGetVtdPmrAlignmentLib.= h > index ebfe904053..86c519f48d 100644 > --- a/Silicon/Intel/IntelSiliconPkg/Include/Library/PeiGetVtdPmrAlignment= Lib.h > +++ b/Silicon/Intel/IntelSiliconPkg/Include/Library/PeiGetVtdPmrAlignment= Lib.h > @@ -13,7 +13,6 @@ > Get the global VT-d protected memory alignment. > @return The maximum protected memory alignment. Ex: 0x100000 > **/ > - > UINTN > EFIAPI > GetGlobalVtdPmrAlignment ( > -- > 2.16.2.windows.1